diff options
author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2022-11-11 14:23:54 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2022-11-14 16:22:00 +0000 |
commit | d8e9ee8fd53b7620e72b2dfebb2e8d464b737dbb (patch) | |
tree | d815af2cb816524186a52c3f031dca5374e733d0 /bitbake/lib/bb/data.py | |
parent | de98b12ee17717bf4c18a02833e7a5260c7cb75d (diff) | |
download | poky-d8e9ee8fd53b7620e72b2dfebb2e8d464b737dbb.tar.gz |
bitbake: data/data_smart/build: Clean up datastore finalize/update_data references
We dropped the update_data calls a while ago. Clean up the code
to match the reality and drop the remaining no-op pieces. Update
the comments to reflect the slowest operations and let the cookie
monster's spirit live on!
(Bitbake rev: 584989ed2b5af4e8799571dece0cf94f995ef14e)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/bb/data.py')
-rw-r--r-- | bitbake/lib/bb/data.py | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/bitbake/lib/bb/data.py b/bitbake/lib/bb/data.py index 4be26367d2..3a6af325f4 100644 --- a/bitbake/lib/bb/data.py +++ b/bitbake/lib/bb/data.py | |||
@@ -4,14 +4,16 @@ BitBake 'Data' implementations | |||
4 | Functions for interacting with the data structure used by the | 4 | Functions for interacting with the data structure used by the |
5 | BitBake build tools. | 5 | BitBake build tools. |
6 | 6 | ||
7 | The expandKeys and update_data are the most expensive | 7 | expandKeys and datastore iteration are the most expensive |
8 | operations. At night the cookie monster came by and | 8 | operations. Updating overrides is now "on the fly" but still based |
9 | on the idea of the cookie monster introduced by zecke: | ||
10 | "At night the cookie monster came by and | ||
9 | suggested 'give me cookies on setting the variables and | 11 | suggested 'give me cookies on setting the variables and |
10 | things will work out'. Taking this suggestion into account | 12 | things will work out'. Taking this suggestion into account |
11 | applying the skills from the not yet passed 'Entwurf und | 13 | applying the skills from the not yet passed 'Entwurf und |
12 | Analyse von Algorithmen' lecture and the cookie | 14 | Analyse von Algorithmen' lecture and the cookie |
13 | monster seems to be right. We will track setVar more carefully | 15 | monster seems to be right. We will track setVar more carefully |
14 | to have faster update_data and expandKeys operations. | 16 | to have faster datastore operations." |
15 | 17 | ||
16 | This is a trade-off between speed and memory again but | 18 | This is a trade-off between speed and memory again but |
17 | the speed is more critical here. | 19 | the speed is more critical here. |
@@ -264,10 +266,6 @@ def emit_func_python(func, o=sys.__stdout__, d = init()): | |||
264 | newdeps |= set((d.getVarFlag(dep, "vardeps") or "").split()) | 266 | newdeps |= set((d.getVarFlag(dep, "vardeps") or "").split()) |
265 | newdeps -= seen | 267 | newdeps -= seen |
266 | 268 | ||
267 | def update_data(d): | ||
268 | """Performs final steps upon the datastore, including application of overrides""" | ||
269 | d.finalize(parent = True) | ||
270 | |||
271 | def build_dependencies(key, keys, shelldeps, varflagsexcl, ignored_vars, d): | 269 | def build_dependencies(key, keys, shelldeps, varflagsexcl, ignored_vars, d): |
272 | deps = set() | 270 | deps = set() |
273 | try: | 271 | try: |