summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2024-05-22 16:40:50 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2024-05-23 11:26:39 +0100
commitbde5c8d7bc25438fa582fcc67b2041a581db7ccf (patch)
treeaefbe3cdc732927828855b3a64bc275646fe0eec
parent29d6993b143889517958eba9b97c0f4973a2c6ff (diff)
downloadpoky-bde5c8d7bc25438fa582fcc67b2041a581db7ccf.tar.gz
base/insane: Move S/B checks to more logical place in insane class
(From OE-Core rev: f8f3315d58f9ec7824961d1f6f96d39c449b9578) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/classes-global/base.bbclass5
-rw-r--r--meta/classes-global/insane.bbclass4
2 files changed, 4 insertions, 5 deletions
diff --git a/meta/classes-global/base.bbclass b/meta/classes-global/base.bbclass
index 4ac7bafefa..b6940bbb6f 100644
--- a/meta/classes-global/base.bbclass
+++ b/meta/classes-global/base.bbclass
@@ -428,11 +428,6 @@ python () {
428 oe.utils.features_backfill("DISTRO_FEATURES", d) 428 oe.utils.features_backfill("DISTRO_FEATURES", d)
429 oe.utils.features_backfill("MACHINE_FEATURES", d) 429 oe.utils.features_backfill("MACHINE_FEATURES", d)
430 430
431 if d.getVar("S")[-1] == '/':
432 bb.warn("Recipe %s sets S variable with trailing slash '%s', remove it" % (d.getVar("PN"), d.getVar("S")))
433 if d.getVar("B")[-1] == '/':
434 bb.warn("Recipe %s sets B variable with trailing slash '%s', remove it" % (d.getVar("PN"), d.getVar("B")))
435
436 # To add a recipe to the skip list , set: 431 # To add a recipe to the skip list , set:
437 # SKIP_RECIPE[pn] = "message" 432 # SKIP_RECIPE[pn] = "message"
438 pn = d.getVar('PN') 433 pn = d.getVar('PN')
diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass
index 42ed1a24a7..99736830b9 100644
--- a/meta/classes-global/insane.bbclass
+++ b/meta/classes-global/insane.bbclass
@@ -1609,6 +1609,10 @@ python () {
1609 bb.fatal("Using S = ${WORKDIR} is no longer supported") 1609 bb.fatal("Using S = ${WORKDIR} is no longer supported")
1610 if builddir == workdir: 1610 if builddir == workdir:
1611 bb.fatal("Using B = ${WORKDIR} is no longer supported") 1611 bb.fatal("Using B = ${WORKDIR} is no longer supported")
1612 if sourcedir[-1] == '/':
1613 bb.warn("Recipe %s sets S variable with trailing slash '%s', remove it" % (d.getVar("PN"), d.getVar("S")))
1614 if builddir[-1] == '/':
1615 bb.warn("Recipe %s sets B variable with trailing slash '%s', remove it" % (d.getVar("PN"), d.getVar("B")))
1612 1616
1613 # Some people mistakenly use DEPENDS:${PN} instead of DEPENDS and wonder 1617 # Some people mistakenly use DEPENDS:${PN} instead of DEPENDS and wonder
1614 # why it doesn't work. 1618 # why it doesn't work.