diff options
author | Hongxu Jia <hongxu.jia@windriver.com> | 2019-12-13 14:28:58 +0800 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2019-12-28 23:25:41 +0000 |
commit | 56fa7845a4d7c0f0b21435457775e83e9c6314f9 (patch) | |
tree | 8b3b5d0a2ac5f3500e28a6f4e42c8d1caadd37a3 | |
parent | 6dd87e45f3db9c3402c9b030bb8cc0255bb45582 (diff) | |
download | poky-56fa7845a4d7c0f0b21435457775e83e9c6314f9.tar.gz |
assimp: fix search library failed on multilib
While multilib enabled, it builds vulkan-demos failed
...
|CMake Error at tmp-glibc/work/aarch64-wrs-linux/vulkan-demos/git-r0/
recipe-sysroot/usr/lib64/cmake/assimp-5.0/assimpTargets.cmake:85 (message):
| The imported target "assimp::assimp" references the file
| "tmp-glibc/work/aarch64-wrs-linux/vulkan-demos/git-r0/recipe-sysroot/usr/lib/libassimp.so.5"
| but this file does not exist. Possible reasons include:
...
Since oe-core set ASSIMP_LIB_INSTALL_DIR to baselib, use it rather than
hardcoded `/lib' to search library
(From OE-Core rev: 2f37056cc6380a6dbc6e43152d2c7a4846526904)
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r-- | meta/recipes-graphics/vulkan/assimp/0001-Use-ASSIMP_LIB_INSTALL_DIR-to-search-library.patch | 70 | ||||
-rw-r--r-- | meta/recipes-graphics/vulkan/assimp_5.0.0.bb | 1 |
2 files changed, 71 insertions, 0 deletions
diff --git a/meta/recipes-graphics/vulkan/assimp/0001-Use-ASSIMP_LIB_INSTALL_DIR-to-search-library.patch b/meta/recipes-graphics/vulkan/assimp/0001-Use-ASSIMP_LIB_INSTALL_DIR-to-search-library.patch new file mode 100644 index 0000000000..3e9fbec701 --- /dev/null +++ b/meta/recipes-graphics/vulkan/assimp/0001-Use-ASSIMP_LIB_INSTALL_DIR-to-search-library.patch | |||
@@ -0,0 +1,70 @@ | |||
1 | From dd5c10f660716a2fab513714245be1932003306b Mon Sep 17 00:00:00 2001 | ||
2 | From: Hongxu Jia <hongxu.jia@windriver.com> | ||
3 | Date: Thu, 12 Dec 2019 22:16:15 -0800 | ||
4 | Subject: [PATCH] Use ASSIMP_LIB_INSTALL_DIR to search library | ||
5 | |||
6 | Use ASSIMP_LIB_INSTALL_DIR rather than hardcoded /lib to search library | ||
7 | |||
8 | Upstream-Status: Inappropriate [oe specific] | ||
9 | |||
10 | Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> | ||
11 | --- | ||
12 | assimpTargets-release.cmake.in | 16 ++++++++-------- | ||
13 | 1 file changed, 8 insertions(+), 8 deletions(-) | ||
14 | |||
15 | diff --git a/assimpTargets-release.cmake.in b/assimpTargets-release.cmake.in | ||
16 | index b09b881f..5c6999fe 100644 | ||
17 | --- a/assimpTargets-release.cmake.in | ||
18 | +++ b/assimpTargets-release.cmake.in | ||
19 | @@ -42,11 +42,11 @@ if(MSVC) | ||
20 | # Import target "assimp::assimp" for configuration "Release" | ||
21 | set_property(TARGET assimp::assimp APPEND PROPERTY IMPORTED_CONFIGURATIONS RELEASE) | ||
22 | set_target_properties(assimp::assimp PROPERTIES | ||
23 | - IMPORTED_IMPLIB_RELEASE "${_IMPORT_PREFIX}/lib/${importLibraryName}" | ||
24 | + IMPORTED_IMPLIB_RELEASE "${_IMPORT_PREFIX}/@ASSIMP_LIB_INSTALL_DIR@/${importLibraryName}" | ||
25 | IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/bin/${sharedLibraryName}" | ||
26 | ) | ||
27 | list(APPEND _IMPORT_CHECK_TARGETS assimp::assimp ) | ||
28 | - list(APPEND _IMPORT_CHECK_FILES_FOR_assimp::assimp "${_IMPORT_PREFIX}/lib/${importLibraryName}") | ||
29 | + list(APPEND _IMPORT_CHECK_FILES_FOR_assimp::assimp "${_IMPORT_PREFIX}/@ASSIMP_LIB_INSTALL_DIR@/${importLibraryName}") | ||
30 | list(APPEND _IMPORT_CHECK_FILES_FOR_assimp::assimp "${_IMPORT_PREFIX}/bin/${sharedLibraryName}" ) | ||
31 | else() | ||
32 | set(staticLibraryName "assimp${ASSIMP_LIBRARY_SUFFIX}@CMAKE_STATIC_LIBRARY_SUFFIX@") | ||
33 | @@ -54,10 +54,10 @@ if(MSVC) | ||
34 | # Import target "assimp::assimp" for configuration "Release" | ||
35 | set_property(TARGET assimp::assimp APPEND PROPERTY IMPORTED_CONFIGURATIONS RELEASE) | ||
36 | set_target_properties(assimp::assimp PROPERTIES | ||
37 | - IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/lib/${staticLibraryName}" | ||
38 | + IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/@ASSIMP_LIB_INSTALL_DIR@/${staticLibraryName}" | ||
39 | ) | ||
40 | list(APPEND _IMPORT_CHECK_TARGETS assimp::assimp ) | ||
41 | - list(APPEND _IMPORT_CHECK_FILES_FOR_assimp::assimp "${_IMPORT_PREFIX}/lib/${staticLibraryName}") | ||
42 | + list(APPEND _IMPORT_CHECK_FILES_FOR_assimp::assimp "${_IMPORT_PREFIX}/@ASSIMP_LIB_INSTALL_DIR@/${staticLibraryName}") | ||
43 | endif() | ||
44 | |||
45 | else() | ||
46 | @@ -66,17 +66,17 @@ else() | ||
47 | set(sharedLibraryName "libassimp${ASSIMP_LIBRARY_SUFFIX}@CMAKE_SHARED_LIBRARY_SUFFIX@.@ASSIMP_VERSION_MAJOR@") | ||
48 | set_target_properties(assimp::assimp PROPERTIES | ||
49 | IMPORTED_SONAME_RELEASE "${sharedLibraryName}" | ||
50 | - IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/lib/${sharedLibraryName}" | ||
51 | + IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/@ASSIMP_LIB_INSTALL_DIR@/${sharedLibraryName}" | ||
52 | ) | ||
53 | list(APPEND _IMPORT_CHECK_TARGETS assimp::assimp ) | ||
54 | - list(APPEND _IMPORT_CHECK_FILES_FOR_assimp::assimp "${_IMPORT_PREFIX}/lib/${sharedLibraryName}" ) | ||
55 | + list(APPEND _IMPORT_CHECK_FILES_FOR_assimp::assimp "${_IMPORT_PREFIX}/@ASSIMP_LIB_INSTALL_DIR@/${sharedLibraryName}" ) | ||
56 | else() | ||
57 | set(staticLibraryName "libassimp${ASSIMP_LIBRARY_SUFFIX}@CMAKE_STATIC_LIBRARY_SUFFIX@") | ||
58 | set_target_properties(assimp::assimp PROPERTIES | ||
59 | - IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/lib/${staticLibraryName}" | ||
60 | + IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/@ASSIMP_LIB_INSTALL_DIR@/${staticLibraryName}" | ||
61 | ) | ||
62 | list(APPEND _IMPORT_CHECK_TARGETS assimp::assimp ) | ||
63 | - list(APPEND _IMPORT_CHECK_FILES_FOR_assimp::assimp "${_IMPORT_PREFIX}/lib/${staticLibraryName}" ) | ||
64 | + list(APPEND _IMPORT_CHECK_FILES_FOR_assimp::assimp "${_IMPORT_PREFIX}/@ASSIMP_LIB_INSTALL_DIR@/${staticLibraryName}" ) | ||
65 | endif() | ||
66 | endif() | ||
67 | |||
68 | -- | ||
69 | 2.21.0 | ||
70 | |||
diff --git a/meta/recipes-graphics/vulkan/assimp_5.0.0.bb b/meta/recipes-graphics/vulkan/assimp_5.0.0.bb index 77e3651e45..a42494a920 100644 --- a/meta/recipes-graphics/vulkan/assimp_5.0.0.bb +++ b/meta/recipes-graphics/vulkan/assimp_5.0.0.bb | |||
@@ -10,6 +10,7 @@ DEPENDS = "zlib" | |||
10 | 10 | ||
11 | SRC_URI = "git://github.com/assimp/assimp.git \ | 11 | SRC_URI = "git://github.com/assimp/assimp.git \ |
12 | file://0001-closes-https-github.com-assimp-assimp-issues-2733-up.patch \ | 12 | file://0001-closes-https-github.com-assimp-assimp-issues-2733-up.patch \ |
13 | file://0001-Use-ASSIMP_LIB_INSTALL_DIR-to-search-library.patch \ | ||
13 | " | 14 | " |
14 | UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>(\d+(\.\d+)+))" | 15 | UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>(\d+(\.\d+)+))" |
15 | 16 | ||