diff options
author | Alexander Kanavin <alex@linutronix.de> | 2025-06-06 10:59:48 +0200 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2025-06-09 17:43:41 +0100 |
commit | 3a48760dd85feabd47e9a42e077399d2be277027 (patch) | |
tree | 59d648996214d5cf4eb8b7b689f0bbbf381195c4 | |
parent | 41610329189ede3c1f986e496eecd67bec0118b4 (diff) | |
download | poky-3a48760dd85feabd47e9a42e077399d2be277027.tar.gz |
lib/oeqa/utils/sshcontrol: correct condition for ending the select() loop
This was set backwards; per https://docs.python.org/3/library/subprocess.html#subprocess.Popen.returncode
a return code of None indicates the process is still running,
and so the code entered a busyloop that ended on timeout
5 minutes later, lengthening selftests significantly.
(From OE-Core rev: a6690deffd7ddbce0e784701ea3fdbb84313b009)
Signed-off-by: Alexander Kanavin <alex@linutronix.de>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r-- | meta/lib/oeqa/utils/sshcontrol.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/lib/oeqa/utils/sshcontrol.py b/meta/lib/oeqa/utils/sshcontrol.py index 6c5648779a..88a61aff63 100644 --- a/meta/lib/oeqa/utils/sshcontrol.py +++ b/meta/lib/oeqa/utils/sshcontrol.py | |||
@@ -58,7 +58,7 @@ class SSHProcess(object): | |||
58 | data = os.read(self.process.stdout.fileno(), 1024) | 58 | data = os.read(self.process.stdout.fileno(), 1024) |
59 | if not data: | 59 | if not data: |
60 | self.process.poll() | 60 | self.process.poll() |
61 | if self.process.returncode is None: | 61 | if self.process.returncode is not None: |
62 | self.process.stdout.close() | 62 | self.process.stdout.close() |
63 | eof = True | 63 | eof = True |
64 | else: | 64 | else: |