summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorUlf Magnusson <ulfalizer@gmail.com>2016-10-01 04:47:04 +0200
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-10-04 16:29:04 +0100
commit39f80cefcccd0265af0027c318b991ae109063dc (patch)
treea632d1e44240b448169f77f320334d3be9cb0266
parentdb6ae5254408a1a8266d56b95fb02235794e46ce (diff)
downloadpoky-39f80cefcccd0265af0027c318b991ae109063dc.tar.gz
sstate.bbclass: Use bb.fatal() instead of raising FuncFailed
This sets a good example and avoids unnecessarily contributing to perceived complexity and cargo culting. Motivating quote below: < kergoth> the *original* intent was for the function/task to error via whatever appropriate means, bb.fatal, whatever, and funcfailed was what you'd catch if you were calling exec_func/exec_task. that is, it's what those functions raise, not what metadata functions should be raising < kergoth> it didn't end up being used that way < kergoth> but there's really never a reason to raise it yourself FuncFailed.__init__ takes a 'name' argument rather than a 'msg' argument, which also shows that the original purpose got lost. (From OE-Core rev: 33611b69c221cf875eba1c7cb599c256825ae470) Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/classes/sstate.bbclass2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
index ac9d77d528..6f0c791fe5 100644
--- a/meta/classes/sstate.bbclass
+++ b/meta/classes/sstate.bbclass
@@ -658,7 +658,7 @@ def sstate_setscene(d):
658 shared_state = sstate_state_fromvars(d) 658 shared_state = sstate_state_fromvars(d)
659 accelerate = sstate_installpkg(shared_state, d) 659 accelerate = sstate_installpkg(shared_state, d)
660 if not accelerate: 660 if not accelerate:
661 raise bb.build.FuncFailed("No suitable staging package found") 661 bb.fatal("No suitable staging package found")
662 662
663python sstate_task_prefunc () { 663python sstate_task_prefunc () {
664 shared_state = sstate_state_fromvars(d) 664 shared_state = sstate_state_fromvars(d)