summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Kjellerstedt <peter.kjellerstedt@axis.com>2014-02-20 15:55:51 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2018-01-08 08:48:54 +0000
commit205cfd702190026e64eed9cae27c05ff62d1637e (patch)
tree687caaed9a145a64889a084244bbcaa233a35122
parent869ae2ce2a9940644c0b591ec9432281bafafa0a (diff)
downloadpoky-205cfd702190026e64eed9cae27c05ff62d1637e.tar.gz
bitbake: fetch2/__init__: Disable pseudo in runfetchcmd()
If a fetcher, e.g., git, is run when pseudo is active it will think it is running as root. If it in turn uses ssh (as git does), ssh too will think it is running as root. This will cause it to try to read root's ssh configuration from /root/.ssh which will fail. If ssh then needs to ask for credentials it will hang indefinitely as there is nowhere for it to ask the user for them (and even if there was it would not access the correct private keys). The solution to the above is to temporarily disable pseudo while executing any fetcher commands. There should be no reason for them to be executed under pseudo anyway so this should not be a problem. RP Ammendum: We finally did get more information about how to reproduce this problem, something needs to trigger bb.fetch2.get_srcrev() in a pseudo context, for example when AUTOREV is in use or the recipe doesn't have a defined SRCREV. That SRC_URI needs to be using protocol=ssh. This would trigger an ls-remote of the remote repo and if that happens under pseudo, the wrong ssh credentials may be attempted which can hang. [YOCTO #12464] (Bitbake rev: ceaca281cafa662aa2385b95641bce309dce843d) Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--bitbake/lib/bb/fetch2/__init__.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/bitbake/lib/bb/fetch2/__init__.py b/bitbake/lib/bb/fetch2/__init__.py
index cb94bf6000..6bd040493e 100644
--- a/bitbake/lib/bb/fetch2/__init__.py
+++ b/bitbake/lib/bb/fetch2/__init__.py
@@ -853,6 +853,9 @@ def runfetchcmd(cmd, d, quiet=False, cleanup=None, log=None, workdir=None):
853 if val: 853 if val:
854 cmd = 'export ' + var + '=\"%s\"; %s' % (val, cmd) 854 cmd = 'export ' + var + '=\"%s\"; %s' % (val, cmd)
855 855
856 # Disable pseudo as it may affect ssh, potentially causing it to hang.
857 cmd = 'export PSEUDO_DISABLED=1; ' + cmd
858
856 logger.debug(1, "Running %s", cmd) 859 logger.debug(1, "Running %s", cmd)
857 860
858 success = False 861 success = False