summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoshua Lock <joshua.g.lock@intel.com>2016-10-04 11:03:55 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-10-05 10:25:34 +0100
commit1110dde73aa04772090ca7b2b21a953d49734fb0 (patch)
treebd08fd5321f763f7061c792478cf7efda90193db
parent079396f5a2909e479a0a8652b16bec6a99674914 (diff)
downloadpoky-1110dde73aa04772090ca7b2b21a953d49734fb0.tar.gz
bitbake: event: prevent unclosed file warning in print_ui_queue
Use logger.addHandler(), rather than assigning an array of Handlers to the loggers handlers property directly, to avoid a warning from Python 3 about unclosed files: $ bitbake Nothing to do. Use 'bitbake world' to build everything, or run 'bitbake --help' for usage information. WARNING: /home/joshuagl/Projects/poky/bitbake/lib/bb/event.py:143: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/joshuagl/Projects/poky/build/tmp/log/cooker/qemux86/20161004094928.log' mode='a' encoding='UTF-8'> logger.handlers = [stdout] (Bitbake rev: 1e23b1f1a80066223b98e18b163840051ac74944) Signed-off-by: Joshua Lock <joshua.g.lock@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--bitbake/lib/bb/event.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/bitbake/lib/bb/event.py b/bitbake/lib/bb/event.py
index 65b7ebb43b..c5a5f94dee 100644
--- a/bitbake/lib/bb/event.py
+++ b/bitbake/lib/bb/event.py
@@ -143,16 +143,16 @@ def print_ui_queue():
143 if isinstance(event, logging.LogRecord): 143 if isinstance(event, logging.LogRecord):
144 if event.levelno > logging.DEBUG: 144 if event.levelno > logging.DEBUG:
145 if event.levelno >= logging.WARNING: 145 if event.levelno >= logging.WARNING:
146 logger.handlers = [stderr] 146 logger.addHandler(stderr)
147 else: 147 else:
148 logger.handlers = [stdout] 148 logger.addHandler(stdout)
149 logger.handle(event) 149 logger.handle(event)
150 msgprint = True 150 msgprint = True
151 if msgprint: 151 if msgprint:
152 return 152 return
153 153
154 # Nope, so just print all of the messages we have (including debug messages) 154 # Nope, so just print all of the messages we have (including debug messages)
155 logger.handlers = [stdout] 155 logger.addHandler(stdout)
156 for event in ui_queue: 156 for event in ui_queue:
157 if isinstance(event, logging.LogRecord): 157 if isinstance(event, logging.LogRecord):
158 logger.handle(event) 158 logger.handle(event)