summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2015-06-25 17:53:23 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2015-06-26 09:27:33 +0100
commit00ca43be056e32bcc237ea4ada78f8df5faaf568 (patch)
treec0fbe460cb46cbe2c3d1cae178c87760a1e5b6c8
parentd93bc4cf4843afa37d08d2fc4a229016047563c1 (diff)
downloadpoky-00ca43be056e32bcc237ea4ada78f8df5faaf568.tar.gz
bitbake: cooker: Fire BuildCompleted before finishing the command
Some handlers hook on BuildComplete so it avoids certain event races to finish the command after the BuildComplete event is sent out. This means the UI is available to handle events until the command completes. What appears to be a race on one of the sanity tests for event handlers triggered this change although the failure is hard to reproduce. [YOCTO #7921] (Bitbake rev: e42d7c47a06fbb5981e0313478c8e3656b99f4e7) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--bitbake/lib/bb/cooker.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py
index cf65ab2c96..f31bca6f34 100644
--- a/bitbake/lib/bb/cooker.py
+++ b/bitbake/lib/bb/cooker.py
@@ -1303,8 +1303,8 @@ class BBCooker:
1303 return False 1303 return False
1304 1304
1305 if not retval: 1305 if not retval:
1306 self.command.finishAsyncCommand(msg)
1307 bb.event.fire(bb.event.BuildCompleted(len(rq.rqdata.runq_fnid), buildname, item, failures), self.expanded_data) 1306 bb.event.fire(bb.event.BuildCompleted(len(rq.rqdata.runq_fnid), buildname, item, failures), self.expanded_data)
1307 self.command.finishAsyncCommand(msg)
1308 return False 1308 return False
1309 if retval is True: 1309 if retval is True:
1310 return True 1310 return True
@@ -1336,8 +1336,8 @@ class BBCooker:
1336 return False 1336 return False
1337 1337
1338 if not retval: 1338 if not retval:
1339 self.command.finishAsyncCommand(msg)
1340 bb.event.fire(bb.event.BuildCompleted(len(rq.rqdata.runq_fnid), buildname, targets, failures), self.data) 1339 bb.event.fire(bb.event.BuildCompleted(len(rq.rqdata.runq_fnid), buildname, targets, failures), self.data)
1340 self.command.finishAsyncCommand(msg)
1341 return False 1341 return False
1342 if retval is True: 1342 if retval is True:
1343 return True 1343 return True