diff options
Diffstat (limited to 'meta-networking')
| -rw-r--r-- | meta-networking/recipes-support/mtr/mtr/0001-Fix-a-lot-of-Werror-format-security-errors-in-printw.patch | 68 | ||||
| -rw-r--r-- | meta-networking/recipes-support/mtr/mtr_0.95.bb (renamed from meta-networking/recipes-support/mtr/mtr_0.94.bb) | 6 |
2 files changed, 2 insertions, 72 deletions
diff --git a/meta-networking/recipes-support/mtr/mtr/0001-Fix-a-lot-of-Werror-format-security-errors-in-printw.patch b/meta-networking/recipes-support/mtr/mtr/0001-Fix-a-lot-of-Werror-format-security-errors-in-printw.patch deleted file mode 100644 index 5a8ee49d53..0000000000 --- a/meta-networking/recipes-support/mtr/mtr/0001-Fix-a-lot-of-Werror-format-security-errors-in-printw.patch +++ /dev/null | |||
| @@ -1,68 +0,0 @@ | |||
| 1 | From 628b4b3a16c5e3416aac3eea041ff03375fb495b Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Khem Raj <raj.khem@gmail.com> | ||
| 3 | Date: Sat, 30 Oct 2021 11:00:59 -0700 | ||
| 4 | Subject: [PATCH] Fix a lot of -Werror=format-security errors in | ||
| 5 | printw/mvprintw | ||
| 6 | |||
| 7 | In all these places a non-constant is used as a format string which | ||
| 8 | compiler complains about. Fix by using "%s" as format. | ||
| 9 | |||
| 10 | Upstream-Status: Pending | ||
| 11 | |||
| 12 | Signed-off-by: Khem Raj <raj.khem@gmail.com> | ||
| 13 | --- | ||
| 14 | ui/curses.c | 10 +++++----- | ||
| 15 | 1 file changed, 5 insertions(+), 5 deletions(-) | ||
| 16 | |||
| 17 | diff --git a/ui/curses.c b/ui/curses.c | ||
| 18 | index 34bf30d..c24cf28 100644 | ||
| 19 | --- a/ui/curses.c | ||
| 20 | +++ b/ui/curses.c | ||
| 21 | @@ -432,7 +432,7 @@ static void mtr_curses_hosts( | ||
| 22 | attron(A_BOLD); | ||
| 23 | #ifdef HAVE_IPINFO | ||
| 24 | if (is_printii(ctl)) | ||
| 25 | - printw(fmt_ipinfo(ctl, addr)); | ||
| 26 | + printw("%s", fmt_ipinfo(ctl, addr)); | ||
| 27 | #endif | ||
| 28 | if (name != NULL) { | ||
| 29 | if (ctl->show_ips) | ||
| 30 | @@ -485,7 +485,7 @@ static void mtr_curses_hosts( | ||
| 31 | printw("\n "); | ||
| 32 | #ifdef HAVE_IPINFO | ||
| 33 | if (is_printii(ctl)) | ||
| 34 | - printw(fmt_ipinfo(ctl, addrs)); | ||
| 35 | + printw("%s", fmt_ipinfo(ctl, addrs)); | ||
| 36 | #endif | ||
| 37 | if (name != NULL) { | ||
| 38 | if (ctl->show_ips) | ||
| 39 | @@ -650,7 +650,7 @@ static void mtr_curses_graph( | ||
| 40 | |||
| 41 | #ifdef HAVE_IPINFO | ||
| 42 | if (is_printii(ctl)) | ||
| 43 | - printw(fmt_ipinfo(ctl, addr)); | ||
| 44 | + printw("%s", fmt_ipinfo(ctl, addr)); | ||
| 45 | #endif | ||
| 46 | name = dns_lookup(ctl, addr); | ||
| 47 | printw("%s", name ? name : strlongip(ctl, addr)); | ||
| 48 | @@ -700,7 +700,7 @@ void mtr_curses_redraw( | ||
| 49 | |||
| 50 | mvprintw(1, 0, "%s (%s) -> %s", ctl->LocalHostname, net_localaddr(), ctl->Hostname); | ||
| 51 | t = time(NULL); | ||
| 52 | - mvprintw(1, maxx - 25, iso_time(&t)); | ||
| 53 | + mvprintw(1, maxx - 25, "%s", iso_time(&t)); | ||
| 54 | printw("\n"); | ||
| 55 | |||
| 56 | printw("Keys: "); | ||
| 57 | @@ -760,7 +760,7 @@ void mtr_curses_redraw( | ||
| 58 | startstat = padding - 2; | ||
| 59 | |||
| 60 | snprintf(msg, sizeof(msg), " Last %3d pings", max_cols); | ||
| 61 | - mvprintw(rowstat - 1, startstat, msg); | ||
| 62 | + mvprintw(rowstat - 1, startstat, "%s", msg); | ||
| 63 | |||
| 64 | attroff(A_BOLD); | ||
| 65 | move(rowstat, 0); | ||
| 66 | -- | ||
| 67 | 2.33.1 | ||
| 68 | |||
diff --git a/meta-networking/recipes-support/mtr/mtr_0.94.bb b/meta-networking/recipes-support/mtr/mtr_0.95.bb index 460fd2e8b6..b5e2fae506 100644 --- a/meta-networking/recipes-support/mtr/mtr_0.94.bb +++ b/meta-networking/recipes-support/mtr/mtr_0.95.bb | |||
| @@ -8,10 +8,8 @@ LICENSE = "GPLv2" | |||
| 8 | LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \ | 8 | LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \ |
| 9 | file://ui/mtr.c;beginline=5;endline=16;md5=00a894a39d53726a27386534d1c4e468" | 9 | file://ui/mtr.c;beginline=5;endline=16;md5=00a894a39d53726a27386534d1c4e468" |
| 10 | 10 | ||
| 11 | SRCREV = "2c73cbf4094e4eed343ed11ae5bab2580f3122d1" | 11 | SRCREV = "852e5617fbf331cf292723702161f0ac9afe257c" |
| 12 | SRC_URI = "git://github.com/traviscross/mtr;branch=master;protocol=https \ | 12 | SRC_URI = "git://github.com/traviscross/mtr;branch=master;protocol=https" |
| 13 | file://0001-Fix-a-lot-of-Werror-format-security-errors-in-printw.patch \ | ||
| 14 | " | ||
| 15 | 13 | ||
| 16 | S = "${WORKDIR}/git" | 14 | S = "${WORKDIR}/git" |
| 17 | 15 | ||
