diff options
author | Khem Raj <raj.khem@gmail.com> | 2018-09-09 21:59:14 -0700 |
---|---|---|
committer | Khem Raj <raj.khem@gmail.com> | 2018-09-09 21:59:14 -0700 |
commit | 8705570331c3ac5af2e36bdb6f8db3c2bea1f5b5 (patch) | |
tree | 9f584e1a43885fbded6393c169ae90d382436fb3 | |
parent | 7b6c088b87e4f22fbc8537276223dcae8284cf98 (diff) | |
download | meta-openembedded-8705570331c3ac5af2e36bdb6f8db3c2bea1f5b5.tar.gz |
evince: Fix build with clang
The added patch aids clang to avoid format warnings
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Andreas Müller <schnitzeltony@googlemail.com>
-rw-r--r-- | meta-gnome/recipes-gnome/evince/evince/0001-add-a-formatting-attribute-check.patch | 34 | ||||
-rw-r--r-- | meta-gnome/recipes-gnome/evince/evince_3.28.2.bb | 1 |
2 files changed, 35 insertions, 0 deletions
diff --git a/meta-gnome/recipes-gnome/evince/evince/0001-add-a-formatting-attribute-check.patch b/meta-gnome/recipes-gnome/evince/evince/0001-add-a-formatting-attribute-check.patch new file mode 100644 index 000000000..e87da90bc --- /dev/null +++ b/meta-gnome/recipes-gnome/evince/evince/0001-add-a-formatting-attribute-check.patch | |||
@@ -0,0 +1,34 @@ | |||
1 | From ef170dda7fbab53682c9bc287dec93fa86130bc9 Mon Sep 17 00:00:00 2001 | ||
2 | From: Khem Raj <raj.khem@gmail.com> | ||
3 | Date: Sun, 9 Sep 2018 21:49:59 -0700 | ||
4 | Subject: [PATCH] add a formatting attribute check | ||
5 | |||
6 | Tell Clang that parameter is a printf style format using the | ||
7 | attribute flag | ||
8 | |||
9 | This helps in avoiding below warnings seen with clang | ||
10 | |||
11 | unarr.c:106:22: error: format string is not a string literal | ||
12 | [-Werror,-Wformat-nonliteral] | ||
13 | | vfprintf(stderr, msg, args); | ||
14 | | ^~~ | ||
15 | |||
16 | Upstream-Status: Pending | ||
17 | Signed-off-by: Khem Raj <raj.khem@gmail.com> | ||
18 | --- | ||
19 | cut-n-paste/unarr/common/unarr.c | 2 +- | ||
20 | 1 file changed, 1 insertion(+), 1 deletion(-) | ||
21 | |||
22 | diff --git a/cut-n-paste/unarr/common/unarr.c b/cut-n-paste/unarr/common/unarr.c | ||
23 | index 97ec92a..9e6e3ad 100644 | ||
24 | --- a/cut-n-paste/unarr/common/unarr.c | ||
25 | +++ b/cut-n-paste/unarr/common/unarr.c | ||
26 | @@ -92,7 +92,7 @@ size_t ar_get_global_comment(ar_archive *ar, void *buffer, size_t count) | ||
27 | return ar->get_comment(ar, buffer, count); | ||
28 | } | ||
29 | |||
30 | -void ar_log(const char *prefix, const char *file, int line, const char *msg, ...) | ||
31 | +void __attribute__((__format__ (__printf__, 4, 0))) ar_log(const char *prefix, const char *file, int line, const char *msg, ...) | ||
32 | { | ||
33 | va_list args; | ||
34 | va_start(args, msg); | ||
diff --git a/meta-gnome/recipes-gnome/evince/evince_3.28.2.bb b/meta-gnome/recipes-gnome/evince/evince_3.28.2.bb index c5b548432..8bf8a04e2 100644 --- a/meta-gnome/recipes-gnome/evince/evince_3.28.2.bb +++ b/meta-gnome/recipes-gnome/evince/evince_3.28.2.bb | |||
@@ -11,6 +11,7 @@ REQUIRED_DISTRO_FEATURES = "x11" | |||
11 | SRC_URI = "${GNOME_MIRROR}/${GNOMEBN}/${@gnome_verdir("${PV}")}/${GNOMEBN}-${PV}.tar.${GNOME_COMPRESS_TYPE};name=archive \ | 11 | SRC_URI = "${GNOME_MIRROR}/${GNOMEBN}/${@gnome_verdir("${PV}")}/${GNOMEBN}-${PV}.tar.${GNOME_COMPRESS_TYPE};name=archive \ |
12 | file://0001-help-remove-YELP-macro.patch \ | 12 | file://0001-help-remove-YELP-macro.patch \ |
13 | file://0001-Add-format-attribute-to-_synctex_malloc.patch \ | 13 | file://0001-Add-format-attribute-to-_synctex_malloc.patch \ |
14 | file://0001-add-a-formatting-attribute-check.patch \ | ||
14 | " | 15 | " |
15 | SRC_URI[archive.md5sum] = "66aa1766eaaa37536e48def11a0e67a3" | 16 | SRC_URI[archive.md5sum] = "66aa1766eaaa37536e48def11a0e67a3" |
16 | SRC_URI[archive.sha256sum] = "0955d22d85c9f6d322b6cbb464f1cc4c352db619017ec95dad4cc5c3440f73e1" | 17 | SRC_URI[archive.sha256sum] = "0955d22d85c9f6d322b6cbb464f1cc4c352db619017ec95dad4cc5c3440f73e1" |