diff options
author | Alistair Francis <alistair.francis@wdc.com> | 2019-10-25 14:47:21 -0700 |
---|---|---|
committer | Khem Raj <raj.khem@gmail.com> | 2019-10-26 02:41:33 -0700 |
commit | 7f8b94f8a4b4a4b3d3dc4dfcee06a9c6828b5421 (patch) | |
tree | f5f6387853b777e2ae6ac38121a2279f1fe77086 | |
parent | b123e01e3ec7a750822829b59a98948b4c9c8ddb (diff) | |
download | meta-openembedded-7f8b94f8a4b4a4b3d3dc4dfcee06a9c6828b5421.tar.gz |
mycroft: Fixup remaining issues
This patch combines a few fixups:
- Don't bother users about missing package manager
- Use pocketsphinx by default (as it works on RISC-V)
- Add Upstream-Status to all patches
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
8 files changed, 78 insertions, 14 deletions
diff --git a/meta-multimedia/recipes-multimedia/mycroft/files/0001-Remove-python-venv.patch b/meta-multimedia/recipes-multimedia/mycroft/files/0001-Remove-python-venv.patch index 43994e0ca..245785c82 100644 --- a/meta-multimedia/recipes-multimedia/mycroft/files/0001-Remove-python-venv.patch +++ b/meta-multimedia/recipes-multimedia/mycroft/files/0001-Remove-python-venv.patch | |||
@@ -1,7 +1,7 @@ | |||
1 | From 07fce2101d83b5334de78e661ba0361c2874ebdf Mon Sep 17 00:00:00 2001 | 1 | From 07fce2101d83b5334de78e661ba0361c2874ebdf Mon Sep 17 00:00:00 2001 |
2 | From: Alistair Francis <alistair.francis@wdc.com> | 2 | From: Alistair Francis <alistair.francis@wdc.com> |
3 | Date: Mon, 18 Mar 2019 16:30:45 -0700 | 3 | Date: Mon, 18 Mar 2019 16:30:45 -0700 |
4 | Subject: [PATCH 1/5] Remove python venv | 4 | Subject: [PATCH 1/7] Remove python venv |
5 | 5 | ||
6 | Remove the python venv requirements and instead just use the native | 6 | Remove the python venv requirements and instead just use the native |
7 | python and pip pacakges. | 7 | python and pip pacakges. |
diff --git a/meta-multimedia/recipes-multimedia/mycroft/files/0002-dev_setup.sh-Remove-the-git-dependency.patch b/meta-multimedia/recipes-multimedia/mycroft/files/0002-dev_setup.sh-Remove-the-git-dependency.patch index dd2431fdf..637854fdf 100644 --- a/meta-multimedia/recipes-multimedia/mycroft/files/0002-dev_setup.sh-Remove-the-git-dependency.patch +++ b/meta-multimedia/recipes-multimedia/mycroft/files/0002-dev_setup.sh-Remove-the-git-dependency.patch | |||
@@ -1,7 +1,7 @@ | |||
1 | From 88696037af52d6a7f57bc0fb82598de1a25365cc Mon Sep 17 00:00:00 2001 | 1 | From 88696037af52d6a7f57bc0fb82598de1a25365cc Mon Sep 17 00:00:00 2001 |
2 | From: Alistair Francis <alistair.francis@wdc.com> | 2 | From: Alistair Francis <alistair.francis@wdc.com> |
3 | Date: Fri, 29 Mar 2019 16:09:57 -0700 | 3 | Date: Fri, 29 Mar 2019 16:09:57 -0700 |
4 | Subject: [PATCH 2/5] dev_setup.sh: Remove the git dependency | 4 | Subject: [PATCH 2/7] dev_setup.sh: Remove the git dependency |
5 | 5 | ||
6 | Signed-off-by: Alistair Francis <alistair.francis@wdc.com> | 6 | Signed-off-by: Alistair Francis <alistair.francis@wdc.com> |
7 | Upstream-Status: Inappropriate [embedded specific] | 7 | Upstream-Status: Inappropriate [embedded specific] |
diff --git a/meta-multimedia/recipes-multimedia/mycroft/files/0003-dev_setup.sh-Remove-the-TERM-dependency.patch b/meta-multimedia/recipes-multimedia/mycroft/files/0003-dev_setup.sh-Remove-the-TERM-dependency.patch index a4290d1cd..d803f526d 100644 --- a/meta-multimedia/recipes-multimedia/mycroft/files/0003-dev_setup.sh-Remove-the-TERM-dependency.patch +++ b/meta-multimedia/recipes-multimedia/mycroft/files/0003-dev_setup.sh-Remove-the-TERM-dependency.patch | |||
@@ -1,9 +1,10 @@ | |||
1 | From 5ef52cdea278a1dff966a912549cb6708f2cb699 Mon Sep 17 00:00:00 2001 | 1 | From 5ef52cdea278a1dff966a912549cb6708f2cb699 Mon Sep 17 00:00:00 2001 |
2 | From: Alistair Francis <alistair.francis@wdc.com> | 2 | From: Alistair Francis <alistair.francis@wdc.com> |
3 | Date: Tue, 17 Sep 2019 11:31:47 -0700 | 3 | Date: Tue, 17 Sep 2019 11:31:47 -0700 |
4 | Subject: [PATCH 3/5] dev_setup.sh: Remove the TERM dependency | 4 | Subject: [PATCH 3/7] dev_setup.sh: Remove the TERM dependency |
5 | 5 | ||
6 | Signed-off-by: Alistair Francis <alistair.francis@wdc.com> | 6 | Signed-off-by: Alistair Francis <alistair.francis@wdc.com> |
7 | Upstream-Status: Inappropriate [embedded specific] | ||
7 | --- | 8 | --- |
8 | dev_setup.sh | 12 ------------ | 9 | dev_setup.sh | 12 ------------ |
9 | 1 file changed, 12 deletions(-) | 10 | 1 file changed, 12 deletions(-) |
diff --git a/meta-multimedia/recipes-multimedia/mycroft/files/0004-dev_setup.sh-Ignore-missing-package-manager.patch b/meta-multimedia/recipes-multimedia/mycroft/files/0004-dev_setup.sh-Ignore-missing-package-manager.patch new file mode 100644 index 000000000..d2dc179ca --- /dev/null +++ b/meta-multimedia/recipes-multimedia/mycroft/files/0004-dev_setup.sh-Ignore-missing-package-manager.patch | |||
@@ -0,0 +1,31 @@ | |||
1 | From e3b6ca995caca22e65d012a54bc2aeb08eb7e9d4 Mon Sep 17 00:00:00 2001 | ||
2 | From: Alistair Francis <alistair.francis@wdc.com> | ||
3 | Date: Tue, 15 Oct 2019 17:09:06 -0700 | ||
4 | Subject: [PATCH 4/7] dev_setup.sh: Ignore missing package manager | ||
5 | |||
6 | Signed-off-by: Alistair Francis <alistair.francis@wdc.com> | ||
7 | Upstream-Status: Inappropriate [embedded specific] | ||
8 | --- | ||
9 | dev_setup.sh | 6 ------ | ||
10 | 1 file changed, 6 deletions(-) | ||
11 | |||
12 | diff --git a/dev_setup.sh b/dev_setup.sh | ||
13 | index 72f734f36bf..0c8e11b8170 100755 | ||
14 | --- a/dev_setup.sh | ||
15 | +++ b/dev_setup.sh | ||
16 | @@ -317,12 +317,6 @@ Please review the following package changes carefully." | ||
17 | echo -e "${YELLOW}Could not find package manager | ||
18 | ${YELLOW}Make sure to manually install:$BLUE git python3 python-setuptools python-venv pygobject libtool libffi libjpg openssl autoconf bison swig glib2.0 portaudio19 mpg123 flac curl fann g++ jq\n$RESET" | ||
19 | |||
20 | - echo 'Warning: Failed to install all dependencies. Continue? y/N' | ||
21 | - read -n1 continue | ||
22 | - if [[ $continue != 'y' ]] ; then | ||
23 | - exit 1 | ||
24 | - fi | ||
25 | - | ||
26 | fi | ||
27 | } | ||
28 | |||
29 | -- | ||
30 | 2.23.0 | ||
31 | |||
diff --git a/meta-multimedia/recipes-multimedia/mycroft/files/0004-pip-requirements-Don-t-install-requirements-with-pip.patch b/meta-multimedia/recipes-multimedia/mycroft/files/0005-pip-requirements-Don-t-install-requirements-with-pip.patch index 3063e7f8d..7f63ea13d 100644 --- a/meta-multimedia/recipes-multimedia/mycroft/files/0004-pip-requirements-Don-t-install-requirements-with-pip.patch +++ b/meta-multimedia/recipes-multimedia/mycroft/files/0005-pip-requirements-Don-t-install-requirements-with-pip.patch | |||
@@ -1,7 +1,7 @@ | |||
1 | From ac749f2512e8d121e8a64a8d5e6f226f16735dda Mon Sep 17 00:00:00 2001 | 1 | From 04b14c4569309f1a433d955773aeb8a3607a1360 Mon Sep 17 00:00:00 2001 |
2 | From: Alistair Francis <alistair.francis@wdc.com> | 2 | From: Alistair Francis <alistair.francis@wdc.com> |
3 | Date: Tue, 19 Mar 2019 13:32:54 -0700 | 3 | Date: Tue, 19 Mar 2019 13:32:54 -0700 |
4 | Subject: [PATCH 4/5] pip requirements: Don't install requirements with pip | 4 | Subject: [PATCH 5/7] pip requirements: Don't install requirements with pip |
5 | 5 | ||
6 | Signed-off-by: Alistair Francis <alistair.francis@wdc.com> | 6 | Signed-off-by: Alistair Francis <alistair.francis@wdc.com> |
7 | Upstream-Status: Inappropriate [embedded specific] | 7 | Upstream-Status: Inappropriate [embedded specific] |
@@ -14,10 +14,10 @@ Upstream-Status: Inappropriate [embedded specific] | |||
14 | delete mode 100644 test-requirements.txt | 14 | delete mode 100644 test-requirements.txt |
15 | 15 | ||
16 | diff --git a/dev_setup.sh b/dev_setup.sh | 16 | diff --git a/dev_setup.sh b/dev_setup.sh |
17 | index 72f734f36bf..b5ca6851631 100755 | 17 | index 0c8e11b8170..be4a19de0c3 100755 |
18 | --- a/dev_setup.sh | 18 | --- a/dev_setup.sh |
19 | +++ b/dev_setup.sh | 19 | +++ b/dev_setup.sh |
20 | @@ -357,19 +357,6 @@ fi | 20 | @@ -351,19 +351,6 @@ fi |
21 | 21 | ||
22 | PYTHON=$(python -c "import sys;print('python{}.{}'.format(sys.version_info[0], sys.version_info[1]))") | 22 | PYTHON=$(python -c "import sys;print('python{}.{}'.format(sys.version_info[0], sys.version_info[1]))") |
23 | 23 | ||
@@ -37,7 +37,7 @@ index 72f734f36bf..b5ca6851631 100755 | |||
37 | SYSMEM=$(free | awk '/^Mem:/ { print $2 }') | 37 | SYSMEM=$(free | awk '/^Mem:/ { print $2 }') |
38 | MAXCORES=$(($SYSMEM / 512000)) | 38 | MAXCORES=$(($SYSMEM / 512000)) |
39 | MINCORES=1 | 39 | MINCORES=1 |
40 | @@ -426,4 +413,4 @@ if [[ ! -w /var/log/mycroft/ ]] ; then | 40 | @@ -420,4 +407,4 @@ if [[ ! -w /var/log/mycroft/ ]] ; then |
41 | fi | 41 | fi |
42 | 42 | ||
43 | #Store a fingerprint of setup | 43 | #Store a fingerprint of setup |
diff --git a/meta-multimedia/recipes-multimedia/mycroft/files/0005-Use-python3-and-pip3-instead-of-python-and-pip.patch b/meta-multimedia/recipes-multimedia/mycroft/files/0006-Use-python3-and-pip3-instead-of-python-and-pip.patch index 189b686c9..6f1f6f78d 100644 --- a/meta-multimedia/recipes-multimedia/mycroft/files/0005-Use-python3-and-pip3-instead-of-python-and-pip.patch +++ b/meta-multimedia/recipes-multimedia/mycroft/files/0006-Use-python3-and-pip3-instead-of-python-and-pip.patch | |||
@@ -1,7 +1,7 @@ | |||
1 | From 9a0bd09706da3949db17ea7272d6647a487bb6ad Mon Sep 17 00:00:00 2001 | 1 | From 86a1d18d96f827baa0c1029c85a53fc89d436e17 Mon Sep 17 00:00:00 2001 |
2 | From: Alistair Francis <alistair.francis@wdc.com> | 2 | From: Alistair Francis <alistair.francis@wdc.com> |
3 | Date: Tue, 19 Mar 2019 13:38:44 -0700 | 3 | Date: Tue, 19 Mar 2019 13:38:44 -0700 |
4 | Subject: [PATCH 5/5] Use python3 and pip3 instead of python and pip | 4 | Subject: [PATCH 6/7] Use python3 and pip3 instead of python and pip |
5 | 5 | ||
6 | Signed-off-by: Alistair Francis <alistair.francis@wdc.com> | 6 | Signed-off-by: Alistair Francis <alistair.francis@wdc.com> |
7 | Upstream-Status: Inappropriate [embedded specific] | 7 | Upstream-Status: Inappropriate [embedded specific] |
@@ -73,7 +73,7 @@ index d80f0e75b13..9448ea3400f 100755 | |||
73 | -output=$(python -m mycroft.messagebus.send "speak" "{\"utterance\": \"$data\"}") | 73 | -output=$(python -m mycroft.messagebus.send "speak" "{\"utterance\": \"$data\"}") |
74 | +output=$(python3 -m mycroft.messagebus.send "speak" "{\"utterance\": \"$data\"}") | 74 | +output=$(python3 -m mycroft.messagebus.send "speak" "{\"utterance\": \"$data\"}") |
75 | diff --git a/dev_setup.sh b/dev_setup.sh | 75 | diff --git a/dev_setup.sh b/dev_setup.sh |
76 | index b5ca6851631..fcd0834669f 100755 | 76 | index be4a19de0c3..2d9e17ddfd6 100755 |
77 | --- a/dev_setup.sh | 77 | --- a/dev_setup.sh |
78 | +++ b/dev_setup.sh | 78 | +++ b/dev_setup.sh |
79 | @@ -48,7 +48,7 @@ param='' | 79 | @@ -48,7 +48,7 @@ param='' |
@@ -94,7 +94,7 @@ index b5ca6851631..fcd0834669f 100755 | |||
94 | fi | 94 | fi |
95 | done | 95 | done |
96 | 96 | ||
97 | @@ -355,7 +355,7 @@ else | 97 | @@ -349,7 +349,7 @@ else |
98 | fi | 98 | fi |
99 | fi | 99 | fi |
100 | 100 | ||
diff --git a/meta-multimedia/recipes-multimedia/mycroft/files/0007-mycroft.conf-Use-pocketsphinx-by-default.patch b/meta-multimedia/recipes-multimedia/mycroft/files/0007-mycroft.conf-Use-pocketsphinx-by-default.patch new file mode 100644 index 000000000..574bda144 --- /dev/null +++ b/meta-multimedia/recipes-multimedia/mycroft/files/0007-mycroft.conf-Use-pocketsphinx-by-default.patch | |||
@@ -0,0 +1,30 @@ | |||
1 | From b48b3d240cb0fa5e76aa5daf578e51bb8126431d Mon Sep 17 00:00:00 2001 | ||
2 | From: Alistair Francis <alistair.francis@wdc.com> | ||
3 | Date: Wed, 16 Oct 2019 09:18:39 -0700 | ||
4 | Subject: [PATCH 7/7] mycroft.conf: Use pocketsphinx by default | ||
5 | |||
6 | precise only works on certain architectures, to make Mycroft more | ||
7 | versitle use pocketsphinx as it is architecture independent. | ||
8 | |||
9 | Signed-off-by: Alistair Francis <alistair.francis@wdc.com> | ||
10 | Upstream-Status: Inappropriate [embedded specific] | ||
11 | --- | ||
12 | mycroft/configuration/mycroft.conf | 2 +- | ||
13 | 1 file changed, 1 insertion(+), 1 deletion(-) | ||
14 | |||
15 | diff --git a/mycroft/configuration/mycroft.conf b/mycroft/configuration/mycroft.conf | ||
16 | index 1d0be0dcd2b..d2dc75dac44 100644 | ||
17 | --- a/mycroft/configuration/mycroft.conf | ||
18 | +++ b/mycroft/configuration/mycroft.conf | ||
19 | @@ -196,7 +196,7 @@ | ||
20 | // Hotword configurations | ||
21 | "hotwords": { | ||
22 | "hey mycroft": { | ||
23 | - "module": "precise", | ||
24 | + "module": "pocketsphinx", | ||
25 | "phonemes": "HH EY . M AY K R AO F T", | ||
26 | "threshold": 1e-90, | ||
27 | "lang": "en-us" | ||
28 | -- | ||
29 | 2.23.0 | ||
30 | |||
diff --git a/meta-multimedia/recipes-multimedia/mycroft/mycroft_19.8.1.bb b/meta-multimedia/recipes-multimedia/mycroft/mycroft_19.8.1.bb index d4ac4096b..3c7bd8963 100644 --- a/meta-multimedia/recipes-multimedia/mycroft/mycroft_19.8.1.bb +++ b/meta-multimedia/recipes-multimedia/mycroft/mycroft_19.8.1.bb | |||
@@ -11,8 +11,10 @@ SRC_URI = "git://github.com/MycroftAI/mycroft-core.git;branch=master \ | |||
11 | file://0001-Remove-python-venv.patch \ | 11 | file://0001-Remove-python-venv.patch \ |
12 | file://0002-dev_setup.sh-Remove-the-git-dependency.patch \ | 12 | file://0002-dev_setup.sh-Remove-the-git-dependency.patch \ |
13 | file://0003-dev_setup.sh-Remove-the-TERM-dependency.patch \ | 13 | file://0003-dev_setup.sh-Remove-the-TERM-dependency.patch \ |
14 | file://0004-pip-requirements-Don-t-install-requirements-with-pip.patch \ | 14 | file://0004-dev_setup.sh-Ignore-missing-package-manager.patch \ |
15 | file://0005-Use-python3-and-pip3-instead-of-python-and-pip.patch \ | 15 | file://0005-pip-requirements-Don-t-install-requirements-with-pip.patch \ |
16 | file://0006-Use-python3-and-pip3-instead-of-python-and-pip.patch \ | ||
17 | file://0007-mycroft.conf-Use-pocketsphinx-by-default.patch \ | ||
16 | file://dev_opts.json \ | 18 | file://dev_opts.json \ |
17 | file://mycroft-setup.service \ | 19 | file://mycroft-setup.service \ |
18 | file://mycroft.service \ | 20 | file://mycroft.service \ |