summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMing Liu <liu.ming50@gmail.com>2023-08-14 10:41:03 +0200
committerKhem Raj <raj.khem@gmail.com>2023-08-14 08:14:46 -0700
commite84dbcc3816661b602d5c324fa5a7d93ebe326f6 (patch)
treed07ef08a41d9d3cb218814490ccc68c7eb5a1ba7
parente89194c3aac90790544128c2ac428c73cbe5c8b5 (diff)
downloadmeta-openembedded-e84dbcc3816661b602d5c324fa5a7d93ebe326f6.tar.gz
libusbgx: usbgx.service: use Type=oneshot
A regression was introduced by commit: ``` commit 48bc4b2d5e4688bac10bcca26657a5fe660b93ab Author: Ming Liu <liu.ming50@gmail.com> Date: Tue May 9 13:36:20 2023 +0200 libusbgx: fix some systemd service conditions Let usbgx.service require and run after sys-kernel-config.mount. Use "Type=simple" rather than "Type=oneshot", this ensures usbgx.service would not hang on failures, failures could happen in many conditions, like if the end user has manually configured something in configfs, or start usbgx.service twice, or someting wrong in /etc/default/usbgx or /etc/usbgx/*.schema. Signed-off-by: Ming Liu <liu.ming50@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> ``` In the case when 'Type=simple' is set, 'ExecStartPost=' will execute right after the process in 'ExecStart=' is started, but we need it execute after the last 'ExecStart=' process exited successfully, so change back to "Type=oneshot". Signed-off-by: Ming Liu <liu.ming50@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
-rw-r--r--meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service b/meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service
index ba92f1ab8..d7d394cfe 100644
--- a/meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service
+++ b/meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service
@@ -4,7 +4,7 @@ Requires=sys-kernel-config.mount
4After=sys-kernel-config.mount 4After=sys-kernel-config.mount
5 5
6[Service] 6[Service]
7Type=simple 7Type=oneshot
8ExecStart=/usr/bin/gadget-start 8ExecStart=/usr/bin/gadget-start
9 9
10[Install] 10[Install]