From e84dbcc3816661b602d5c324fa5a7d93ebe326f6 Mon Sep 17 00:00:00 2001 From: Ming Liu Date: Mon, 14 Aug 2023 10:41:03 +0200 Subject: libusbgx: usbgx.service: use Type=oneshot A regression was introduced by commit: ``` commit 48bc4b2d5e4688bac10bcca26657a5fe660b93ab Author: Ming Liu Date: Tue May 9 13:36:20 2023 +0200 libusbgx: fix some systemd service conditions Let usbgx.service require and run after sys-kernel-config.mount. Use "Type=simple" rather than "Type=oneshot", this ensures usbgx.service would not hang on failures, failures could happen in many conditions, like if the end user has manually configured something in configfs, or start usbgx.service twice, or someting wrong in /etc/default/usbgx or /etc/usbgx/*.schema. Signed-off-by: Ming Liu Signed-off-by: Khem Raj ``` In the case when 'Type=simple' is set, 'ExecStartPost=' will execute right after the process in 'ExecStart=' is started, but we need it execute after the last 'ExecStart=' process exited successfully, so change back to "Type=oneshot". Signed-off-by: Ming Liu Signed-off-by: Khem Raj --- meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service b/meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service index ba92f1ab8..d7d394cfe 100644 --- a/meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service +++ b/meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service @@ -4,7 +4,7 @@ Requires=sys-kernel-config.mount After=sys-kernel-config.mount [Service] -Type=simple +Type=oneshot ExecStart=/usr/bin/gadget-start [Install] -- cgit v1.2.3-54-g00ecf