summaryrefslogtreecommitdiffstats
path: root/recipes-devtools/qemu/qemu/0002-CVE-2017-2620.patch
diff options
context:
space:
mode:
Diffstat (limited to 'recipes-devtools/qemu/qemu/0002-CVE-2017-2620.patch')
-rw-r--r--recipes-devtools/qemu/qemu/0002-CVE-2017-2620.patch55
1 files changed, 55 insertions, 0 deletions
diff --git a/recipes-devtools/qemu/qemu/0002-CVE-2017-2620.patch b/recipes-devtools/qemu/qemu/0002-CVE-2017-2620.patch
new file mode 100644
index 0000000..3910fb9
--- /dev/null
+++ b/recipes-devtools/qemu/qemu/0002-CVE-2017-2620.patch
@@ -0,0 +1,55 @@
1From fc8e94c3e5e74437c4e73a5582f17cfd4cae5ccf Mon Sep 17 00:00:00 2001
2From: Gerd Hoffmann <kraxel@redhat.com>
3Date: Wed, 8 Feb 2017 11:18:36 +0100
4Subject: [PATCH] cirrus: add blit_is_unsafe call to cirrus_bitblt_cputovideo
5 (CVE-2017-2620)
6
7CIRRUS_BLTMODE_MEMSYSSRC blits do NOT check blit destination
8and blit width, at all. Oops. Fix it.
9
10Security impact: high.
11
12The missing blit destination check allows to write to host memory.
13Basically same as CVE-2014-8106 for the other blit variants.
14
15CVE: CVE-2017-2620
16Upstream-Status: Backport
17
18Cc: qemu-stable@nongnu.org
19Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
20(cherry picked from commit 92f2b88cea48c6aeba8de568a45f2ed958f3c298)
21Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
22Signed-off-by: Sona Sarmadi <sona.sarmadi@enea.com>
23---
24 hw/display/cirrus_vga.c | 8 ++++++++
25 1 file changed, 8 insertions(+)
26
27diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
28index 629a5c8..6766349 100644
29--- a/hw/display/cirrus_vga.c
30+++ b/hw/display/cirrus_vga.c
31@@ -873,6 +873,10 @@ static int cirrus_bitblt_cputovideo(CirrusVGAState * s)
32 {
33 int w;
34
35+ if (blit_is_unsafe(s, true)) {
36+ return 0;
37+ }
38+
39 s->cirrus_blt_mode &= ~CIRRUS_BLTMODE_MEMSYSSRC;
40 s->cirrus_srcptr = &s->cirrus_bltbuf[0];
41 s->cirrus_srcptr_end = &s->cirrus_bltbuf[0];
42@@ -898,6 +902,10 @@ static int cirrus_bitblt_cputovideo(CirrusVGAState * s)
43 }
44 s->cirrus_srccounter = s->cirrus_blt_srcpitch * s->cirrus_blt_height;
45 }
46+
47+ /* the blit_is_unsafe call above should catch this */
48+ assert(s->cirrus_blt_srcpitch <= CIRRUS_BLTBUFSIZE);
49+
50 s->cirrus_srcptr = s->cirrus_bltbuf;
51 s->cirrus_srcptr_end = s->cirrus_bltbuf + s->cirrus_blt_srcpitch;
52 cirrus_update_memory_access(s);
53--
541.9.1
55