diff options
Diffstat (limited to 'recipes-security/optee-imx/optee-os')
-rw-r--r-- | recipes-security/optee-imx/optee-os/0001-core-Define-section-attributes-for-clang.patch | 245 | ||||
-rw-r--r-- | recipes-security/optee-imx/optee-os/0003-arm32-libutils-libutee-ta-add-.note.GNU-stack-sectio.patch | 133 | ||||
-rw-r--r-- | recipes-security/optee-imx/optee-os/0004-core-link-add-no-warn-rwx-segments.patch | 67 | ||||
-rw-r--r-- | recipes-security/optee-imx/optee-os/0007-allow-setting-sysroot-for-clang.patch (renamed from recipes-security/optee-imx/optee-os/0002-optee-enable-clang-support.patch) | 14 |
4 files changed, 5 insertions, 454 deletions
diff --git a/recipes-security/optee-imx/optee-os/0001-core-Define-section-attributes-for-clang.patch b/recipes-security/optee-imx/optee-os/0001-core-Define-section-attributes-for-clang.patch deleted file mode 100644 index 54fbe5419..000000000 --- a/recipes-security/optee-imx/optee-os/0001-core-Define-section-attributes-for-clang.patch +++ /dev/null | |||
@@ -1,245 +0,0 @@ | |||
1 | From ef83625c9a5f50610e25aa860c4b9c5e64723a66 Mon Sep 17 00:00:00 2001 | ||
2 | From: Emekcan Aras <emekcan.aras@arm.com> | ||
3 | Date: Wed, 21 Dec 2022 10:55:58 +0000 | ||
4 | Subject: [PATCH 1/4] core: Define section attributes for clang | ||
5 | |||
6 | Clang's attribute section is not same as gcc, here we need to add flags | ||
7 | to sections so they can be eventually collected by linker into final | ||
8 | output segments. Only way to do so with clang is to use | ||
9 | |||
10 | pragma clang section ... | ||
11 | |||
12 | The behavious is described here [1], this allows us to define names bss | ||
13 | sections. This was not an issue until clang-15 where LLD linker starts | ||
14 | to detect the section flags before merging them and throws the following | ||
15 | errors | ||
16 | |||
17 | | ld.lld: error: section type mismatch for .nozi.kdata_page | ||
18 | | >>> /mnt/b/yoe/master/build/tmp/work/qemuarm64-yoe-linux/optee-os-tadevkit/3.17.0-r0/build/core/arch/arm/kernel/thread.o:(.nozi.kdata_page): SHT_PROGBITS | ||
19 | | >>> output section .nozi: SHT_NOBITS | ||
20 | | | ||
21 | | ld.lld: error: section type mismatch for .nozi.mmu.l2 | ||
22 | | >>> /mnt/b/yoe/master/build/tmp/work/qemuarm64-yoe-linux/optee-os-tadevkit/3.17.0-r0/build/core/arch/arm/mm/core_mmu_lpae.o:(.nozi.mmu.l2): SHT_PROGBITS | ||
23 | | >>> output section .nozi: SHT_NOBITS | ||
24 | |||
25 | These sections should be carrying SHT_NOBITS but so far it was not | ||
26 | possible to do so, this patch tries to use clangs pragma to get this | ||
27 | going and match the functionality with gcc. | ||
28 | |||
29 | [1] https://intel.github.io/llvm-docs/clang/LanguageExtensions.html#specifying-section-names-for-global-objects-pragma-clang-section | ||
30 | |||
31 | Upstream-Status: Pending | ||
32 | Signed-off-by: Khem Raj <raj.khem@gmail.com> | ||
33 | Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io> | ||
34 | --- | ||
35 | |||
36 | core/arch/arm/kernel/thread.c | 19 +++++++++++++++-- | ||
37 | core/arch/arm/mm/core_mmu_lpae.c | 35 +++++++++++++++++++++++++++---- | ||
38 | core/arch/arm/mm/core_mmu_v7.c | 36 +++++++++++++++++++++++++++++--- | ||
39 | core/kernel/thread.c | 13 +++++++++++- | ||
40 | core/mm/pgt_cache.c | 12 ++++++++++- | ||
41 | 5 files changed, 104 insertions(+), 11 deletions(-) | ||
42 | |||
43 | diff --git a/core/arch/arm/kernel/thread.c b/core/arch/arm/kernel/thread.c | ||
44 | index 66833b3a0..b3eb9cf9a 100644 | ||
45 | --- a/core/arch/arm/kernel/thread.c | ||
46 | +++ b/core/arch/arm/kernel/thread.c | ||
47 | @@ -45,15 +45,30 @@ static size_t thread_user_kcode_size __nex_bss; | ||
48 | #if defined(CFG_CORE_UNMAP_CORE_AT_EL0) && \ | ||
49 | defined(CFG_CORE_WORKAROUND_SPECTRE_BP_SEC) && defined(ARM64) | ||
50 | long thread_user_kdata_sp_offset __nex_bss; | ||
51 | +#ifdef __clang__ | ||
52 | +#ifndef CFG_VIRTUALIZATION | ||
53 | +#pragma clang section bss=".nozi.kdata_page" | ||
54 | +#else | ||
55 | +#pragma clang section bss=".nex_nozi.kdata_page" | ||
56 | +#endif | ||
57 | +#endif | ||
58 | static uint8_t thread_user_kdata_page[ | ||
59 | ROUNDUP(sizeof(struct thread_core_local) * CFG_TEE_CORE_NB_CORE, | ||
60 | SMALL_PAGE_SIZE)] | ||
61 | __aligned(SMALL_PAGE_SIZE) | ||
62 | +#ifndef __clang__ | ||
63 | #ifndef CFG_NS_VIRTUALIZATION | ||
64 | - __section(".nozi.kdata_page"); | ||
65 | + __section(".nozi.kdata_page") | ||
66 | #else | ||
67 | - __section(".nex_nozi.kdata_page"); | ||
68 | + __section(".nex_nozi.kdata_page") | ||
69 | #endif | ||
70 | +#endif | ||
71 | + ; | ||
72 | +#endif | ||
73 | + | ||
74 | +/* reset BSS section to default ( .bss ) */ | ||
75 | +#ifdef __clang__ | ||
76 | +#pragma clang section bss="" | ||
77 | #endif | ||
78 | |||
79 | #ifdef ARM32 | ||
80 | diff --git a/core/arch/arm/mm/core_mmu_lpae.c b/core/arch/arm/mm/core_mmu_lpae.c | ||
81 | index 4c8b85e39..1885e1d3f 100644 | ||
82 | --- a/core/arch/arm/mm/core_mmu_lpae.c | ||
83 | +++ b/core/arch/arm/mm/core_mmu_lpae.c | ||
84 | @@ -234,19 +234,46 @@ typedef uint16_t l1_idx_t; | ||
85 | typedef uint64_t base_xlat_tbls_t[CFG_TEE_CORE_NB_CORE][NUM_BASE_LEVEL_ENTRIES]; | ||
86 | typedef uint64_t xlat_tbl_t[XLAT_TABLE_ENTRIES]; | ||
87 | |||
88 | +#ifdef __clang__ | ||
89 | +#pragma clang section bss=".nozi.mmu.base_table" | ||
90 | +#endif | ||
91 | static base_xlat_tbls_t base_xlation_table[NUM_BASE_TABLES] | ||
92 | __aligned(NUM_BASE_LEVEL_ENTRIES * XLAT_ENTRY_SIZE) | ||
93 | - __section(".nozi.mmu.base_table"); | ||
94 | +#ifndef __clang__ | ||
95 | + __section(".nozi.mmu.base_table") | ||
96 | +#endif | ||
97 | +; | ||
98 | +#ifdef __clang__ | ||
99 | +#pragma clang section bss="" | ||
100 | +#endif | ||
101 | |||
102 | +#ifdef __clang__ | ||
103 | +#pragma clang section bss=".nozi.mmu.l2" | ||
104 | +#endif | ||
105 | static xlat_tbl_t xlat_tables[MAX_XLAT_TABLES] | ||
106 | - __aligned(XLAT_TABLE_SIZE) __section(".nozi.mmu.l2"); | ||
107 | + __aligned(XLAT_TABLE_SIZE) | ||
108 | +#ifndef __clang__ | ||
109 | + __section(".nozi.mmu.l2") | ||
110 | +#endif | ||
111 | +; | ||
112 | +#ifdef __clang__ | ||
113 | +#pragma clang section bss="" | ||
114 | +#endif | ||
115 | |||
116 | #define XLAT_TABLES_SIZE (sizeof(xlat_tbl_t) * MAX_XLAT_TABLES) | ||
117 | |||
118 | +#ifdef __clang__ | ||
119 | +#pragma clang section bss=".nozi.mmu.l2" | ||
120 | +#endif | ||
121 | /* MMU L2 table for TAs, one for each thread */ | ||
122 | static xlat_tbl_t xlat_tables_ul1[CFG_NUM_THREADS] | ||
123 | - __aligned(XLAT_TABLE_SIZE) __section(".nozi.mmu.l2"); | ||
124 | - | ||
125 | +#ifndef __clang__ | ||
126 | + __aligned(XLAT_TABLE_SIZE) __section(".nozi.mmu.l2") | ||
127 | +#endif | ||
128 | +; | ||
129 | +#ifdef __clang__ | ||
130 | +#pragma clang section bss="" | ||
131 | +#endif | ||
132 | /* | ||
133 | * TAs page table entry inside a level 1 page table. | ||
134 | * | ||
135 | diff --git a/core/arch/arm/mm/core_mmu_v7.c b/core/arch/arm/mm/core_mmu_v7.c | ||
136 | index 61e703da8..1960c08ca 100644 | ||
137 | --- a/core/arch/arm/mm/core_mmu_v7.c | ||
138 | +++ b/core/arch/arm/mm/core_mmu_v7.c | ||
139 | @@ -204,16 +204,46 @@ typedef uint32_t l1_xlat_tbl_t[NUM_L1_ENTRIES]; | ||
140 | typedef uint32_t l2_xlat_tbl_t[NUM_L2_ENTRIES]; | ||
141 | typedef uint32_t ul1_xlat_tbl_t[NUM_UL1_ENTRIES]; | ||
142 | |||
143 | +#ifdef __clang__ | ||
144 | +#pragma clang section bss=".nozi.mmu.l1" | ||
145 | +#endif | ||
146 | static l1_xlat_tbl_t main_mmu_l1_ttb | ||
147 | - __aligned(L1_ALIGNMENT) __section(".nozi.mmu.l1"); | ||
148 | + __aligned(L1_ALIGNMENT) | ||
149 | +#ifndef __clang__ | ||
150 | + __section(".nozi.mmu.l1") | ||
151 | +#endif | ||
152 | +; | ||
153 | +#ifdef __clang__ | ||
154 | +#pragma clang section bss="" | ||
155 | +#endif | ||
156 | |||
157 | /* L2 MMU tables */ | ||
158 | +#ifdef __clang__ | ||
159 | +#pragma clang section bss=".nozi.mmu.l2" | ||
160 | +#endif | ||
161 | static l2_xlat_tbl_t main_mmu_l2_ttb[MAX_XLAT_TABLES] | ||
162 | - __aligned(L2_ALIGNMENT) __section(".nozi.mmu.l2"); | ||
163 | + __aligned(L2_ALIGNMENT) | ||
164 | +#ifndef __clang__ | ||
165 | + __section(".nozi.mmu.l2") | ||
166 | +#endif | ||
167 | +; | ||
168 | +#ifdef __clang__ | ||
169 | +#pragma clang section bss="" | ||
170 | +#endif | ||
171 | |||
172 | /* MMU L1 table for TAs, one for each thread */ | ||
173 | +#ifdef __clang__ | ||
174 | +#pragma clang section bss=".nozi.mmu.ul1" | ||
175 | +#endif | ||
176 | static ul1_xlat_tbl_t main_mmu_ul1_ttb[CFG_NUM_THREADS] | ||
177 | - __aligned(UL1_ALIGNMENT) __section(".nozi.mmu.ul1"); | ||
178 | + __aligned(UL1_ALIGNMENT) | ||
179 | +#ifndef __clang__ | ||
180 | + __section(".nozi.mmu.ul1") | ||
181 | +#endif | ||
182 | +; | ||
183 | +#ifdef __clang__ | ||
184 | +#pragma clang section bss="" | ||
185 | +#endif | ||
186 | |||
187 | struct mmu_partition { | ||
188 | l1_xlat_tbl_t *l1_table; | ||
189 | diff --git a/core/kernel/thread.c b/core/kernel/thread.c | ||
190 | index 2a1f22dce..5516b6771 100644 | ||
191 | --- a/core/kernel/thread.c | ||
192 | +++ b/core/kernel/thread.c | ||
193 | @@ -39,13 +39,24 @@ static uint32_t end_canary_value = 0xababab00; | ||
194 | name[stack_num][sizeof(name[stack_num]) / sizeof(uint32_t) - 1] | ||
195 | #endif | ||
196 | |||
197 | +#define DO_PRAGMA(x) _Pragma (#x) | ||
198 | + | ||
199 | +#ifdef __clang__ | ||
200 | +#define DECLARE_STACK(name, num_stacks, stack_size, linkage) \ | ||
201 | +DO_PRAGMA (clang section bss=".nozi_stack." #name) \ | ||
202 | +linkage uint32_t name[num_stacks] \ | ||
203 | + [ROUNDUP(stack_size + STACK_CANARY_SIZE + STACK_CHECK_EXTRA, \ | ||
204 | + STACK_ALIGNMENT) / sizeof(uint32_t)] \ | ||
205 | + __attribute__((aligned(STACK_ALIGNMENT))); \ | ||
206 | +DO_PRAGMA(clang section bss="") | ||
207 | +#else | ||
208 | #define DECLARE_STACK(name, num_stacks, stack_size, linkage) \ | ||
209 | linkage uint32_t name[num_stacks] \ | ||
210 | [ROUNDUP(stack_size + STACK_CANARY_SIZE + STACK_CHECK_EXTRA, \ | ||
211 | STACK_ALIGNMENT) / sizeof(uint32_t)] \ | ||
212 | __attribute__((section(".nozi_stack." # name), \ | ||
213 | aligned(STACK_ALIGNMENT))) | ||
214 | - | ||
215 | +#endif | ||
216 | #define GET_STACK(stack) ((vaddr_t)(stack) + STACK_SIZE(stack)) | ||
217 | |||
218 | DECLARE_STACK(stack_tmp, CFG_TEE_CORE_NB_CORE, STACK_TMP_SIZE, | ||
219 | diff --git a/core/mm/pgt_cache.c b/core/mm/pgt_cache.c | ||
220 | index 79553c6d2..b9efdf427 100644 | ||
221 | --- a/core/mm/pgt_cache.c | ||
222 | +++ b/core/mm/pgt_cache.c | ||
223 | @@ -410,8 +410,18 @@ void pgt_init(void) | ||
224 | * has a large alignment, while .bss has a small alignment. The current | ||
225 | * link script is optimized for small alignment in .bss | ||
226 | */ | ||
227 | +#ifdef __clang__ | ||
228 | +#pragma clang section bss=".nozi.mmu.l2" | ||
229 | +#endif | ||
230 | static uint8_t pgt_tables[PGT_CACHE_SIZE][PGT_SIZE] | ||
231 | - __aligned(PGT_SIZE) __section(".nozi.pgt_cache"); | ||
232 | + __aligned(PGT_SIZE) | ||
233 | +#ifndef __clang__ | ||
234 | + __section(".nozi.pgt_cache") | ||
235 | +#endif | ||
236 | + ; | ||
237 | +#ifdef __clang__ | ||
238 | +#pragma clang section bss="" | ||
239 | +#endif | ||
240 | size_t n; | ||
241 | |||
242 | for (n = 0; n < ARRAY_SIZE(pgt_tables); n++) { | ||
243 | -- | ||
244 | 2.43.2 | ||
245 | |||
diff --git a/recipes-security/optee-imx/optee-os/0003-arm32-libutils-libutee-ta-add-.note.GNU-stack-sectio.patch b/recipes-security/optee-imx/optee-os/0003-arm32-libutils-libutee-ta-add-.note.GNU-stack-sectio.patch deleted file mode 100644 index 1c5753c7f..000000000 --- a/recipes-security/optee-imx/optee-os/0003-arm32-libutils-libutee-ta-add-.note.GNU-stack-sectio.patch +++ /dev/null | |||
@@ -1,133 +0,0 @@ | |||
1 | From 6f738803a59613ec4a683ddbc1747ebffd75a4e6 Mon Sep 17 00:00:00 2001 | ||
2 | From: Jerome Forissier <jerome.forissier@linaro.org> | ||
3 | Date: Tue, 23 Aug 2022 12:31:46 +0000 | ||
4 | Subject: [PATCH 3/4] arm32: libutils, libutee, ta: add .note.GNU-stack section | ||
5 | to | ||
6 | |||
7 | .S files | ||
8 | |||
9 | When building for arm32 with GNU binutils 2.39, the linker outputs | ||
10 | warnings when linking Trusted Applications: | ||
11 | |||
12 | arm-unknown-linux-uclibcgnueabihf-ld.bfd: warning: utee_syscalls_a32.o: missing .note.GNU-stack section implies executable stack | ||
13 | arm-unknown-linux-uclibcgnueabihf-ld.bfd: NOTE: This behaviour is deprecated and will be removed in a future version of the linker | ||
14 | |||
15 | We could silence the warning by adding the '-z execstack' option to the | ||
16 | TA link flags, like we did in the parent commit for the TEE core and | ||
17 | ldelf. Indeed, ldelf always allocates a non-executable piece of memory | ||
18 | for the TA to use as a stack. | ||
19 | |||
20 | However it seems preferable to comply with the common ELF practices in | ||
21 | this case. A better fix is therefore to add the missing .note.GNU-stack | ||
22 | sections in the assembler files. | ||
23 | |||
24 | Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> | ||
25 | |||
26 | Signed-off-by: Anton Antonov <Anton.Antonov@arm.com> | ||
27 | Upstream-Status: Backport [https://github.com/OP-TEE/optee_os/pull/5499] | ||
28 | Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io> | ||
29 | --- | ||
30 | |||
31 | lib/libutee/arch/arm/utee_syscalls_a32.S | 2 ++ | ||
32 | lib/libutils/ext/arch/arm/atomic_a32.S | 2 ++ | ||
33 | lib/libutils/ext/arch/arm/mcount_a32.S | 2 ++ | ||
34 | lib/libutils/isoc/arch/arm/arm32_aeabi_divmod_a32.S | 2 ++ | ||
35 | lib/libutils/isoc/arch/arm/arm32_aeabi_ldivmod_a32.S | 2 ++ | ||
36 | lib/libutils/isoc/arch/arm/setjmp_a32.S | 2 ++ | ||
37 | ta/arch/arm/ta_entry_a32.S | 2 ++ | ||
38 | 7 files changed, 14 insertions(+) | ||
39 | |||
40 | diff --git a/lib/libutee/arch/arm/utee_syscalls_a32.S b/lib/libutee/arch/arm/utee_syscalls_a32.S | ||
41 | index 2dea83ab8..668b65a86 100644 | ||
42 | --- a/lib/libutee/arch/arm/utee_syscalls_a32.S | ||
43 | +++ b/lib/libutee/arch/arm/utee_syscalls_a32.S | ||
44 | @@ -9,6 +9,8 @@ | ||
45 | |||
46 | .section .note.GNU-stack,"",%progbits | ||
47 | |||
48 | + .section .note.GNU-stack,"",%progbits | ||
49 | + | ||
50 | .section .text | ||
51 | .balign 4 | ||
52 | .code 32 | ||
53 | diff --git a/lib/libutils/ext/arch/arm/atomic_a32.S b/lib/libutils/ext/arch/arm/atomic_a32.S | ||
54 | index 2be73ffad..87ddf1065 100644 | ||
55 | --- a/lib/libutils/ext/arch/arm/atomic_a32.S | ||
56 | +++ b/lib/libutils/ext/arch/arm/atomic_a32.S | ||
57 | @@ -7,6 +7,8 @@ | ||
58 | |||
59 | .section .note.GNU-stack,"",%progbits | ||
60 | |||
61 | + .section .note.GNU-stack,"",%progbits | ||
62 | + | ||
63 | /* uint32_t atomic_inc32(uint32_t *v); */ | ||
64 | FUNC atomic_inc32 , : | ||
65 | ldrex r1, [r0] | ||
66 | diff --git a/lib/libutils/ext/arch/arm/mcount_a32.S b/lib/libutils/ext/arch/arm/mcount_a32.S | ||
67 | index 54dc3c02d..2f24632b8 100644 | ||
68 | --- a/lib/libutils/ext/arch/arm/mcount_a32.S | ||
69 | +++ b/lib/libutils/ext/arch/arm/mcount_a32.S | ||
70 | @@ -9,6 +9,8 @@ | ||
71 | |||
72 | .section .note.GNU-stack,"",%progbits | ||
73 | |||
74 | + .section .note.GNU-stack,"",%progbits | ||
75 | + | ||
76 | /* | ||
77 | * Convert return address to call site address by subtracting the size of the | ||
78 | * mcount call instruction (blx __gnu_mcount_nc). | ||
79 | diff --git a/lib/libutils/isoc/arch/arm/arm32_aeabi_divmod_a32.S b/lib/libutils/isoc/arch/arm/arm32_aeabi_divmod_a32.S | ||
80 | index 37ae9ec6f..bc6c48b1a 100644 | ||
81 | --- a/lib/libutils/isoc/arch/arm/arm32_aeabi_divmod_a32.S | ||
82 | +++ b/lib/libutils/isoc/arch/arm/arm32_aeabi_divmod_a32.S | ||
83 | @@ -7,6 +7,8 @@ | ||
84 | |||
85 | .section .note.GNU-stack,"",%progbits | ||
86 | |||
87 | + .section .note.GNU-stack,"",%progbits | ||
88 | + | ||
89 | /* | ||
90 | * signed ret_idivmod_values(signed quot, signed rem); | ||
91 | * return quotient and remaining the EABI way (regs r0,r1) | ||
92 | diff --git a/lib/libutils/isoc/arch/arm/arm32_aeabi_ldivmod_a32.S b/lib/libutils/isoc/arch/arm/arm32_aeabi_ldivmod_a32.S | ||
93 | index 5c3353e2c..9fb5e0283 100644 | ||
94 | --- a/lib/libutils/isoc/arch/arm/arm32_aeabi_ldivmod_a32.S | ||
95 | +++ b/lib/libutils/isoc/arch/arm/arm32_aeabi_ldivmod_a32.S | ||
96 | @@ -7,6 +7,8 @@ | ||
97 | |||
98 | .section .note.GNU-stack,"",%progbits | ||
99 | |||
100 | + .section .note.GNU-stack,"",%progbits | ||
101 | + | ||
102 | /* | ||
103 | * __value_in_regs lldiv_t __aeabi_ldivmod( long long n, long long d) | ||
104 | */ | ||
105 | diff --git a/lib/libutils/isoc/arch/arm/setjmp_a32.S b/lib/libutils/isoc/arch/arm/setjmp_a32.S | ||
106 | index f8a0b70df..37d7cb88e 100644 | ||
107 | --- a/lib/libutils/isoc/arch/arm/setjmp_a32.S | ||
108 | +++ b/lib/libutils/isoc/arch/arm/setjmp_a32.S | ||
109 | @@ -53,6 +53,8 @@ | ||
110 | |||
111 | .section .note.GNU-stack,"",%progbits | ||
112 | |||
113 | + .section .note.GNU-stack,"",%progbits | ||
114 | + | ||
115 | /* Arm/Thumb interworking support: | ||
116 | |||
117 | The interworking scheme expects functions to use a BX instruction | ||
118 | diff --git a/ta/arch/arm/ta_entry_a32.S b/ta/arch/arm/ta_entry_a32.S | ||
119 | index cd9a12f9d..ccdc19928 100644 | ||
120 | --- a/ta/arch/arm/ta_entry_a32.S | ||
121 | +++ b/ta/arch/arm/ta_entry_a32.S | ||
122 | @@ -7,6 +7,8 @@ | ||
123 | |||
124 | .section .note.GNU-stack,"",%progbits | ||
125 | |||
126 | + .section .note.GNU-stack,"",%progbits | ||
127 | + | ||
128 | /* | ||
129 | * This function is the bottom of the user call stack. Mark it as such so that | ||
130 | * the unwinding code won't try to go further down. | ||
131 | -- | ||
132 | 2.43.2 | ||
133 | |||
diff --git a/recipes-security/optee-imx/optee-os/0004-core-link-add-no-warn-rwx-segments.patch b/recipes-security/optee-imx/optee-os/0004-core-link-add-no-warn-rwx-segments.patch deleted file mode 100644 index f32b2284f..000000000 --- a/recipes-security/optee-imx/optee-os/0004-core-link-add-no-warn-rwx-segments.patch +++ /dev/null | |||
@@ -1,67 +0,0 @@ | |||
1 | From a63f82f74e015eb662242cdb51ef814e3f576829 Mon Sep 17 00:00:00 2001 | ||
2 | From: Jerome Forissier <jerome.forissier@linaro.org> | ||
3 | Date: Fri, 5 Aug 2022 09:48:03 +0200 | ||
4 | Subject: [PATCH 4/4] core: link: add --no-warn-rwx-segments | ||
5 | |||
6 | Signed-off-by: Anton Antonov <Anton.Antonov@arm.com> | ||
7 | Upstream-Status: Backport [https://github.com/OP-TEE/optee_os/pull/5474] | ||
8 | |||
9 | binutils ld.bfd generates one RWX LOAD segment by merging several sections | ||
10 | with mixed R/W/X attributes (.text, .rodata, .data). After version 2.38 it | ||
11 | also warns by default when that happens [1], which breaks the build due to | ||
12 | --fatal-warnings. The RWX segment is not a problem for the TEE core, since | ||
13 | that information is not used to set memory permissions. Therefore, silence | ||
14 | the warning. | ||
15 | |||
16 | Link: [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=ba951afb99912da01a6e8434126b8fac7aa75107 | ||
17 | Link: https://sourceware.org/bugzilla/show_bug.cgi?id=29448 | ||
18 | Reported-by: Dominique Martinet <dominique.martinet@atmark-techno.com> | ||
19 | Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> | ||
20 | Acked-by: Jens Wiklander <jens.wiklander@linaro.org> | ||
21 | Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io> | ||
22 | --- | ||
23 | |||
24 | core/arch/arm/kernel/link.mk | 6 ++++-- | ||
25 | 1 file changed, 4 insertions(+), 2 deletions(-) | ||
26 | |||
27 | diff --git a/core/arch/arm/kernel/link.mk b/core/arch/arm/kernel/link.mk | ||
28 | index 49e9f4fa1..9e1cc172f 100644 | ||
29 | --- a/core/arch/arm/kernel/link.mk | ||
30 | +++ b/core/arch/arm/kernel/link.mk | ||
31 | @@ -37,6 +37,7 @@ link-ldflags += --sort-section=alignment | ||
32 | link-ldflags += --fatal-warnings | ||
33 | link-ldflags += --gc-sections | ||
34 | link-ldflags += $(link-ldflags-common) | ||
35 | +link-ldflags += $(call ld-option,--no-warn-rwx-segments) | ||
36 | |||
37 | link-ldadd = $(LDADD) | ||
38 | link-ldadd += $(ldflags-external) | ||
39 | @@ -61,6 +62,7 @@ link-script-cppflags := \ | ||
40 | $(cppflagscore)) | ||
41 | |||
42 | ldargs-all_objs := -T $(link-script-dummy) --no-check-sections \ | ||
43 | + $(call ld-option,--no-warn-rwx-segments) \ | ||
44 | $(link-ldflags-common) \ | ||
45 | $(link-objs) $(link-ldadd) $(libgcccore) | ||
46 | cleanfiles += $(link-out-dir)/all_objs.o | ||
47 | @@ -75,7 +77,7 @@ $(link-out-dir)/unpaged_entries.txt: $(link-out-dir)/all_objs.o | ||
48 | $(AWK) '/ ____keep_pager/ { printf "-u%s ", $$3 }' > $@ | ||
49 | |||
50 | unpaged-ldargs := -T $(link-script-dummy) --no-check-sections --gc-sections \ | ||
51 | - $(link-ldflags-common) | ||
52 | + $(link-ldflags-common) $(call ld-option,--no-warn-rwx-segments) | ||
53 | unpaged-ldadd := $(objs) $(link-ldadd) $(libgcccore) | ||
54 | cleanfiles += $(link-out-dir)/unpaged.o | ||
55 | $(link-out-dir)/unpaged.o: $(link-out-dir)/unpaged_entries.txt | ||
56 | @@ -104,7 +106,7 @@ $(link-out-dir)/init_entries.txt: $(link-out-dir)/all_objs.o | ||
57 | $(AWK) '/ ____keep_init/ { printf "-u%s ", $$3 }' > $@ | ||
58 | |||
59 | init-ldargs := -T $(link-script-dummy) --no-check-sections --gc-sections \ | ||
60 | - $(link-ldflags-common) | ||
61 | + $(link-ldflags-common) $(call ld-option,--no-warn-rwx-segments) | ||
62 | init-ldadd := $(link-objs-init) $(link-out-dir)/version.o $(link-ldadd) \ | ||
63 | $(libgcccore) | ||
64 | cleanfiles += $(link-out-dir)/init.o | ||
65 | -- | ||
66 | 2.43.2 | ||
67 | |||
diff --git a/recipes-security/optee-imx/optee-os/0002-optee-enable-clang-support.patch b/recipes-security/optee-imx/optee-os/0007-allow-setting-sysroot-for-clang.patch index dbc53542e..067ba6ebf 100644 --- a/recipes-security/optee-imx/optee-os/0002-optee-enable-clang-support.patch +++ b/recipes-security/optee-imx/optee-os/0007-allow-setting-sysroot-for-clang.patch | |||
@@ -1,7 +1,7 @@ | |||
1 | From 2ba573c9763329fbfdfacc8393d565ab747cac4d Mon Sep 17 00:00:00 2001 | 1 | From db9e44af75c7cfd3316cab15aaa387383df3e57e Mon Sep 17 00:00:00 2001 |
2 | From: Brett Warren <brett.warren@arm.com> | 2 | From: Brett Warren <brett.warren@arm.com> |
3 | Date: Wed, 23 Sep 2020 09:27:34 +0100 | 3 | Date: Wed, 23 Sep 2020 09:27:34 +0100 |
4 | Subject: [PATCH 2/4] optee: enable clang support | 4 | Subject: [PATCH] optee: enable clang support |
5 | 5 | ||
6 | When compiling with clang, the LIBGCC_LOCATE_CFLAG variable used | 6 | When compiling with clang, the LIBGCC_LOCATE_CFLAG variable used |
7 | to provide a sysroot wasn't included, which results in not locating | 7 | to provide a sysroot wasn't included, which results in not locating |
@@ -10,17 +10,16 @@ compiler-rt. This is mitigated by including the variable as ammended. | |||
10 | Upstream-Status: Pending | 10 | Upstream-Status: Pending |
11 | ChangeId: 8ba69a4b2eb8ebaa047cb266c9aa6c2c3da45701 | 11 | ChangeId: 8ba69a4b2eb8ebaa047cb266c9aa6c2c3da45701 |
12 | Signed-off-by: Brett Warren <brett.warren@arm.com> | 12 | Signed-off-by: Brett Warren <brett.warren@arm.com> |
13 | Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io> | ||
14 | --- | ||
15 | 13 | ||
14 | --- | ||
16 | mk/clang.mk | 2 +- | 15 | mk/clang.mk | 2 +- |
17 | 1 file changed, 1 insertion(+), 1 deletion(-) | 16 | 1 file changed, 1 insertion(+), 1 deletion(-) |
18 | 17 | ||
19 | diff --git a/mk/clang.mk b/mk/clang.mk | 18 | diff --git a/mk/clang.mk b/mk/clang.mk |
20 | index a045beee8..1ebe2f702 100644 | 19 | index c141a3f2..7d067cc0 100644 |
21 | --- a/mk/clang.mk | 20 | --- a/mk/clang.mk |
22 | +++ b/mk/clang.mk | 21 | +++ b/mk/clang.mk |
23 | @@ -30,7 +30,7 @@ comp-cflags-warns-clang := -Wno-language-extension-token \ | 22 | @@ -27,7 +27,7 @@ comp-cflags-warns-clang := -Wno-language-extension-token \ |
24 | 23 | ||
25 | # Note, use the compiler runtime library (libclang_rt.builtins.*.a) instead of | 24 | # Note, use the compiler runtime library (libclang_rt.builtins.*.a) instead of |
26 | # libgcc for clang | 25 | # libgcc for clang |
@@ -29,6 +28,3 @@ index a045beee8..1ebe2f702 100644 | |||
29 | -rtlib=compiler-rt -print-libgcc-file-name 2> /dev/null) | 28 | -rtlib=compiler-rt -print-libgcc-file-name 2> /dev/null) |
30 | 29 | ||
31 | # Core ASLR relies on the executable being ready to run from its preferred load | 30 | # Core ASLR relies on the executable being ready to run from its preferred load |
32 | -- | ||
33 | 2.43.2 | ||
34 | |||