summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOtavio Salvador <otavio@ossystems.com.br>2024-04-11 17:50:34 -0300
committerGitHub <noreply@github.com>2024-04-11 17:50:34 -0300
commiteb50eb9f7c78ae1f82e7101d9f35af07a9ae802e (patch)
tree2eea9b8d98c5be146073fa31108e90dc2d53437e
parentfcd31cc413734931d3934a10086807808ca61e24 (diff)
parent08b3a8cefe9d1b5c112b256d5ddb94a9f9e1ac0e (diff)
downloadmeta-freescale-eb50eb9f7c78ae1f82e7101d9f35af07a9ae802e.tar.gz
Merge pull request #1784 from nxp-upstream/master
alsa-lib: Drop upstream patch
-rw-r--r--recipes-multimedia/alsa/alsa-lib/0001-pcm-Fix-segfault-with-32bit-libs.patch115
-rw-r--r--recipes-multimedia/alsa/alsa-lib_%.bbappend1
2 files changed, 0 insertions, 116 deletions
diff --git a/recipes-multimedia/alsa/alsa-lib/0001-pcm-Fix-segfault-with-32bit-libs.patch b/recipes-multimedia/alsa/alsa-lib/0001-pcm-Fix-segfault-with-32bit-libs.patch
deleted file mode 100644
index 6891c600..00000000
--- a/recipes-multimedia/alsa/alsa-lib/0001-pcm-Fix-segfault-with-32bit-libs.patch
+++ /dev/null
@@ -1,115 +0,0 @@
1From 0e3dfb9f705ca78be34cd70fd59d67c431e29cc7 Mon Sep 17 00:00:00 2001
2From: Takashi Iwai <tiwai@suse.de>
3Date: Sat, 9 Sep 2023 17:42:03 +0200
4Subject: [PATCH] pcm: Fix segfault with 32bit libs
5
6Upstream-Status: Backport [https://github.com/alsa-project/alsa-lib/commit/0e3dfb9f705ca78be34cd70fd59d67c431e29cc7]
7
8The recent rearrangement of header inclusion order caused a regression
9showing segfaults on 32bit Arm. The primary reason is the
10inconsistent compile condition depending on the inclusion of config.h;
11while most of other code include pcm_local.h (that implicitly includes
12config.h) at first, pcm_direct.c doesn't do it, hence the access with
13direct plugins crashes.
14
15For fixing it, we need to include config.h at the beginning. But,
16it's better to include pcm_local.h for all relevant code for
17consistency. The patch does it, and also it adds the guard in
18pcm_local.h for double inclusions.
19
20Fixes: ad3a8b8b314e ("reshuffle included files to include config.h as first")
21Link: https://github.com/alsa-project/alsa-lib/issues/352
22Signed-off-by: Takashi Iwai <tiwai@suse.de>
23---
24 src/pcm/pcm_direct.c | 1 +
25 src/pcm/pcm_dmix.c | 2 +-
26 src/pcm/pcm_dshare.c | 1 +
27 src/pcm/pcm_dsnoop.c | 1 +
28 src/pcm/pcm_local.h | 5 +++++
29 src/pcm/pcm_shm.c | 1 +
30 6 files changed, 10 insertions(+), 1 deletion(-)
31
32diff --git a/src/pcm/pcm_direct.c b/src/pcm/pcm_direct.c
33index 040fc160..e53e5923 100644
34--- a/src/pcm/pcm_direct.c
35+++ b/src/pcm/pcm_direct.c
36@@ -19,6 +19,7 @@
37 *
38 */
39
40+#include "pcm_local.h"
41 #include <stdio.h>
42 #include <stdlib.h>
43 #include <stddef.h>
44diff --git a/src/pcm/pcm_dmix.c b/src/pcm/pcm_dmix.c
45index 7cd3c508..55cae3e7 100644
46--- a/src/pcm/pcm_dmix.c
47+++ b/src/pcm/pcm_dmix.c
48@@ -26,7 +26,7 @@
49 *
50 */
51
52-#include "config.h"
53+#include "pcm_local.h"
54 #include <stdio.h>
55 #include <stdlib.h>
56 #include <stddef.h>
57diff --git a/src/pcm/pcm_dshare.c b/src/pcm/pcm_dshare.c
58index 454b39a9..c0329098 100644
59--- a/src/pcm/pcm_dshare.c
60+++ b/src/pcm/pcm_dshare.c
61@@ -26,6 +26,7 @@
62 *
63 */
64
65+#include "pcm_local.h"
66 #include <stdio.h>
67 #include <stdlib.h>
68 #include <stddef.h>
69diff --git a/src/pcm/pcm_dsnoop.c b/src/pcm/pcm_dsnoop.c
70index d3ce300c..bf67c68a 100644
71--- a/src/pcm/pcm_dsnoop.c
72+++ b/src/pcm/pcm_dsnoop.c
73@@ -26,6 +26,7 @@
74 *
75 */
76
77+#include "pcm_local.h"
78 #include <stdio.h>
79 #include <stdlib.h>
80 #include <stddef.h>
81diff --git a/src/pcm/pcm_local.h b/src/pcm/pcm_local.h
82index 6a0e71e7..152c92c3 100644
83--- a/src/pcm/pcm_local.h
84+++ b/src/pcm/pcm_local.h
85@@ -20,6 +20,9 @@
86 *
87 */
88
89+#ifndef __PCM_LOCAL_H
90+#define __PCM_LOCAL_H
91+
92 #include "config.h"
93
94 #include <stdio.h>
95@@ -1223,3 +1226,5 @@ static inline void snd_pcm_unlock(snd_pcm_t *pcm)
96 #define snd_pcm_lock(pcm) do {} while (0)
97 #define snd_pcm_unlock(pcm) do {} while (0)
98 #endif /* THREAD_SAFE_API */
99+
100+#endif /* __PCM_LOCAL_H */
101diff --git a/src/pcm/pcm_shm.c b/src/pcm/pcm_shm.c
102index f0bfd934..d9596547 100644
103--- a/src/pcm/pcm_shm.c
104+++ b/src/pcm/pcm_shm.c
105@@ -26,6 +26,7 @@
106 *
107 */
108
109+#include "pcm_local.h"
110 #include <stdio.h>
111 #include <stdlib.h>
112 #include <stddef.h>
113--
1142.25.1
115
diff --git a/recipes-multimedia/alsa/alsa-lib_%.bbappend b/recipes-multimedia/alsa/alsa-lib_%.bbappend
index 4be0d7e1..65498aed 100644
--- a/recipes-multimedia/alsa/alsa-lib_%.bbappend
+++ b/recipes-multimedia/alsa/alsa-lib_%.bbappend
@@ -6,7 +6,6 @@ IMX_PATCH = " \
6 file://0006-add-conf-for-iMX-XCVR-sound-card.patch \ 6 file://0006-add-conf-for-iMX-XCVR-sound-card.patch \
7 file://0007-add-conf-for-imx-cs42448-sound-card.patch \ 7 file://0007-add-conf-for-imx-cs42448-sound-card.patch \
8 file://0001-pcm-rate-fix-the-crash-in-snd_pcm_rate_may_wait_for_.patch \ 8 file://0001-pcm-rate-fix-the-crash-in-snd_pcm_rate_may_wait_for_.patch \
9 file://0001-pcm-Fix-segfault-with-32bit-libs.patch \
10" 9"
11SRC_URI:append:imx-nxp-bsp = "${IMX_PATCH}" 10SRC_URI:append:imx-nxp-bsp = "${IMX_PATCH}"
12 11