diff options
author | Khem Raj <raj.khem@gmail.com> | 2018-09-28 13:18:50 -0700 |
---|---|---|
committer | Otavio Salvador <otavio@ossystems.com.br> | 2018-09-28 17:29:11 -0300 |
commit | 9ae826a5ddb318e7f9248cbab426a509c69f1e19 (patch) | |
tree | 6be115b565a1d7604e2caadd11175fd290a75232 | |
parent | 16c528880f20c68731e645775d31c7445c95a8db (diff) | |
download | meta-freescale-9ae826a5ddb318e7f9248cbab426a509c69f1e19.tar.gz |
mxldr: Fix QA errors seen on x86 builds
* Respect OE flags inside makefiles
* Its not a autotooled recipe but a simple makefile based one
Fixes
NOTE: i586-yoe-linux-musl-objdump -p
TOPDIR/build/tmp/work/i586-yoe-linux-musl/mxsldr/0.0.0+gitAUTOINC+c40d804725-r0/packages-split/mxsldr/usr/bin/mxsldr
ERROR: QA Issue: No GNU_HASH in the elf binary:
'TOPDIR/build/tmp/work/i586-yoe-linux-musl/mxsldr/0.0.0+gitAUTOINC+c40d804725-r0/packages-split/mxsldr/usr/bin/mxsldr'
[ldflags]
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
-rw-r--r-- | recipes-bsp/mxsldr/mxsldr/0001-Do-not-ignore-OE-cflags-and-ldflags.patch | 28 | ||||
-rw-r--r-- | recipes-bsp/mxsldr/mxsldr_git.bb | 12 |
2 files changed, 38 insertions, 2 deletions
diff --git a/recipes-bsp/mxsldr/mxsldr/0001-Do-not-ignore-OE-cflags-and-ldflags.patch b/recipes-bsp/mxsldr/mxsldr/0001-Do-not-ignore-OE-cflags-and-ldflags.patch new file mode 100644 index 00000000..c8c8413a --- /dev/null +++ b/recipes-bsp/mxsldr/mxsldr/0001-Do-not-ignore-OE-cflags-and-ldflags.patch | |||
@@ -0,0 +1,28 @@ | |||
1 | From 2f2e1ca77b4459475e5d649bd22e6bc8c3873695 Mon Sep 17 00:00:00 2001 | ||
2 | From: Khem Raj <raj.khem@gmail.com> | ||
3 | Date: Tue, 25 Sep 2018 01:23:02 -0700 | ||
4 | Subject: [PATCH] Do not ignore OE cflags and ldflags | ||
5 | |||
6 | Signed-off-by: Khem Raj <raj.khem@gmail.com> | ||
7 | --- | ||
8 | Makefile | 4 ++-- | ||
9 | 1 file changed, 2 insertions(+), 2 deletions(-) | ||
10 | |||
11 | diff --git a/Makefile b/Makefile | ||
12 | index afb4e32..d2763ed 100644 | ||
13 | --- a/Makefile | ||
14 | +++ b/Makefile | ||
15 | @@ -3,8 +3,8 @@ prefix ?= "/usr/local" | ||
16 | |||
17 | all: mxsldr | ||
18 | |||
19 | -CFLAGS = `pkg-config --cflags libusb-1.0` | ||
20 | -LDFLAGS = `pkg-config --libs libusb-1.0` | ||
21 | +CFLAGS += `pkg-config --cflags libusb-1.0` | ||
22 | +LDFLAGS += `pkg-config --libs libusb-1.0` | ||
23 | |||
24 | mxsldr: mxsldr.c | ||
25 | $(CC) $(CFLAGS) $(LDFLAGS) $^ -o $@ -lusb-1.0 | ||
26 | -- | ||
27 | 2.19.0 | ||
28 | |||
diff --git a/recipes-bsp/mxsldr/mxsldr_git.bb b/recipes-bsp/mxsldr/mxsldr_git.bb index 5c4b874b..a7df725f 100644 --- a/recipes-bsp/mxsldr/mxsldr_git.bb +++ b/recipes-bsp/mxsldr/mxsldr_git.bb | |||
@@ -7,12 +7,20 @@ LICENSE = "GPLv2+" | |||
7 | LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" | 7 | LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" |
8 | 8 | ||
9 | SRCREV = "c40d80472525e1d57dae5317c028b745968c0399" | 9 | SRCREV = "c40d80472525e1d57dae5317c028b745968c0399" |
10 | SRC_URI = "git://git.denx.de/mxsldr.git" | 10 | SRC_URI = "git://git.denx.de/mxsldr.git \ |
11 | file://0001-Do-not-ignore-OE-cflags-and-ldflags.patch \ | ||
12 | " | ||
11 | 13 | ||
12 | PV = "0.0.0+git${SRCPV}" | 14 | PV = "0.0.0+git${SRCPV}" |
13 | 15 | ||
14 | S = "${WORKDIR}/git" | 16 | S = "${WORKDIR}/git" |
15 | 17 | ||
16 | inherit autotools-brokensep pkgconfig | 18 | inherit pkgconfig |
17 | 19 | ||
20 | do_compile() { | ||
21 | oe_runmake | ||
22 | } | ||
23 | do_install() { | ||
24 | oe_runmake install DESTDIR="${D}" | ||
25 | } | ||
18 | BBCLASSEXTEND = "native nativesdk" | 26 | BBCLASSEXTEND = "native nativesdk" |