From 9ae826a5ddb318e7f9248cbab426a509c69f1e19 Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Fri, 28 Sep 2018 13:18:50 -0700 Subject: mxldr: Fix QA errors seen on x86 builds * Respect OE flags inside makefiles * Its not a autotooled recipe but a simple makefile based one Fixes NOTE: i586-yoe-linux-musl-objdump -p TOPDIR/build/tmp/work/i586-yoe-linux-musl/mxsldr/0.0.0+gitAUTOINC+c40d804725-r0/packages-split/mxsldr/usr/bin/mxsldr ERROR: QA Issue: No GNU_HASH in the elf binary: 'TOPDIR/build/tmp/work/i586-yoe-linux-musl/mxsldr/0.0.0+gitAUTOINC+c40d804725-r0/packages-split/mxsldr/usr/bin/mxsldr' [ldflags] Signed-off-by: Khem Raj Signed-off-by: Otavio Salvador --- .../0001-Do-not-ignore-OE-cflags-and-ldflags.patch | 28 ++++++++++++++++++++++ recipes-bsp/mxsldr/mxsldr_git.bb | 12 ++++++++-- 2 files changed, 38 insertions(+), 2 deletions(-) create mode 100644 recipes-bsp/mxsldr/mxsldr/0001-Do-not-ignore-OE-cflags-and-ldflags.patch diff --git a/recipes-bsp/mxsldr/mxsldr/0001-Do-not-ignore-OE-cflags-and-ldflags.patch b/recipes-bsp/mxsldr/mxsldr/0001-Do-not-ignore-OE-cflags-and-ldflags.patch new file mode 100644 index 00000000..c8c8413a --- /dev/null +++ b/recipes-bsp/mxsldr/mxsldr/0001-Do-not-ignore-OE-cflags-and-ldflags.patch @@ -0,0 +1,28 @@ +From 2f2e1ca77b4459475e5d649bd22e6bc8c3873695 Mon Sep 17 00:00:00 2001 +From: Khem Raj +Date: Tue, 25 Sep 2018 01:23:02 -0700 +Subject: [PATCH] Do not ignore OE cflags and ldflags + +Signed-off-by: Khem Raj +--- + Makefile | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/Makefile b/Makefile +index afb4e32..d2763ed 100644 +--- a/Makefile ++++ b/Makefile +@@ -3,8 +3,8 @@ prefix ?= "/usr/local" + + all: mxsldr + +-CFLAGS = `pkg-config --cflags libusb-1.0` +-LDFLAGS = `pkg-config --libs libusb-1.0` ++CFLAGS += `pkg-config --cflags libusb-1.0` ++LDFLAGS += `pkg-config --libs libusb-1.0` + + mxsldr: mxsldr.c + $(CC) $(CFLAGS) $(LDFLAGS) $^ -o $@ -lusb-1.0 +-- +2.19.0 + diff --git a/recipes-bsp/mxsldr/mxsldr_git.bb b/recipes-bsp/mxsldr/mxsldr_git.bb index 5c4b874b..a7df725f 100644 --- a/recipes-bsp/mxsldr/mxsldr_git.bb +++ b/recipes-bsp/mxsldr/mxsldr_git.bb @@ -7,12 +7,20 @@ LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" SRCREV = "c40d80472525e1d57dae5317c028b745968c0399" -SRC_URI = "git://git.denx.de/mxsldr.git" +SRC_URI = "git://git.denx.de/mxsldr.git \ + file://0001-Do-not-ignore-OE-cflags-and-ldflags.patch \ + " PV = "0.0.0+git${SRCPV}" S = "${WORKDIR}/git" -inherit autotools-brokensep pkgconfig +inherit pkgconfig +do_compile() { + oe_runmake +} +do_install() { + oe_runmake install DESTDIR="${D}" +} BBCLASSEXTEND = "native nativesdk" -- cgit v1.2.3-54-g00ecf