From 573983948ae0550b0f655ea81431bb08ce0bd540 Mon Sep 17 00:00:00 2001 From: Carlos Fernandez Date: Thu, 26 Mar 2026 13:46:38 -0700 Subject: Fix all flake8 warnings from newer flake8-bugbear and flake8-comprehensions Address warnings introduced by flake8-bugbear 24.12.12 and flake8-comprehensions 3.16.0: - C408: Replace dict()/list() calls with literal {} and [] - C413: Remove unnecessary list() around sorted() - C414: Remove unnecessary list() inside sorted() - C419: Suppress intentional list comprehension in all() (noqa) - B001: Replace bare except with except Exception - B006: Replace mutable default arguments with None - B010: Replace setattr() with direct attribute assignment - B017: Use RuntimeError instead of Exception in tests - B019: Suppress lru_cache on methods for long-lived objects (noqa) - B033: Remove duplicate item in set literal Change-Id: If4693d3e946200bbc22f689f7b94da604addcb80 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/566321 Tested-by: Carlos Fernandez Commit-Queue: Carlos Fernandez Reviewed-by: Mike Frysinger Reviewed-by: Gavin Mak --- git_command.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'git_command.py') diff --git a/git_command.py b/git_command.py index 89e8d2f44..ebba92608 100644 --- a/git_command.py +++ b/git_command.py @@ -47,7 +47,7 @@ logger = RepoLogger(__file__) class _GitCall: - @functools.lru_cache(maxsize=None) + @functools.lru_cache(maxsize=None) # noqa: B019 def version_tuple(self): ret = Wrapper().ParseGitVersion() if ret is None: @@ -95,7 +95,7 @@ def RepoSourceVersion(): ver = ver[1:] else: ver = "unknown" - setattr(RepoSourceVersion, "version", ver) + RepoSourceVersion.version = ver return ver @@ -611,7 +611,7 @@ class GitCommandError(GitError): self.git_stderr = git_stderr @property - @functools.lru_cache(maxsize=None) + @functools.lru_cache(maxsize=None) # noqa: B019 def suggestion(self): """Returns helpful next steps for the given stderr.""" if not self.git_stderr: -- cgit v1.2.3-54-g00ecf