diff options
| author | Rahul Yadav <yadavrah@google.com> | 2026-10-12 13:28:18 +0000 |
|---|---|---|
| committer | gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com <gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2026-10-16 00:18:33 -0700 |
| commit | 404aec7b53107a07f29445580f6b5e7a99419757 (patch) | |
| tree | 18cce3052ba35a0ba5e3003f9098e97597c361b8 /progress.py | |
| parent | a0bc2b14a30bef631b91a2ca37c5254d9af44718 (diff) | |
| download | git-repo-404aec7b53107a07f29445580f6b5e7a99419757.tar.gz | |
upload: reject --fix with --ignore-hooks or --no-verify
--fix asks the pre-upload hook to apply its fixups, but:
* --no-verify skips the hook entirely, so --fix silently does nothing.
* --ignore-hooks uploads the original commits even if the hook fails,
so any fixups applied to the working tree are not part of the
upload. Whether --fix should then apply fixups or be ignored is
ambiguous.
Reject both combinations up front, before any hook runs, instead of
picking an interpretation.
Bug: 562921767
Test: python3 -m pytest tests/test_subcmds_upload.py
Change-Id: Ib00ae69004642f2e763212b82e7c39f3b4da52eb
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/642664
Tested-by: Rahul Yadav <yadavrah@google.com>
Reviewed-by: Mike Frysinger <vapier@google.com>
Commit-Queue: Rahul Yadav <yadavrah@google.com>
Diffstat (limited to 'progress.py')
0 files changed, 0 insertions, 0 deletions