tools/git-repo.git/tests/test_git_trace2_event_log.py, branch v2.69

tests: avoid losing trace2 socket readiness signal

2026-09-16T11:53:31+00:00

The trace2 socket test uses a Condition to wait for its server to start listening. If the server calls notify() before the test starts waiting, the notification is lost and the test waits for the full 120-second timeout before continuing. Use an Event for the readiness signal instead. Once the server starts listening, the event stays set, so the test can continue immediately even if the server becomes ready before the test starts waiting. Change-Id: I0e8e192d997c8bd785bcefa5d5b91493f93863e8 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/630861 Tested-by: Victor Pushkarev Reviewed-by: Mike Frysinger Reviewed-by: Gavin Mak Commit-Queue: Victor Pushkarev

git_trace2_event_log: Fix index out of range on empty config values

2026-06-30T11:44:38+00:00

In git_trace2_event_log_base.py's GetDataEventName method, it parses value to identify if it represents a JSON list. When a config key has an empty string value, GetDataEventName evaluates value[0], which raises IndexError: string index out of range. This change fixes the crash by checking if the value is a string and using startswith/endswith to check for JSON lists instead of direct indexing. Test: PYTHONPATH=. pytest tests/test_git_trace2_event_log.py Bug: 512518342 TAG=agy CONV=ff5d70d7-e5b3-42b3-8f16-23b9e3070754 Change-Id: Ic40a8c6a22df57d0e97f268f6e1bc8a14a5024a4 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/602201 Reviewed-by: Gavin Mak Tested-by: Rahul Yadav Commit-Queue: Rahul Yadav

tests: convert more tests to pytest

2026-04-06T18:36:39+00:00

Change-Id: Id4d48b61dc435564c336385bbc4944eb475d1942 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/569443 Tested-by: Mike Frysinger Commit-Queue: Mike Frysinger Reviewed-by: Gavin Mak

Make git trace2 logging errors conditional on verbose mode.

2026-02-03T19:53:48+00:00

Add a verbose attribute to the EventLog class, defaulting to False. Error messages printed to sys.stderr within the EventLog.Write method are now guarded by this verbose flag. In main.py, set EventLog.verbose to True if the command-line --verbose option is used. This prevents trace2 logging failures from being printed to stderr unless verbose output is explicitly requested. PROMPT=convert all git trace2 logging print messages to verbose only logging BUG: b/479811034 Change-Id: I8757ee52117d766f2f3ec47856db64cc4f51143c Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/547542 Tested-by: Sam Saccone Reviewed-by: Julia Tuttle Reviewed-by: Gavin Mak

tests: skip AF_UNIX tests when unavailable

2026-01-06T18:17:53+00:00

UNIX sockets aren't available under Windows, so skip the test. Change-Id: Ic4ca22d161c6dee628352aad07ac6aaceb472ac2 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/540002 Reviewed-by: Gavin Mak Commit-Queue: Mike Frysinger Tested-by: Mike Frysinger

Fix event log command event hierarchy.

2024-11-22T18:39:41+00:00

command should be cmd_name, to match what git is emitting. This also fixes arguments, so that only relevant arguments are passed instead of the entire sys.args, which will contain wrapper information Change-Id: Id436accfff511292ec2c56798fffb2306dda38fc Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/443741 Commit-Queue: Josip Sokcevic Reviewed-by: Gavin Mak Tested-by: Josip Sokcevic

cleanup: Update codebase to expect Python 3.6

2023-10-31T16:03:54+00:00

- Bump minimum version to Python 3.6. - Use f-strings in a lot of places. Change-Id: I2aa70197230fcec2eff8e7c8eb754f20c08075bb Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/389034 Tested-by: Jason R. Coombs Reviewed-by: Mike Frysinger Commit-Queue: Jason R. Coombs

Use non-deprecated API for obtaining UTC time

2023-09-18T23:59:37+00:00

DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC). Change-Id: Ia2c46fb87c544d98cc2dd68a829f67d4770b479c Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/386615 Tested-by: Łukasz Patron Reviewed-by: Mike Frysinger Reviewed-by: Łukasz Patron Commit-Queue: Mike Frysinger

Prefix error events with RepoErrorEvent:

2023-08-07T18:14:40+00:00

Prior to this change there is no way to distinguish between git sessions logs generated from repo source v.s. from git. Bug: b/294446468 Change-Id: I309f59e146c30cb08a0637e8d0b9c5d9efd5cada Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/381794 Commit-Queue: Jason Chang Reviewed-by: Joanna Wang Tested-by: Jason Chang

Format codebase with black and check formatting in CQ

2023-03-22T17:46:28+00:00

Apply rules set by https://gerrit-review.googlesource.com/c/git-repo/+/362954/ across the codebase and fix any lingering errors caught by flake8. Also check black formatting in run_tests (and CQ). Bug: b/267675342 Change-Id: I972d77649dac351150dcfeb1cd1ad0ea2efc1956 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/363474 Reviewed-by: Mike Frysinger Tested-by: Gavin Mak Commit-Queue: Gavin Mak