Mirror of gerrit.googlesource.com/git-repo https://git.enea.com/cgit/tools/git-repo.git/atom?h=v2.16 2021-01-06T18:53:05+00:00 2021-01-06T18:53:05+00:00 Mike Frysinger vapier@google.com 2021-01-01T13:42:31+00:00 urn:sha1:784ccfc040dc8efa1a64d3c7d4070b66beb15d08 We're committed to Python 3 at this point, so clean up boilerplate. Bug: https://crbug.com/gerrit/10418 Change-Id: Ib1719ba2eb65c53b94881a1a1bf203ddfcaaafed Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/292382 Reviewed-by: Chris Mcdonald <cjmcdonald@google.com> Tested-by: Mike Frysinger <vapier@google.com> 2019-11-16T23:55:30+00:00 Mike Frysinger vapier@google.com 2019-11-15T06:19:03+00:00 urn:sha1:70c54dc2550084ed022a2f134065a011f37f30aa The upload module tries to turn the strings into bytes before passing to EditString, but it combines bytes & strings causing an error. The return value might be bytes or string, but the caller only expects a string. Lets simplify this by sticking to strings everywhere and have EditString take care of converting to/from bytes when reading/writing the underlying files. This also avoids possible locale confusion when reading the file by forcing UTF-8 everywhere. Bug: https://crbug.com/gerrit/11929 Change-Id: I07b146170c5e8b5b0500a2c79e4213cd12140a96 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/245621 Reviewed-by: David Pursehouse <dpursehouse@collab.net> Tested-by: Mike Frysinger <vapier@google.com>