<feed xmlns='http://www.w3.org/2005/Atom'>
<title>tools/git-repo.git/platform_utils_win32.py, branch v2.8</title>
<subtitle>Mirror of gerrit.googlesource.com/git-repo</subtitle>
<id>https://git.enea.com/cgit/tools/git-repo.git/atom?h=v2.8</id>
<link rel='self' href='https://git.enea.com/cgit/tools/git-repo.git/atom?h=v2.8'/>
<link rel='alternate' type='text/html' href='https://git.enea.com/cgit/tools/git-repo.git/'/>
<updated>2020-02-15T04:45:16+00:00</updated>
<entry>
<title>flake8: Suppress "F821 undefined name" inline for Python 2 names</title>
<updated>2020-02-15T04:45:16+00:00</updated>
<author>
<name>David Pursehouse</name>
<email>dpursehouse@collab.net</email>
</author>
<published>2020-02-15T03:45:53+00:00</published>
<link rel='alternate' type='text/html' href='https://git.enea.com/cgit/tools/git-repo.git/commit/?id=a46bf7dc2af111ae4a663d61ed06dc90ddfb8068'/>
<id>urn:sha1:a46bf7dc2af111ae4a663d61ed06dc90ddfb8068</id>
<content type='text'>
All of the instances of this are related to Python 2 names that
don't exist in Python 3, and the warnings are raised when running
flake8 on Python 3.

All of these will go away once we completely remove support for
Python 2, so just suppress them inline. We don't globally suppress
the check so that we will still see legitimate errors if/when they
occur in new code.

Change-Id: Iccf955f50abfc9f83b371fc0af6cceb51037456f
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/255039
Tested-by: David Pursehouse &lt;dpursehouse@collab.net&gt;
Reviewed-by: Mike Frysinger &lt;vapier@google.com&gt;
</content>
</entry>
<entry>
<title>pyflakes: Fix remaining "E501 line too long" warnings</title>
<updated>2020-02-13T04:54:10+00:00</updated>
<author>
<name>David Pursehouse</name>
<email>dpursehouse@collab.net</email>
</author>
<published>2020-02-13T04:17:03+00:00</published>
<link rel='alternate' type='text/html' href='https://git.enea.com/cgit/tools/git-repo.git/commit/?id=3cda50a41b1a950d70be8887c5efe3735586d1bb'/>
<id>urn:sha1:3cda50a41b1a950d70be8887c5efe3735586d1bb</id>
<content type='text'>
We increased the max line length to 100 columns which got rid of
the majority of these warnings, but there were still a few lines
that exceeded 100 columns.

Change-Id: Ib3372868ca2297f83073a14f91c8ae3df9d0d0e6
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254699
Tested-by: David Pursehouse &lt;dpursehouse@collab.net&gt;
Reviewed-by: Mike Frysinger &lt;vapier@google.com&gt;
</content>
</entry>
<entry>
<title>[Win32] Make platform_utils compatible for Python3</title>
<updated>2020-02-06T14:29:15+00:00</updated>
<author>
<name>Remy Böhmer</name>
<email>linux@bohmer.net</email>
</author>
<published>2020-01-07T07:48:55+00:00</published>
<link rel='alternate' type='text/html' href='https://git.enea.com/cgit/tools/git-repo.git/commit/?id=dbd277ce500491cea14bdca48ccb0f9148e55b56'/>
<id>urn:sha1:dbd277ce500491cea14bdca48ccb0f9148e55b56</id>
<content type='text'>
On Python 3 several imports are to be imported from
different locations.

Signed-off-by: Remy Böhmer &lt;linux@bohmer.net&gt;
Change-Id: I4f243d145f65e38f74743a742583cfc5c5d76deb
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/249610
Reviewed-by: Mike Frysinger &lt;vapier@google.com&gt;
</content>
</entry>
<entry>
<title>Fix a typo</title>
<updated>2020-01-25T00:53:39+00:00</updated>
<author>
<name>Rostislav Krasny</name>
<email>rostigm@gmail.com</email>
</author>
<published>2020-01-24T21:15:09+00:00</published>
<link rel='alternate' type='text/html' href='https://git.enea.com/cgit/tools/git-repo.git/commit/?id=9da67feecffeecfa4d3eca56abcd54055d38187b'/>
<id>urn:sha1:9da67feecffeecfa4d3eca56abcd54055d38187b</id>
<content type='text'>
Change-Id: I1d1d1c7ec6c0c706eb08ceb803c37e1ce1baf8b3
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/251834
Reviewed-by: David Pursehouse &lt;dpursehouse@collab.net&gt;
Tested-by: Rostislav Krasny &lt;rostigm@gmail.com&gt;
</content>
</entry>
<entry>
<title>Make _preserve_encoding in platform_utils_win32 compatible with Python 3</title>
<updated>2020-01-24T21:50:22+00:00</updated>
<author>
<name>Rostislav Krasny</name>
<email>rostigm@gmail.com</email>
</author>
<published>2020-01-24T20:29:54+00:00</published>
<link rel='alternate' type='text/html' href='https://git.enea.com/cgit/tools/git-repo.git/commit/?id=b71d61d34e71d6a0f6a92355d6b6d4e91d9498fe'/>
<id>urn:sha1:b71d61d34e71d6a0f6a92355d6b6d4e91d9498fe</id>
<content type='text'>
Bug: https://crbug.com/gerrit/12145
Change-Id: I01d1ef96ff7b474f55ed42ecc13bd5943006d3b5
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/251833
Reviewed-by: Mike Frysinger &lt;vapier@google.com&gt;
Tested-by: Rostislav Krasny &lt;rostigm@gmail.com&gt;
</content>
</entry>
<entry>
<title>set default file encoding to utf-8</title>
<updated>2019-06-13T14:30:52+00:00</updated>
<author>
<name>Mike Frysinger</name>
<email>vapier@google.com</email>
</author>
<published>2019-06-13T06:30:51+00:00</published>
<link rel='alternate' type='text/html' href='https://git.enea.com/cgit/tools/git-repo.git/commit/?id=f601376e13e6beca7ab8d660e00d6c14714f305f'/>
<id>urn:sha1:f601376e13e6beca7ab8d660e00d6c14714f305f</id>
<content type='text'>
There's no reason to support any other encoding in these files.
This only affects the files themselves and not streams they open.

Bug: https://crbug.com/gerrit/10418
Change-Id: I053cb40cd3666ce5c8a0689b9dd938f24ca765bf
</content>
</entry>
<entry>
<title>platform_utils_win32: remove an unnecessary workaround</title>
<updated>2019-03-21T20:45:59+00:00</updated>
<author>
<name>Роман Донченко</name>
<email>dpb@corrigendum.ru</email>
</author>
<published>2019-03-21T20:45:59+00:00</published>
<link rel='alternate' type='text/html' href='https://git.enea.com/cgit/tools/git-repo.git/commit/?id=a84df061609ed937c0bbc45491fd352d62caa0fc'/>
<id>urn:sha1:a84df061609ed937c0bbc45491fd352d62caa0fc</id>
<content type='text'>
The comment in _create_symlink is incorrect. The return value of
CreateSymbolicLink is as documented, it was just declared with
the wrong return type. The actual return type is BOOLEAN, not BOOL.

Fixing this allows us to simplify the code a bit.

Change-Id: I4d2190a50d45ba41dd9814bf7079a5784fc0a366
</content>
</entry>
<entry>
<title>Windows: Add support for creating symlinks as an unprivileged user</title>
<updated>2018-10-03T16:41:09+00:00</updated>
<author>
<name>Renaud Paquay</name>
<email>rpaquay@google.com</email>
</author>
<published>2018-10-01T21:59:48+00:00</published>
<link rel='alternate' type='text/html' href='https://git.enea.com/cgit/tools/git-repo.git/commit/?id=2b42d288c08bdfd0fc3402fa118d91a1aebdb655'/>
<id>urn:sha1:2b42d288c08bdfd0fc3402fa118d91a1aebdb655</id>
<content type='text'>
See https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10/
for announcement of new flag.

This change follow the same pattern as what was done in "go":
https://github.com/golang/go/pull/24307/files#diff-b87bc12e4da2497308f9ef746086e4f0

Change-Id: If1e99fefdd3f787598e695731019c34b9bfcd1c2
</content>
</entry>
<entry>
<title>Implement islink, readlink and realpath using Win32 api</title>
<updated>2017-08-31T20:49:01+00:00</updated>
<author>
<name>Renaud Paquay</name>
<email>rpaquay@google.com</email>
</author>
<published>2016-11-01T21:37:13+00:00</published>
<link rel='alternate' type='text/html' href='https://git.enea.com/cgit/tools/git-repo.git/commit/?id=227ad2ef42f47798d24814dfc2cef8119c313ab7'/>
<id>urn:sha1:227ad2ef42f47798d24814dfc2cef8119c313ab7</id>
<content type='text'>
Change-Id: I18452cbb32d24db73601ad10485dbe6bb278731c
</content>
</entry>
<entry>
<title>Add support for creating symbolic links on Windows</title>
<updated>2017-05-29T10:30:34+00:00</updated>
<author>
<name>Renaud Paquay</name>
<email>rpaquay@google.com</email>
</author>
<published>2016-11-01T18:24:03+00:00</published>
<link rel='alternate' type='text/html' href='https://git.enea.com/cgit/tools/git-repo.git/commit/?id=d5cec5e752821ca2710101b626b3a3ca07fdb7f8'/>
<id>urn:sha1:d5cec5e752821ca2710101b626b3a3ca07fdb7f8</id>
<content type='text'>
Replace all calls to os.symlink with platform_utils.symlink.

The Windows implementation calls into the CreateSymbolicLinkW Win32
API, as os.symlink is not supported.

Separate the Win32 API definitions into a separate module
platform_utils_win32 for clarity.

Change-Id: I0714c598664c2df93383734e609d948692c17ec5
</content>
</entry>
</feed>
