tools/git-repo.git/git_command.py, branch v2.53

Disable git terminal prompt during fetch/clone

2024-09-26T22:10:36+00:00

git fetch operation may prompt user to enter username and password. This won't be visible to user when repo sync operation since stdout and stderr are redirected. If that happens, user may think repo is doing work and likely won't realize it's stuck on user's input. This patch disables prompt for clone and fetch operations, and repo will fail fast. R=gavinmak@google.com Bug: b/368644181 Change-Id: I2efa88ae66067587a00678eda155d861034b9127 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/438001 Reviewed-by: Nasser Grainawi Tested-by: Josip Sokcevic Commit-Queue: Josip Sokcevic Reviewed-by: Gavin Mak

git_command: unify soft/hard versions with requirements.json

2024-03-21T21:20:50+00:00

Use the requirements logic in the wrapper to load versions out of the requirements.json file to avoid duplicating them in git_command.py. Change-Id: Ib479049fc54ebc6f52c2c30d1315cf1734ff1990 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/415617 Reviewed-by: Josip Sokcevic Commit-Queue: Mike Frysinger Tested-by: Mike Frysinger

git_command: Return None from GetEventTargetPath() if set to empty string

2024-02-26T17:51:11+00:00

If trace2.eventTarget was set to the empty string, match git behavior and don't write a trace. Bug: 319673783 Change-Id: I02b3884ad97551f8a9d7363c2cbe6b0adee6f73e Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/410518 Reviewed-by: Josip Sokcevic Commit-Queue: Josip Sokcevic Tested-by: Peter Collingbourne

cleanup: Update codebase to expect Python 3.6

2023-10-31T16:03:54+00:00

- Bump minimum version to Python 3.6. - Use f-strings in a lot of places. Change-Id: I2aa70197230fcec2eff8e7c8eb754f20c08075bb Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/389034 Tested-by: Jason R. Coombs Reviewed-by: Mike Frysinger Commit-Queue: Jason R. Coombs

delete Python 2 (object) compat

2023-10-20T04:51:01+00:00

Bug: 302871152 Change-Id: I39636d73a6e1d69efa8ade74f75c5381651e6dc8 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/390054 Commit-Queue: Mike Frysinger Reviewed-by: Aravind Vasudevan Tested-by: Mike Frysinger

git_command: read1 needs a size in py3.6

2023-10-09T17:04:38+00:00

Not setting size causes "TypeError: read1() takes exactly one argument (0 given)" in Python 3.6. In Python 3.7 onwards size defaults to -1, which means an arbitrary number of bytes will be returned. Compare https://docs.python.org/3.6/library/io.html#io.BufferedReader.read1 and https://docs.python.org/3.7/library/io.html#io.BufferedIOBase.read1 for more details. Change-Id: Ia4aaf8140ead9493ec650fac167c641569e6a9d8 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/388718 Reviewed-by: Mike Frysinger Tested-by: Daniel Kutik Commit-Queue: Daniel Kutik

git_command: lru_cache needs maxsize for py36 & 37

2023-10-09T14:08:29+00:00

Python 3.6 and 3.7 do not have a default value for lru_cache maxsize. Not setting it would cause: TypeError: Expected maxsize to be an integer or None Change-Id: I32d4fb6a0040a0c24da0b2f29f22f85a36c96531 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/388737 Reviewed-by: Mike Frysinger Tested-by: Daniel Kutik Commit-Queue: Daniel Kutik

git_command: Augment underlying git errors with suggestions

2023-10-06T18:21:45+00:00

This change appends suggestions to the underlying git error to make the error slightly more actionable. DD: go/improve-repo-error-reporting & go/tee-repo-stderr Bug: b/292704435 Change-Id: I2bf8bea5fca42c6a9acd2fadc70f58f22456e027 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/387774 Commit-Queue: Aravind Vasudevan Reviewed-by: Jason Chang Tested-by: Aravind Vasudevan Reviewed-by: Aravind Vasudevan

Track expected git errors in logs

2023-09-27T19:05:16+00:00

Sometimes it is expected that a GitCommand executed in repo fails. In such cases indicate in trace logs that the error was expected. Bug: b/293344017 Change-Id: If137fae9ef9769258246f5b4494e070345db4a71 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/387714 Commit-Queue: Jason Chang Reviewed-by: Gavin Mak Tested-by: Jason Chang

Log ErrorEvent for failing GitCommands

2023-09-06T18:22:33+00:00

Change-Id: I270af7401cff310349e736bef87e9b381cc4d016 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/385054 Reviewed-by: Gavin Mak Commit-Queue: Jason Chang Tested-by: Jason Chang