tools/git-repo.git, branch v2.18

init, sync: fixed flake8 warnings.

2021-11-18T16:22:40+00:00

Tested: + run_tests + flake8 subcmds/init.py + flake8 subcmds/sync.py Change-Id: Ie337481d8a210bfc49b0745f75c05a308a0e74d3 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/324155 Reviewed-by: Mike Frysinger Tested-by: Raman Tenneti

superproject: Inherit --no-use-superproject with --mirror option.

2021-11-18T01:27:41+00:00

init.py + Similar to opt.archive, gave an error if --mirror option is used with --use-superproject. sync.py + Defaulted to --no-use-superproject if manifest is a mirror or archive (similar to error at line# 1067). Tested: + run_tests + flake8 (will fix known errors in another CL). $ repo_dev init -u sso://googleplex-android.git.corp.google.com/platform/manifest --use-superproject --mirror Usage: repo init [options] [manifest url] main.py: error: --mirror and --use-superproject cannot be used together. + repo init and repo sync with --mirror and without --mirror options. $ repo_dev init -u https://android.googlesource.com/platform/manifest $ repo_dev sync ...superproject.git: Initial setup for superproject completed. + With --mirror option, verfied there are no exceptions in git_superproject.py Bug: [google internal] b/206537893 Change-Id: I059f20e76f0ab36f0587f29779bb53ede4663bd4 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/323955 Reviewed-by: Mike Frysinger Tested-by: Raman Tenneti

sync: Handle tag ref in "upstream" field

2021-11-16T20:43:57+00:00

repo sync only handles a git tag properly when it is in the "revision" field. However, "revision locked manifests" (`repo manifest --revision-as-HEAD`) specifies the tag in the "upstream" field. The issue is that this tag is not fetched. Only the commit that the tag points to is fetched. This cases issues as self._CheckForImmutableRevision() runs and comes to the conclusion that the tag was changed while in fact, it was just not fetched. This causes a full sync. File docs/manifest-format.md, section Element-project: > Attribute upstream: Name of the Git ref in which a sha1 can be found. Used when syncing a revision locked manifest in -c mode to avoid having to sync the entire ref space. Project elements not setting their own upstream will inherit this value. Change-Id: I0507d3a5f30aee8920a9f820bafedb48dd5db554 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/323620 Reviewed-by: Mike Frysinger Tested-by: Robin Schneider

project: init hooks in objdir only

2021-11-15T19:50:18+00:00

objdir is the .repo/project-objects/ dir based on the remote path. gitdir is the .repo/projects/ dir based on the local source checkout path. When we setup the gitdir, we symlink "hooks" to the one in the objdir. But when we go to initialize the hooks, we do it via gitdir. There is a 1-to-many mapping from project-objects to projects, so initializing via gitdir can be repetitive. Collapse the hook init logic to the objdir init path. Change-Id: I828fca60ce6e125d6706c709cdb2797faa40aa50 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/323815 Reviewed-by: Raman Tenneti Tested-by: Mike Frysinger

sync: link the internal-fs-layout doc into checkouts

2021-11-15T01:39:53+00:00

This should make it easy to discover for people poking around .repo/. Change-Id: Ie5051551f25127c0592df5e36efba7bb2263e5d4 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/323701 Reviewed-by: Jack Neus Tested-by: Mike Frysinger

git-review: add config file

2021-11-15T01:39:36+00:00

This is used by the `git review` tool that some people use. Change-Id: I8dac4e1dad155109a05181deaec61e1a74857b1f Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/323698 Reviewed-by: Raman Tenneti Tested-by: Mike Frysinger

SUBMITTING_PATCHES: link to commit message style docs

2021-11-15T01:39:16+00:00

Change-Id: I2090ebc43fc1c816b941a53dd89dbedf7bc61289 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/323696 Tested-by: Mike Frysinger Reviewed-by: Jack Neus

man: refresh pages

2021-11-12T17:30:45+00:00

Change-Id: I3f2c3ad77c16a76276bba2954887ab9e7605661c Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/323516 Reviewed-by: Jack Neus Tested-by: Mike Frysinger

help: fix grammar in help text

2021-11-12T17:30:32+00:00

Bug: https://crbug.com/gerrit/14838 Change-Id: Ic5000921ba9a1baa086153630ebbb429e3d17642 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/323515 Reviewed-by: Jack Neus Tested-by: Mike Frysinger

Fix typo for ValueError

2021-11-07T02:32:08+00:00

which will cause error log like below: NameError: name 'ValueErrorl' is not defined Change-Id: I388886b7cf6d700e224c3847b7ba4ba4fe9c041d Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/323015 Reviewed-by: Mike Frysinger Tested-by: 彭杨益