tools/git-repo.git/.pylintrc, branch v2.4

Replace pylint with pyflakes/flake8

2016-09-14T07:49:02+00:00

pylint reports a lot of warnings, but many of them are false positive, and it's difficult to configure it. It also seems that for some reason the included config file is not working well with the latest version. Update the documentation to recommend using pyflakes and flake8 instead of pylint. Remove the pylint config and add a basic flake8 config with minimum settings: - Maximum line length 80 columns - Ignore warnings about indentation (repo uses 2 rather than expected 4) - Ignore warnings about import placement In this commit no code cleanup is done, and it's expected that most of the files will throw up quite a few warnings, at least for flake8. These can be cleaned up in follow-up commits. The existing pylint suppression comments are left as-is. These will be helpful when cleaning up pyflakes warnings later. Change-Id: I2f7cb4340266ed07cc973ca6483b8f09d66a765b

pylint: ignore bad-whitespace

2016-06-17T23:37:24+00:00

This ignores whitespaces errors, which we have quite a few of in argument lists, for example: ************* Module git_config C:209, 0: No space allowed around keyword argument assignment def HasSection(self, section, subsection = ''): ^ (bad-whitespace) C:320, 0: No space allowed around keyword argument assignment capture_stdout = True, ^ (bad-whitespace) C:321, 0: No space allowed around keyword argument assignment capture_stderr = True) ^ (bad-whitespace) C:427, 0: Exactly one space required after comma '-o','ControlPath %s' % ssh_sock(), ^ (bad-whitespace) C:436, 0: Exactly one space required after comma check_command = command_base + ['-O','check'] ^ (bad-whitespace) C:464, 0: Exactly one space required after comma % (host,port, str(e)), file=sys.stderr) ^ (bad-whitespace) C:707, 0: No space allowed around keyword argument assignment return self._config.GetString(key, all_keys = all_keys) ^ (bad-whitespace) C:759, 0: No space allowed around keyword argument assignment return self._config.GetString(key, all_keys = all_keys) ^ (bad-whitespace) Change-Id: Ia8f154f6741ce609787551f65877d7584c457903 Signed-off-by: Stefan Beller

Remove deprecated `include-ids` setting from pylint config

2015-04-07T02:10:17+00:00

Change-Id: Ie5ab21e434d24ff862bb5e0c263761370d71f56f

Disable warning about locally disabling pylint warnings

2013-05-15T09:06:06+00:00

Several files have local suppression of pylint warnings. We don't need these to be reported; code review should catch any unnecessary suppressions. Change-Id: Ie71ba3e910714ef3fe44554a71bb62519d0a891d

Disable pylint warnings about similar lines in multiple files

2013-05-04T12:40:56+00:00

When running pylint over the entire code base, it reports the warning: R0801: Similar lines in 2 files for several pairs of files. The code referred to is boilerplate code related to imports and error handling. It is not practical to change the code to avoid the warnings, so simply disable them in the config. Change-Id: Ie685fdf1cab60fb8f1503be560166a14058698d8

Disable warnings related to imports in pylint config

2013-05-03T13:10:26+00:00

There are several modules that have imports to support various versions of Python. Pylint reports the following errors when run in a version of Python that does not have the module or the method/class in the module. F0401: Unable to import 'module' E0611: No name 'name' in module 'module' Disable these warnings to reduce the noise on the output. Change-Id: I97e7e2698bccb1e501a45a0869f97f90d54adfb7

Tidy up code formatting a bit more

2012-11-14T03:09:38+00:00

Enable the following Pylint warnings: C0322: Operator not preceded by a space C0323: Operator not followed by a space C0324: Comma not followed by a space And make the necessary fixes. Change-Id: I74d74283ad5138cbaf28d492b18614eb355ff9fe

Fix inconsistent indentation

2012-11-14T02:38:57+00:00

The repo coding style is to indent at 2 characters, but there are many places where this is not followed. Enable pylint warning "W0311: Bad indentation" and make sure all indentation is at multiples of 2 characters. Change-Id: I68f0f64470789ce2429ab11104d15d380a63e6a8

Add pylint configuration and instructions

2012-10-24T01:18:13+00:00

pylint configuration file (.pylintrc) is added, and submission instructions are updated to include pylint usage steps. Deprecated pylint suppression (`disable-msg`) is updated in a few modules to make it work properly with the latest version (0.26). Change-Id: I4ec2ef318e23557a374ecdbf40fe12645766830c