From fd0df2cb78b26d6633625057d835dc0b26fe51a4 Mon Sep 17 00:00:00 2001 From: Quentin Schulz Date: Thu, 18 Sep 2025 12:24:45 +0200 Subject: contributor-guide: submit-changes: make "Crediting contributors" part of "Commit your changes" There's no need to differentiate crediting contributors from committing your changes, so let's simply make it the last step of "Commit your changes" section. This simply indents the text so it's now part of "Commit your changes" list instead of the main list in the "Implement and commit changes" section. Because of this reorganisation, the instruction to use "git commit --amend" to add the contributors is moved to a note, and the first few sentences are reworded to better match the wording of other items in the "Commit your changes" list of instructions. (From yocto-docs rev: 5ce7ae8f655f45dec80e68398911f117920f5eb2) Signed-off-by: Quentin Schulz Signed-off-by: Antonin Godard (cherry picked from commit eff4d14e28d323ebfdaeb0c5c805b5f1e2ad153d) Signed-off-by: Antonin Godard Signed-off-by: Steve Sakoman --- documentation/contributor-guide/submit-changes.rst | 54 ++++++++++++---------- 1 file changed, 29 insertions(+), 25 deletions(-) diff --git a/documentation/contributor-guide/submit-changes.rst b/documentation/contributor-guide/submit-changes.rst index 4946f040c0..71b900f60c 100644 --- a/documentation/contributor-guide/submit-changes.rst +++ b/documentation/contributor-guide/submit-changes.rst @@ -204,31 +204,35 @@ to add the upgraded version. detailed description of change -#. *Crediting contributors:* By using the ``git commit --amend`` command, - you can add some tags to the commit description to credit other contributors - to the change: - - - ``Reported-by``: name and email of a person reporting a bug - that your commit is trying to fix. This is a good practice - to encourage people to go on reporting bugs and let them - know that their reports are taken into account. - - - ``Suggested-by``: name and email of a person to credit for the - idea of making the change. - - - ``Tested-by``, ``Reviewed-by``: name and email for people having - tested your changes or reviewed their code. These fields are - usually added by the maintainer accepting a patch, or by - yourself if you submitted your patches to early reviewers, - or are submitting an unmodified patch again as part of a - new iteration of your patch series. - - - ``Cc``: name and email of people you want to send a copy - of your changes to. This field will be used by ``git send-email``. - - See `more guidance about using such tags - `__ - in the Linux kernel documentation. + #. If other people participated in this patch, add some tags to the commit + description to credit other contributors to the change: + + - ``Reported-by``: name and email of a person reporting a bug + that your commit is trying to fix. This is a good practice + to encourage people to go on reporting bugs and let them + know that their reports are taken into account. + + - ``Suggested-by``: name and email of a person to credit for the + idea of making the change. + + - ``Tested-by``, ``Reviewed-by``: name and email for people having + tested your changes or reviewed their code. These fields are + usually added by the maintainer accepting a patch, or by + yourself if you submitted your patches to early reviewers, + or are submitting an unmodified patch again as part of a + new iteration of your patch series. + + - ``Cc``: name and email of people you want to send a copy + of your changes to. This field will be used by ``git send-email``. + + See `more guidance about using such tags + `__ + in the Linux kernel documentation. + + .. note:: + + One can amend an existing git commit message to add missing tags for + contributors with the ``git commit --amend`` command. Test your changes ----------------- -- cgit v1.2.3-54-g00ecf