From e3b8290fe724b62c5fc0b88394d96066cb1b4bef Mon Sep 17 00:00:00 2001 From: Jon Mason Date: Sat, 4 Oct 2025 11:59:57 -0400 Subject: gn: remove gcc override MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When compiling gn with clang, the following errors are being seen (with qemuarm64-secureboot machine, possibly others): In file included from /usr/include/c++/12/string:40, from ../sources/gn-0+git/src/base/strings/string_number_conversions.h:11, from ../sources/gn-0+git/src/gn/operators.cc:10: In static member function ‘static constexpr void std::char_traits::assign(char_type&, const char_type&)’, inlined from ‘static constexpr void std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_S_copy(_CharT*, const _CharT*, size_type) [with _CharT = char; _Traits = std::char_traits; _Alloc = std::allocator]’ at /usr/include/c++/12/bits/basic_string.h:421:23, inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, _Allocator>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_M_replace(size_type, size_type, const _CharT*, size_type) [with _CharT = char; _Traits = std::char_traits; _Alloc = std::allocator]’ at /usr/include/c++/12/bits/basic_string.tcc:532:22, inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, _Alloc>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::assign(const _CharT*) [with _CharT = char; _Traits = std::char_traits; _Alloc = std::allocator]’ at /usr/include/c++/12/bits/basic_string.h:1647:19, inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, _Alloc>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::operator=(const _CharT*) [with _CharT = char; _Traits = std::char_traits; _Alloc = std::allocator]’ at /usr/include/c++/12/bits/basic_string.h:815:28, inlined from ‘Err {anonymous}::MakeOverwriteError(const BinaryOpNode*, const Value&)’ at ../sources/gn-0+git/src/gn/operators.cc:202:17: /usr/include/c++/12/bits/char_traits.h:354:16: error: ‘((const std::char_traits::char_type*)((char*)&empty_def + offsetof(std::__cxx11::string, std::__cxx11::basic_string, std::allocator >::)))[2]’ may be used uninitialized [-Werror=maybe-uninitialized] 354 | __c1 = __c2; | ^~~~ ../sources/gn-0+git/src/gn/operators.cc: In function ‘Err {anonymous}::MakeOverwriteError(const BinaryOpNode*, const Value&)’: ../sources/gn-0+git/src/gn/operators.cc:198:15: note: ‘empty_def’ declared here 198 | std::string empty_def; | ^~~~~~~~~ In static member function ‘static constexpr void std::char_traits::assign(char_type&, const char_type&)’, inlined from ‘static constexpr void std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_S_copy(_CharT*, const _CharT*, size_type) [with _CharT = char; _Traits = std::char_traits; _Alloc = std::allocator]’ at /usr/include/c++/12/bits/basic_string.h:421:23, inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, _Allocator>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_M_replace(size_type, size_type, const _CharT*, size_type) [with _CharT = char; _Traits = std::char_traits; _Alloc = std::allocator]’ at /usr/include/c++/12/bits/basic_string.tcc:532:22, inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, _Alloc>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::assign(const _CharT*) [with _CharT = char; _Traits = std::char_traits; _Alloc = std::allocator]’ at /usr/include/c++/12/bits/basic_string.h:1647:19, inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, _Alloc>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::operator=(const _CharT*) [with _CharT = char; _Traits = std::char_traits; _Alloc = std::allocator]’ at /usr/include/c++/12/bits/basic_string.h:815:28, inlined from ‘Err {anonymous}::MakeOverwriteError(const BinaryOpNode*, const Value&)’ at ../sources/gn-0+git/src/gn/operators.cc:205:17: /usr/include/c++/12/bits/char_traits.h:354:16: error: ‘((const std::char_traits::char_type*)((char*)&empty_def + offsetof(std::__cxx11::string, std::__cxx11::basic_string, std::allocator >::)))[2]’ may be used uninitialized [-Werror=maybe-uninitialized] 354 | __c1 = __c2; | ^~~~ ../sources/gn-0+git/src/gn/operators.cc: In function ‘Err {anonymous}::MakeOverwriteError(const BinaryOpNode*, const Value&)’: ../sources/gn-0+git/src/gn/operators.cc:198:15: note: ‘empty_def’ declared here 198 | std::string empty_def; | ^~~~~~~~~ cc1plus: all warnings being treated as errors Remove the toolchain-gcc override to allow the cflag -Wno-error=maybe-uninitialized to be applied. (From OE-Core rev: 945d2490603edc2abcb6cdcb3e2e87d89d833ece) Signed-off-by: Jon Mason Signed-off-by: Mathieu Dubois-Briand Signed-off-by: Richard Purdie --- meta/recipes-devtools/gn/gn_git.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-devtools/gn/gn_git.bb b/meta/recipes-devtools/gn/gn_git.bb index d8896609b1..87ccfe3704 100644 --- a/meta/recipes-devtools/gn/gn_git.bb +++ b/meta/recipes-devtools/gn/gn_git.bb @@ -49,4 +49,4 @@ BBCLASSEXTEND = "native" COMPATIBLE_HOST = "^(?!riscv32).*" -CFLAGS:append:toolchain-gcc = " -Wno-error=maybe-uninitialized" +CFLAGS += "-Wno-error=maybe-uninitialized" -- cgit v1.2.3-54-g00ecf