From 622d2b57f5cfd29ee0fa00e51604588f270fabbd Mon Sep 17 00:00:00 2001 From: Martin Hundeb?ll Date: Mon, 27 May 2024 14:40:57 +0200 Subject: classes: image_types: quote variable assignment needed by dash MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The change in commit 39fc503036 ("classes: image_types: apply EXTRA_IMAGECMD:squashfs* in oe_mksquashfs()") assigns $@ to a local variable without quoting it. While this works with bash, it fails with dash. Here, only the first token of $@ is assigned to the variable, and the reamining tokens are passed as arguments to the "local" keyword. Fix it by adding the missing quotes. (From OE-Core rev: 14ca134f9f72d518c9180156a8efac19f8bb3ab0) Signed-off-by: Martin Hundebøll Signed-off-by: Alexandre Belloni Signed-off-by: Richard Purdie --- meta/classes-recipe/image_types.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes-recipe/image_types.bbclass b/meta/classes-recipe/image_types.bbclass index b4a83ae284..2f948ecbf8 100644 --- a/meta/classes-recipe/image_types.bbclass +++ b/meta/classes-recipe/image_types.bbclass @@ -113,7 +113,7 @@ IMAGE_CMD:btrfs () { oe_mksquashfs () { local comp=$1; shift - local extra_imagecmd=$@ + local extra_imagecmd="$@" if [ "$comp" = "zstd" ]; then suffix="zst" -- cgit v1.2.3-54-g00ecf