From 4678581ea054b1eef305ff5bc4bd40d8b74374ca Mon Sep 17 00:00:00 2001 From: Aryaman Gupta Date: Wed, 29 Jun 2022 16:08:20 -0400 Subject: buildstats.py: close /proc/pressure/cpu file descriptor Use python 'with' symantics to ensure that the /proc/pressure/cpu file descriptor used in SystemStats init is closed. Previously, this would lead to a single file descriptor being leaked. For example: ResourceWarning: unclosed file <_io.BufferedReader name='/proc/pressure/cpu'> (From OE-Core rev: 643653160cd77d346cdc9b9ec25c7212c7dfe176) Signed-off-by: Aryaman Gupta Signed-off-by: Richard Purdie --- meta/lib/buildstats.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/lib/buildstats.py b/meta/lib/buildstats.py index 5d32a81906..99a8303d5e 100644 --- a/meta/lib/buildstats.py +++ b/meta/lib/buildstats.py @@ -23,8 +23,8 @@ class SystemStats: # and ensure that the reduce_proc_pressure directory is not created. if os.path.exists("/proc/pressure"): try: - source = open('/proc/pressure/cpu', 'rb') - source.read() + with open('/proc/pressure/cpu', 'rb') as source: + source.read() pressuredir = os.path.join(bsdir, 'reduced_proc_pressure') bb.utils.mkdirhier(pressuredir) file_handlers.extend([('pressure/cpu', self._reduce_pressure), -- cgit v1.2.3-54-g00ecf