summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* build-appliance-image: Update to scarthgap head revisionyocto-5.0.2scarthgap-5.0.2Steve Sakoman2024-06-241-1/+1
| | | | | | (From OE-Core rev: 803cc32e72b4fc2fc28d92090e61f5dd288a10cb) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* poky.conf: bump version for 5.0.2Steve Sakoman2024-06-241-1/+1
| | | | | | (From meta-yocto rev: e0a218eaa794dddcc2e87e42652e191fcaf0b7bc) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* bitbake: fetch2/wget: Fix failure path for files that are empty or don't existRichard Purdie2024-06-241-9/+9
| | | | | | | | | | | | | | | When we intercepted the file download to a temp file, we broke the exist/size checks which need to happen before the rename. Correct the ordering. For some reason, python 3.12 exposes this problem in the selftests differently to previous versions. (Bitbake rev: 8714a02e13477a9d97858b3642e05f28247454b5) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit c56bd9a9280378bc64c6a7fe6d7b70847e0b9e6d) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* bitbake: tests/fetch: Tweak to work on Fedora40Richard Purdie2024-06-241-3/+3
| | | | | | | | | | | | | | On Fedora40, "localhost" sometimes resolves to ::1 and sometimes to 127.0.0.1 and python only binds to one of the addresses, leading to test failures. Use 127.0.0.1 explicitly to avoid problems of the name resolution, we're trying to test things other than the host networking. (Bitbake rev: 5fa596b3f2e49fbd144347b9800c76de72a29e28) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 9adc6da42618f41bf0d6b558d62b2f3c13bedd61) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* bitbake: fetch2/wget: Canonicalize DL_DIR paths for wget2 compatibilityRudolf J Streif2024-06-241-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some distributions (namely Fedora Core 40) have started replacing wget with wget2. There are some changes to wget2 that make it incompatible with wget: 1. ftp/ftps is not supported anymore 2. progress 'dot' is not yet supported 3. Relative paths in -P and -O are not correctly dealt with Item 1: Is already dealt with since Scarthgap by only adding the option --passive-ftp when the URL specifies ftp/sftp. While that won't help if ftp/sftp is actually required it at least does not break http/https downloads. Item 2: While not supported it at least does not break the operation. Item 3: If there are relative path components in -P or -O then wget2 only deals with them correctly if there is one, and only one, relative path component at the beginning of the path: -P ./downloads works -P ../downloads works -P ../../downloads does not work -P ./../downloads does not work -P /home/user/downloads/../downloads does not work In cases where there are more than one relative path component at the beginning of the path and/or one or more reltaive path component somewhere in the middle or end of the path, wget2 aborts with the message Internal error: Unexpected relative path: '<path>') Such can happen if DL_DIR includes relative path components e.g. DL_DIR = "${TOPDIR}/../../downloads". This patch canonicalizes DL_DIR before it is passed to wget. (Bitbake rev: 47678142e26bb76d1351886060deff5e75039bc9) Signed-off-by: Rudolf J Streif <rudolf.streif@ibeeto.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 3e4208952b086adc510e78c1c5f9cf4550d79dc9) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* cups: Upgrade 2.4.7 -> 2.4.9Siddharth Doshi2024-06-201-1/+1
| | | | | | | | | | | | | | CVE's Fixed by upgrade: CVE-2024-35235 cups: Cupsd Listen arbitrary chmod 0140777 Other Changes between 2.4.7 -> 2.4.9 ==================================== https://github.com/OpenPrinting/cups/blob/2.4.x/CHANGES.md (From OE-Core rev: fea7f804f916d0c6c86823fc8dce6463c425532d) Signed-off-by: Siddharth Doshi <sdoshi@mvista.com> Signed-off-by: Steve Sakoman <steve@sakoman.com>
* db: ignore implicit-int and implicit-function-declaration issues fatal with ↵Martin Jansa2024-06-201-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gcc-14 * many configure tests (which might not fail before) are failing with gcc-14: # grep implicit build/config.log conftest.c:47:1: error: return type defaults to 'int' [-Wimplicit-int] conftest.c:47:1: error: return type defaults to 'int' [-Wimplicit-int] conftest.c:47:1: error: return type defaults to 'int' [-Wimplicit-int] conftest.c:47:1: error: return type defaults to 'int' [-Wimplicit-int] conftest.c:47:1: error: return type defaults to 'int' [-Wimplicit-int] conftest.c:47:1: error: return type defaults to 'int' [-Wimplicit-int] conftest.c:50:17: error: implicit declaration of function 'exit' [-Wimplicit-function-declaration] conftest.c:50:17: warning: incompatible implicit declaration of built-in function 'exit' [-Wbuiltin-declaration-mismatch] conftest.c:53:9: error: implicit declaration of function 'msem_init' [-Wimplicit-function-declaration] conftest.c:54:9: error: implicit declaration of function 'msem_lock' [-Wimplicit-function-declaration] conftest.c:55:9: error: implicit declaration of function 'msem_unlock' [-Wimplicit-function-declaration] conftest.c:56:9: error: implicit declaration of function 'exit' [-Wimplicit-function-declaration] conftest.c:56:9: warning: incompatible implicit declaration of built-in function 'exit' [-Wbuiltin-declaration-mismatch] conftest.c:50:9: error: implicit declaration of function '_spin_lock_try' [-Wimplicit-function-declaration] conftest.c:51:9: error: implicit declaration of function '_spin_unlock' [-Wimplicit-function-declaration] * I have noticed this on db-native build on host with gcc-14 where it caused fatal do_configure error: http://errors.yoctoproject.org/Errors/Details/784164/ checking for mutexes... UNIX/fcntl configure: error: Support for FCNTL mutexes was removed in BDB 4.8. the config.log confirms it's because implicit-int: configure:22798: checking for mutexes configure:22925: gcc -o conftest -isystem/OE/build/oe-core/tmp-glibc/work/x86_64-linux/db-native/5.3.28/recipe-sysroot-native/usr/include -O2 -pipe -isystem/OE/build/oe-core/tmp-glibc/work/x86_64-linux/db-native/5.3.28/recipe-sysroot-native/usr/include -D_GNU_SOURCE -D_REENTRANT -L/OE/build/oe-core/tmp-glibc/work/x86_64-linux/db-native/5.3.28/recipe-sysroot-native/usr/lib -L/OE/build/oe-core/tmp-glibc/work/x86_64-linux/db-native/5.3.28/recipe-sysroot-native/lib -Wl,--enable-new-dtags -Wl,-rpath-link,/OE/build/oe-core/tmp-glibc/work/x86_64-linux/db-native/5.3.28/recipe-sysroot-native/usr/lib -Wl,-rpath-link,/OE/build/oe-core/tmp-glibc/work/x86_64-linux/db-native/5.3.28/recipe-sysroot-native/lib -Wl,-rpath,/OE/build/oe-core/tmp-glibc/work/x86_64-linux/db-native/5.3.28/recipe-sysroot-native/usr/lib -Wl,-rpath,/OE/build/oe-core/tmp-glibc/work/x86_64-linux/db-native/5.3.28/recipe-sysroot-native/lib -Wl,-O1 conftest.c -lpthread >&5 conftest.c:47:1: error: return type defaults to 'int' [-Wimplicit-int] 47 | main() { | ^~~~ configure:22925: $? = 1 configure: program exited with status 1 * comparing target db with and without this change shows following diff in log.do_configure: db $ diff 5.3.28*/temp/log.do_configure 268c268 < checking for mutexes... POSIX/pthreads/library --- > checking for mutexes... POSIX/pthreads/library/x86_64/gcc-assembly 271c271 < checking for atomic operations... no --- > checking for atomic operations... x86/gcc-assembly (From OE-Core rev: 4d3ce333c10fadf746b6d8b55a88777c97e11ffa) Signed-off-by: Martin Jansa <martin.jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 6108da955e7c553247ff5356cf1c990b3d334edf) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* kexec-tools: Fix build with GCC-14 on muslKhem Raj2024-06-202-0/+55
| | | | | | | | | | (From OE-Core rev: 30e226d48ae04e387d53fbde1b729569ae35bad5) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 704f51f72c301bd081a635dbe94e52aa97ffb827) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* cdrtools-native: fix build with gcc-14Martin Jansa2024-06-201-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: http://errors.yoctoproject.org/Errors/Details/770525/ | checking whether the C compiler (gcc -isystem/OE/build/oe-core/tmp-glibc/work/x86_64-linux/cdrtools-native/3.01/recipe-sysroot-native/usr/include -O2 -pipe ) works... no | configure: error: installation or configuration problem: C compiler cannot create executables. | RULES/rules.cnf:70: incs/amd-ryzen-threadripper-3970x-32-core-processor-linux-cc/rules.cnf: No such file or directory | make: *** [RULES/rules.cnf:59: incs/amd-ryzen-threadripper-3970x-32-core-processor-linux-cc/rules.cnf] Error 1 | make: *** Waiting for unfinished jobs.... where config.log show it's caused by gcc-14: configure:1189: checking whether the C compiler (gcc -isystem/OE/build/oe-core/tmp-glibc/work/x86_64-linux/cdrtools-native/3.01/recipe-sysroot-native/usr/include -O2 -pipe ) works configure:1211: gcc -o conftest -isystem/OE/build/oe-core/tmp-glibc/work/x86_64-linux/cdrtools-native/3.01/recipe-sysroot-native/usr/include -O2 -pipe -D_GNU_SOURCE conftest.c 1>&5 configure:1208:1: error: return type defaults to 'int' [-Wimplicit-int] configure: failed program was: main(){return(0);} (From OE-Core rev: 2297334257e102f33a6ef8c116896e159d35e1b6) Signed-off-by: Martin Jansa <martin.jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 094273bd7d1768e14fbdcd2f239bee14c630a625) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* zip: Fix build with gcc-14Khem Raj2024-06-203-36/+46
| | | | | | | | | | | | | | | | | | | | | | zip's configure fails to link this piece of test code: int main() { return closedir(opendir(".")); } with GCC-14 because it now treats implicit declaration of function as error, unline older GCC version where it was just a warning and this test would build fine. Remove 0002-unix.c-Do-not-redefine-DIR-as-FILE.patch which is now unnecessary. (From OE-Core rev: 82d58f8bf63d6af80b5a4ad03d5121f1541ae15d) Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 3422411eb750c7e960b81676637cfb321dbadefb) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* iproute2: Fix build with GCC-14Khem Raj2024-06-201-0/+2
| | | | | | | | | | (From OE-Core rev: 06b5a2db1d079c86652534b6fc7e504f77604af4) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 127df0ac9b55fa2a7f3269934854f805843d01cc) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* ltp: Fix build with GCC-14Khem Raj2024-06-202-0/+55
| | | | | | | | | | (From OE-Core rev: 42c5a8d52f6f01ebf6fd441e5cf7fd2cd771cfd4) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 5d3bea7f817aee6eb053eccc22f5c35f8a3d3668) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* lrzsz connman-gnome libfm: ignore various issues fatal with gcc-14Martin Jansa2024-06-203-0/+14
| | | | | | | | | | | | | | | | | | | | | | work arounds for: oe-core/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb:do_compile oe-core/meta/recipes-connectivity/connman/connman-gnome_0.7.bb:do_compile oe-core/meta/recipes-support/libfm/libfm_1.3.2.bb:do_compile http://errors.yoctoproject.org/Errors/Build/183127/ More fixes on ML (especially for -native with gcc-14 on host) cdrtools: https://lists.openembedded.org/g/openembedded-core/message/198899 syslinux: https://lists.openembedded.org/g/openembedded-core/message/198901 (From OE-Core rev: 924dc9bd3b1b21a60ebb117b0abf81d2650aedd0) Signed-off-by: Martin Jansa <martin.jansa@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 856ffc7d0893c1dc549baf401899947f70d31896) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* gtk4: Disable int-conversion warning as errorKhem Raj2024-06-201-0/+4
| | | | | | | | | | | | | This helps builds on 32bit machines when using GCC-14 there is a bug filed for fixing this in code [1] [1] https://gitlab.gnome.org/GNOME/gtk/-/issues/6033 (From OE-Core rev: 67e5be967e9d10ed295e9ca4cbfdf759f33e143f) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 3735b5566c7e0e1a36171523e7b553497f4da1a4) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* consolekit: Disable incompatible-pointer-types warning as errorKhem Raj2024-06-201-0/+3
| | | | | | | | | | | Fixes build with gcc-14 (From OE-Core rev: 9199d64629e8d27736c7f1e73cd9e95e8f04158b) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit d4fb4007cbaf545e023b0cb55b80fb5c70cf5b57) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* kea: Remove -fvisibility-inlines-hidden from C++ flagsKhem Raj2024-06-201-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes build with gcc-14, where default visibility is extended to inline functions and getAll() function now falls into this category and functions are marked hidden resulting in linking errors Fixes /OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/kea/2.5.8/recipe-sysroot-native/usr/bin/x86_64-oe-linux/../../libexec/x86_64-oe-linux/gcc/x86_64-oe-linux/14.0.1/ld: ./.libs/libdhcp4.a(dhcp4_srv.o): in function `isc::dhcp::Dhcpv4Srv::appendRequestedVendorOptions(isc::dhcp::Dhcpv4Exchange&)': /usr/src/debug/kea/2.5.8/src/bin/dhcp4/dhcp4_srv.cc:2356:(.text+0xaac2): undefined reference to `isc::dhcp::CfgOption::getAll(unsigned int) const' /OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/kea/2.5.8/recipe-sysroot-native/usr/bin/x86_64-oe-linux/../../libexec/x86_64-oe-linux/gcc/x86_64-oe-linux/14.0.1/ld: ./.libs/libdhcp4.a(dhcp4_srv.o): in function `isc::dhcp::OptionDescriptor isc::dhcp::CfgOption::get<unsigned int>(unsigned int const&, unsigned short) const': /usr/src/debug/kea/2.5.8/src/lib/dhcpsrv/cfg_option.h:609:(.text+0xb288): undefined reference to `isc::dhcp::CfgOption::getAll(unsigned int) const' /OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/kea/2.5.8/recipe-sysroot-native/usr/bin/x86_64-oe-linux/../../libexec/x86_64-oe-linux/gcc/x86_64-oe-linux/14.0.1/ld: ./.libs/libdhcp4.a(dhcp4_srv.o): in function `isc::dhcp::Dhcpv4Srv::appendRequestedOptions(isc::dhcp::Dhcpv4Exchange&)': /usr/src/debug/kea/2.5.8/src/bin/dhcp4/dhcp4_srv.cc:2128:(.text+0xc556): undefined reference to `isc::dhcp::CfgOption::getAll(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const' /OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/kea/2.5.8/recipe-sysroot-native/usr/bin/x86_64-oe-linux/../../libexec/x86_64-oe-linux/gcc/x86_64-oe-linux/14.0.1/ld: ./.libs/libdhcp4.a(dhcp4_srv.o): in function `std::vector<isc::dhcp::OptionDescriptor, std::allocator<isc::dhcp::OptionDescriptor> > isc::dhcp::CfgOption::getList<char [6]>(char const (&) [6], unsigned short) const': /usr/src/debug/kea/2.5.8/src/lib/dhcpsrv/cfg_option.h:641:(.text._ZNK3isc4dhcp9CfgOption7getListIA6_cEESt6vectorINS0_16OptionDescriptorESaIS5_EERKT_t[_ZNK3isc4dhcp9CfgOption7getListIA6_cEESt6vectorINS0_16OptionDescriptorESaIS5_EERKT_t]+0x86): undefined reference to `isc::dhcp::CfgOption::getAll(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const' /OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/kea/2.5.8/recipe-sysroot-native/usr/bin/x86_64-oe-linux/../../libexec/x86_64-oe-linux/gcc/x86_64-oe-linux/14.0.1/ld: ./.libs/libdhcp4.a(dhcp4_srv.o): in function `isc::dhcp::OptionDescriptor isc::dhcp::CfgOption::get<char [6]>(char const (&) [6], unsigned short) const': /usr/src/debug/kea/2.5.8/src/lib/dhcpsrv/cfg_option.h:609:(.text._ZNK3isc4dhcp9CfgOption3getIA6_cEENS0_16OptionDescriptorERKT_t[_ZNK3isc4dhcp9CfgOption3getIA6_cEENS0_16OptionDescriptorERKT_t]+0x77): undefined reference to `isc::dhcp::CfgOption::getAll(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const' collect2: error: ld returned 1 exit status make[5]: *** [Makefile:651: kea-dhcp4] Error 1 (From OE-Core rev: a68a3d40bf9226158d2c6433d3124be82eb02c63) Signed-off-by: Khem Raj <raj.khem@gmail.com> Cc: Martin Jansa <martin.jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 584940c2f3234bfaf579429e162e683934e86538) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* p11-kit: ignore various issues fatal with gcc-14 (for 32bit MACHINEs)Martin Jansa2024-06-201-0/+10
| | | | | | | | | | | | | | | * these are reproducible only with 32bit MACHINEs and probably related to time64.inc * http://errors.yoctoproject.org/Errors/Build/183154/ (From OE-Core rev: 10d2ba3bf2328d74edfbf6624f4f4ac52b3e9655) Signed-off-by: Martin Jansa <martin.jansa@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit fa2b8a494e641faab095487af90c5b78d9e33868) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* libunwind: ignore various issues now fatal with gcc-14Martin Jansa2024-06-201-0/+8
| | | | | | | | | | | http://gecko.lge.com:8000/Errors/Details/821679 (From OE-Core rev: dface38338ccaa45b2d1202e62adc87d99c3fb49) Signed-off-by: Martin Jansa <martin.jansa@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 20b9e9980c6675906ed154df968008f8c9140a9c) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* expect: ignore various issues now fatal with gcc-14Martin Jansa2024-06-201-0/+4
| | | | | | | | | | (From OE-Core rev: 454c48eac61f8e690b148e1c598aeb25912b1ec9) Signed-off-by: Martin Jansa <martin.jansa@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 83e9790fe27c310a4f5a66fedb29b232d23a22e5) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* appstream: upgrade 1.0.2 -> 1.0.3Wang Mingyu2024-06-201-1/+1
| | | | | | | | | | | | | | | | | | | Changelog: =========== * qt: Fix relocation of Config.cmake files * cli: check-syscompat: Recognize available required controls as available * validator: Guard issue emission functions with G_GNUC_PRINTF * validator: Always use secure string formatting for issue emit function * utils: Explicitly set format style when installing catalog metadata * Suppress static-analyzer drawing wrong conclusions on GCC 14 (From OE-Core rev: c2315a8879070b514870ded07cc2a49c0616a8c7) Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit be566cf0fecba34f1f792cbf060143be710970ee) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* cdrtools-native: Fix build with GCC 14Zoltan Boszormenyi2024-06-202-1/+18
| | | | | | | | | | | | | Add a patch to fix do_configure with GCC 14. Disable building cdda2wav because it doesn't build with GCC 14. (From OE-Core rev: 748d5f637f5aff3bc110b156cc3cb8e008f284c9) Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 0fbe1766abb00edeb8ec9a0c8bdb4e723be4f352) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* gawk: fix readline detectionRoss Burton2024-06-202-0/+39
| | | | | | | | | | | | | | The code fragment used to detect readline in cross builds doesn't compile cleanly with GCC 14.1, so readline is never enabled. Add missing includes so the test works, and readline can be enabled. (From OE-Core rev: b97aa1c3488b8f6aeb8e25f4ce810babc46a3ce5) Signed-off-by: Ross Burton <ross.burton@arm.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit a6e7c3ce700b82c57f1102187fea6b387339eca3) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* gcc-runtime: libgomp fix for gcc 14 warnings with mandb selftestRichard Purdie2024-06-201-1/+1
| | | | | | | | | | | | | ERROR: gcc-runtime-14.1.0-r0 do_package: QA Issue: gcc-runtime: Files/directories were installed but not shipped in any package: /usr/share/info /usr/share/info/libgomp.info-2 /usr/share/info/libgomp.info-1 (From OE-Core rev: 276ca15f21321dd406b30acd87d64237f707d615) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 4f73ddd6c276dcd579d2113db1974d446dbf7751) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* oeqa/sdk/assimp: Upgrade and fix for gcc 14Richard Purdie2024-06-201-4/+4
| | | | | | | | | | | To enable this test to work with gcc 14, pass the option to make warnings non-fatal. Also upgrade to version 5.4.1 from 5.3.1. (From OE-Core rev: c0c58c9acbcbed26f95864dc5e40b5995252ce4a) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit c3df6287ae26dc9d7f11eb7e26fdbcaefe4dfead) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* oeqa/sdkext/devtool: replace use of librdfaRoss Burton2024-06-201-4/+3
| | | | | | | | | | | | | librdfa hasn't had a commit for a decade now and as such has problems with modern compilers (specifically gcc 14.1). Switch the recipe creation test to something much simpler that we also control: dbus-wait. (From OE-Core rev: 311e7b5b9ee4f0d96a376a06f01c5bfd379ca244) Signed-off-by: Ross Burton <ross.burton@arm.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit d801de1f702d8d0def55011b5b6ad39d85f978f1) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* yocto-uninative: Update to 4.5 for gcc 14Michael Halstead2024-06-201-4/+4
| | | | | | | | | (From OE-Core rev: 335d11ad2dd4207e5927f1938c449547a3a2975b) Signed-off-by: Michael Halstead <mhalstead@linuxfoundation.org> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit f5638681cef7e250ac64832dbe791418d97f05ba) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* cracklib: Modify patch to compile with GCC 14Zoltan Boszormenyi2024-06-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | GCC 14 implicitly turns a warning into a compiler error: | ../../git/src/lib/packlib.c: In function ‘PWClose’: | ../../git/src/lib/packlib.c:554:40: error: passing argument 1 of ‘HwmsHostToBigEndian’ from incompatible pointer type [-Wincompatible-pointer-types] | 554 | HwmsHostToBigEndian(tmp_pwp.hwms, sizeof(tmp_pwp.hwms), en_is32); | | ~~~~~~~^~~~~ | | | | | uint32_t * {aka unsigned int *} | ../../git/src/lib/packlib.c:142:27: note: expected ‘char *’ but argument is of type ‘uint32_t *’ {aka ‘unsigned int *’} | 142 | HwmsHostToBigEndian(char *pHwms, int nLen,int nBitType) | | ~~~~~~^~~~~ Add the cast to (char *) to silence it. (From OE-Core rev: 50b9126cd8668d8c039e9bd61eaba458f7a22014) Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 914128f6bd988cde278e087fb9457a0c70c7e5ec) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* Revert "oeqa/selftest/devtool: fix test_devtool_add_git_style2"Alexandre Truong2024-06-191-1/+1
| | | | | | | | | | | | | | | | | | This reverts commit ab6d3e3d645ffc343f434bf731339fa237df027a from poky repository. The previous reverted commit was a workaround. The fix "oeqa/selftest/devtool: fix _test_devtool_add_git_url" tackle the issue. So, the workaround is not needed anymore. (From OE-Core rev: fd30cc2ab99fe6a8e4beb29d9cb46a772db8b8d8) Signed-off-by: Alexandre Truong <alexandre.truong@smile.fr> Reviewed-by: Yoann Congal <yoann.congal@smile.fr> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 731f47ecfd8ad6558aac629806810789c623986b) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* oeqa/selftest/devtool: fix _test_devtool_add_git_urlAlexandre Truong2024-06-191-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch is a follow-up to the bug#15466. As a reminder, the bug was about devtool’s submodule detection checking for HEAD when a version is being passed. As Vincent Kriek pointed out: the --version that is being passed to devtool is only used for setting the PV value in the recipe. To take into account the tag, we add --srcrev to the command: devtool add --srcrev v3.1.0 --version v3.1.0 mbedtls git://git@github.com/ARMmbed/mbedtls.git;protocol=https Changes to _test_devtool_add_git_url have been made to take into account the srcrev. srcrev will be passed as an optional parameter because the test_devtool_add_git_style1 does not need the srcrev contrary to test_devtool_add_git_style2 Fixes [YOCTO #15466] (From OE-Core rev: c297b78454da2a668e62dec95d7b6eb6e5429480) Signed-off-by: Alexandre Truong <alexandre.truong@smile.fr> Reported-by: Alexandre Truong <alexandre.truong@smile.fr> Suggested-by: Vincent Kriek <vincent@coelebs.dev> Reviewed-by: Yoann Congal <yoann.congal@smile.fr> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit a8686f3641e4407dee3d807898ffd620e2732b78) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* libinput: fix building with debug-gui optionMarc Ferland2024-06-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | When building libinput with the 'gui' PACKAGECONFIG option, it fails with: | Run-time dependency x11 found: YES 1.8.9 | Run-time dependency wayland-client found: YES 1.22.0 | Run-time dependency wayland-protocols found: YES 1.34 | Program wayland-scanner found: NO | | ../git/meson.build:578:20: ERROR: Program 'wayland-scanner' not found or not executable | | A full log can be found at /home/marc/mnt/yocto-latest/build/tmp/work/core2-64-poky-linux/libinput/1.25.0/build/meson-logs/meson-log.txt | ERROR: meson failed | WARNING: exit code 1 from a shell command. Adding a build dependency on wayland-native fixes the issue. (From OE-Core rev: 71e49dcac0be026d12140598850e2cd38d702317) Signed-off-by: Marc Ferland <marc.ferland@sonatest.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 0e2d18e6267d26870ccbe45734bfccbc02744357) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* ltp: add iputils-ping6 to RDEPENDSXiangyu Chen2024-06-191-0/+1
| | | | | | | | | | | | | | | | | | According to the LTP documents[1], it using ping6 from iputils which support "-I" option to bind the interface[2]. Ref: [1] https://github.com/linux-test-project/ltp/commit/6f97789c [2] https://github.com/linux-test-project/ltp/commit/64b11656 (From OE-Core rev: bd2b32437787245029ca393f3e46542f0900b3fb) Signed-off-by: Xiangyu Chen <xiangyu.chen@windriver.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 05107ec5e4b81315d53efef23f2a570d520ee4c7) Signed-off-by: Bin Lan <bin.lan.cn@windriver.com> Signed-off-by: Steve Sakoman <steve@sakoman.com>
* iputils: splitting the ping6 as a packageXiangyu Chen2024-06-191-1/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | The iputils merged the ping4 and ping6 command into the ping since the commit ebad35fe[1], currently, iputils ping support being called using "ping -6" or "ping6" symlinks. In oe-core, there are two packages provide ipv6 ping, inetutils and iputils, the inetutils-ping6 doesn't support "-I" option to bind the interface, that cause some of scripts(e.g. LTP test[2]) which was based on iputils-ping6 fails. If someone or a package needs iputils-ping6, they can enable it in local.conf or add it into rdepends directly. Ref: [1] https://github.com/iputils/iputils/commit/e3de851b809c7b72ccc654a72b6af61d [2] https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/ \ containers/netns/netns_comm.sh#L25 (From OE-Core rev: 964bdb0f8877a229ea34ab1d95dc5dabc564af51) Signed-off-by: Xiangyu Chen <xiangyu.chen@windriver.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> (cherry picked from commit 0b89bc2041f670af625829d061ce79e0840ac116) Signed-off-by: Bin Lan <bin.lan.cn@windriver.com> Signed-off-by: Steve Sakoman <steve@sakoman.com>
* kernel.bbclass: check, if directory exists before removing empty module ↵Heiko2024-06-191-1/+1
| | | | | | | | | | | | | | | | | directory If the kernel folder does not exist, find will result in an error. This can occur if the kernel has no modules but, for example, custom modules are created. Add check before deleting. (From OE-Core rev: 63856721cab409ae0598cfbff4fcf55c90bfd7e7) Signed-off-by: Heiko Thole <heiko.thole@entwicklung.eq-3.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 7ef767d84d56b25498e45db83bb8f9d9caebeaf9) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* iproute2: drop obsolete patchMaxin B. John2024-06-192-42/+1
| | | | | | | | | | | | | libc-compat.h fix for musl was obsolete after 4.16.0 release of iproute2. Drop it. (From OE-Core rev: 2e3588ce3f0f14e6e0e6d2f4b6d8a52b68309394) Signed-off-by: Maxin John <maxin.john@gmail.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit ad57a1e124a1de7af7ef8479ed779230e923d3af) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* ppp: Add RSA-MD in LICENSEPoonam Jadhav2024-06-191-1/+1
| | | | | | | | | | | | | | ppp package has "RSA Data Security" license text in Message-Digest Algorithm source file ppp-md5.c and ppp-md4.c Add RSA-MD in LICENSE field for ppp package (From OE-Core rev: 5feddad534ecf97279dfe5ec076aa3ed2eec6456) Signed-off-by: Poonam Jadhav <poonam.jadhav@kpit.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 9c58193c898b0ea28c3931a57dca5bb829a44051) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* icu: add upstream submission links for fix-install-manx.patchAlexander Kanavin2024-06-191-1/+3
| | | | | | | | | (From OE-Core rev: bebafda283f4ecf63994dfcc334e3bd0ac875e7e) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 269a1a65d2526be5622b4c1f552b6f5541e0cb86) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* bash: mark build-tests.patch as InappropriateAlexander Kanavin2024-06-191-1/+1
| | | | | | | | | (From OE-Core rev: e796f05f243ac981082c63f816ce2e5e715bd347) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 3d82d44ed6822b7a276df355311e384c02d36c43) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* xinput-calibrator: mark upstream as inactive in a patchAlexander Kanavin2024-06-191-1/+1
| | | | | | | | | (From OE-Core rev: 58eed3438981e594daa076193e6af0f9e0cad014) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 959591615d18f636768671e1e14e5945a6cbb010) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* busybox: submit CVE-2022-28391 patches upstreamAlexander Kanavin2024-06-192-2/+2
| | | | | | | | | (From OE-Core rev: f3e6d0dc315dc915d8029a0d84a12f74ca5d62f5) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 64c026024b1c86797de338760b9f29d7e949926c) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* apr: submit 0001-Add-option-to-disable-timed-dependant-tests.patch upstreamAlexander Kanavin2024-06-191-1/+1
| | | | | | | | | (From OE-Core rev: 66fcd7e61607c2eaed58abfdff5a3197b5b564e6) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 1bfe386e69d7a688815a78bd2d5766a4b0665e7f) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* expect: mark patches as Inactive-UpstreamAlexander Kanavin2024-06-195-5/+5
| | | | | | | | | | | | There's every indication that this is an ex-expect: last release in 2018, stale tickets, cvs server gone. (From OE-Core rev: 84a8ed08e474427bf4a6b3a0026807a1bcabd417) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 0fcfd2cb51428a3f35c0f78634bff0a16ae654e9) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* kea: remove unnecessary reproducibility patchAlexander Kanavin2024-06-192-64/+1
| | | | | | | | | | | Rather, adjust the sed invocation to do the correct thing directly. (From OE-Core rev: a57f48c3bb37d5154ea2ef821525aa8706f9cb37) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 804afb2eb9cc2b5650faa80816f377fa5b72fb38) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* serf: mark patch as inappropriate for upstream submissionAlexander Kanavin2024-06-191-1/+1
| | | | | | | | | | | | | | | | What the patch does is not suitable, as upstream would surely want the issue with the code fixed, not removal of that code altogether. I'd also note that serf is still semi-ummaintained, and the only consumer of it is subversion, which is slowly but steadily fading away in favor of git and artifact-specific solutions. (From OE-Core rev: 07e14e259e5354c6465953189854229a0ea42e66) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 634717817e94740ac8d4e8cc82cb68bfd15d8dbd) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* devtool: sync: Fix Execution errorVincent Kriek2024-06-191-1/+12
| | | | | | | | | | | | | | | | | | | | | | When executing devtool sync on a recipe that was extract with devtool extract earlier the following error occured: Traceback (most recent call last): [...] bb.process.ExecutionError: Execution of 'git fetch file:///home/vin/projects/poky/build/tmp/work/all-poky-linux/netbase/6.4/devtooltmp-figt1jmr/workdir/netbase devtool:devtool' failed with exit code 128: fatal: refusing to fetch into branch 'refs/heads/devtool' checked out at '/home/vin/projects/poky/build/netbase-src' Fix this by adding --update-head-ok and --force to git fetch so it will override the current head even if it is checked out and has changes. Possible existing changes in the devtool branch can be retrieved by checking out the devtool.bak branch (From OE-Core rev: ee712c8b3c32fedd6af0521d2e34ea655f8cd5ca) Signed-off-by: Vincent Kriek <vincent@coelebs.dev> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> (cherry picked from commit 4c89b061003a0f4143c6d3838e39fc2643edc8d6) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* libtraceevent: submit meson.patch upstreamAlexander Kanavin2024-06-191-1/+1
| | | | | | | | | | [RP: Add url to submission] (From OE-Core rev: fdb1a67fa3891f40f038c393e907b4e30161b4b5) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit d00306620aa890a361f42516a064d64dd7c68aa7) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* oeqa: selftest: context: run tests serially if testtools/subunit modules are ↵Julien Stephan2024-06-191-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | not found If testtools and/or subunit modules are not found we get the following backtrace (example for testtools): NOTE: Starting bitbake server... Traceback (most recent call last): File "<..>/poky/scripts/oe-selftest", line 60, in <module> ret = main() File "<..>/poky/scripts/oe-selftest", line 47, in main results = args.func(logger, args) File "<..>/poky/meta/lib/oeqa/selftest/context.py", line 391, in run rc = self._internal_run(logger, args) File "<..>/poky/meta/lib/oeqa/selftest/context.py", line 377, in _internal_run rc = self.tc.runTests(**self.tc_kwargs['run']) File "<..>/poky/meta/lib/oeqa/selftest/context.py", line 161, in runTests return super(OESelftestTestContext, self).runTests(processes, skips) File "<..>/poky/meta/lib/oeqa/core/context.py", line 91, in runTests result = self.runner.run(self.prepareSuite(self.suites, processes)) File "<..>/poky/meta/lib/oeqa/selftest/context.py", line 154, in prepareSuite from oeqa.core.utils.concurrencytest import ConcurrentTestSuite File "<..>/poky/meta/lib/oeqa/core/utils/concurrencytest.py", line 22, in <module> import testtools ModuleNotFoundError: No module named 'testtools' Fix this by adding a custom callback on -j/--num-processes parameter to check testtools and subunit modules. Fallback to serial testing if missing. This strategy is already used in sdk/context.py (From OE-Core rev: ffd1db7d7813f6da22c0d9ef5fde6738058f1eb2) Signed-off-by: Julien Stephan <jstephan@baylibre.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> (cherry picked from commit 35284404473b2c2d9f69594582868ed66ef3525e) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* oeqa/postactions: Do not use -l option with dfKhem Raj2024-06-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | -l option is specific to df provided by coreutils, if df applet from busybox is used then it does not work and fails like below Fixes df: invalid option -- 'l' BusyBox v1.36.1 () multi-call binary. Usage: df [-PkmhT] [-t TYPE] [FILESYSTEM]... DEBUG: [Command returned '1' after 0.71 seconds] DEBUG: Command: df -hl Status: 1 Output: df: invalid option -- 'l' it seems worth a compromise to show remote mounted filesystems if any during ptests and it works with both df implementations (From OE-Core rev: 82a0df6cc2c5b18cb48fd8c3be26a11f4016d98d) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> (cherry picked from commit 75cc1ea4348a2294fdc5ab20530fcff27056ff06) Signed-off-by: Steve Sakoman <steve@sakoman.com>
* base-files: profile: fix error sh: 1: unknown operandFelix Nilsson2024-06-191-1/+1
| | | | | | | | | | | | Handle errors when SHLVL isn't set. (From OE-Core rev: 7ef2c9ab669785e5e073d6f925f1a3f447fc31d9) Signed-off-by: Felix Nilsson <felixn@axis.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 5df53fcfe3b70a5312fced3fcc1ba6290f2ee794) Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Steve Sakoman <steve@sakoman.com>
* oeqa/selftest/devtool: add test for modifying recipes using go.bbclassOla x Nilsson2024-06-191-0/+19
| | | | | | | | | | | | | | | | go.bbclass uses a special do_unpack function that causes the git root to be different from S. Verify that it unpacks as expected. [ YOCTO #15483 ] (From OE-Core rev: 71adf7c18215faf73454be79d7b51f2a0c338c0f) Signed-off-by: Ola x Nilsson <olani@axis.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit fab0c737b95b8d0c0bbf58336bc308776c956406) Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Steve Sakoman <steve@sakoman.com>
* devtool: modify: Catch git submodule error for go codeAnton Almqvist2024-06-191-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | One of the git submodule commands failed for source extracted for recipes using go.bbclass. The root cause is probably the path set up by go_do_unpack which makes S and gitroot not match. This patch does not fix the root problem, but at least it is no worse than before the git submodule support. The extracted source will still have two .git folders, one in S created by devtool and one in the go path which will contain the tru git history. [ YOCTO #15483 ] (From OE-Core rev: 1dc639353658496db5c5df802c0259e87fe2ca0f) Signed-off-by: Anton Almqvist <antonal@axis.com> Signed-off-by: Ola x Nilsson <olani@axis.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit fe242408af40dd1f6e47d9b2b232bdc76756c80a) Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Steve Sakoman <steve@sakoman.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2025-06-14 10:23:42 +0000