summaryrefslogtreecommitdiffstats
path: root/meta/recipes-support/sqlite/files/0001-This-branch-attempts-to-improve-the-detection-of-cov.patch
diff options
context:
space:
mode:
Diffstat (limited to 'meta/recipes-support/sqlite/files/0001-This-branch-attempts-to-improve-the-detection-of-cov.patch')
-rw-r--r--meta/recipes-support/sqlite/files/0001-This-branch-attempts-to-improve-the-detection-of-cov.patch91
1 files changed, 91 insertions, 0 deletions
diff --git a/meta/recipes-support/sqlite/files/0001-This-branch-attempts-to-improve-the-detection-of-cov.patch b/meta/recipes-support/sqlite/files/0001-This-branch-attempts-to-improve-the-detection-of-cov.patch
new file mode 100644
index 0000000000..8fb037bb0f
--- /dev/null
+++ b/meta/recipes-support/sqlite/files/0001-This-branch-attempts-to-improve-the-detection-of-cov.patch
@@ -0,0 +1,91 @@
1From f55a7dad195994f2bb24db7df0a0515502386fe2 Mon Sep 17 00:00:00 2001
2From: drh <>
3Date: Sat, 22 Oct 2022 14:16:02 +0000
4Subject: [PATCH] This branch attempts to improve the detection of covering
5 indexes. This first check-in merely improves a parameter name to
6 sqlite3WhereBegin() to be more descriptive of what it contains, and ensures
7 that a subroutine is not inlines so that sqlite3WhereBegin() runs slightly
8 faster.
9
10FossilOrigin-Name: cadf5f6bb1ce0492ef858ada476288e8057afd3609caa18b09c818d3845d7244
11
12Upstream-Status: Backport [https://github.com/sqlite/sqlite/commit/f55a7dad195994f2bb24db7df0a0515502386fe2]
13Signed-off-by: Peter Marko <peter.marko@siemens.com>
14---
15 sqlite3.c | 28 +++++++++++++---------------
16 1 file changed, 13 insertions(+), 15 deletions(-)
17
18diff --git a/sqlite3.c b/sqlite3.c
19index 4cbc2d0..b7ed991 100644
20--- a/sqlite3.c
21+++ b/sqlite3.c
22@@ -147371,9 +147371,7 @@ struct WhereInfo {
23 ExprList *pOrderBy; /* The ORDER BY clause or NULL */
24 ExprList *pResultSet; /* Result set of the query */
25 Expr *pWhere; /* The complete WHERE clause */
26-#ifndef SQLITE_OMIT_VIRTUALTABLE
27- Select *pLimit; /* Used to access LIMIT expr/registers for vtabs */
28-#endif
29+ Select *pSelect; /* The entire SELECT statement containing WHERE */
30 int aiCurOnePass[2]; /* OP_OpenWrite cursors for the ONEPASS opt */
31 int iContinue; /* Jump here to continue with next record */
32 int iBreak; /* Jump here to break out of the loop */
33@@ -149070,9 +149068,9 @@ SQLITE_PRIVATE Bitmask sqlite3WhereCodeOneLoopStart(
34 && pLoop->u.vtab.bOmitOffset
35 ){
36 assert( pTerm->eOperator==WO_AUX );
37- assert( pWInfo->pLimit!=0 );
38- assert( pWInfo->pLimit->iOffset>0 );
39- sqlite3VdbeAddOp2(v, OP_Integer, 0, pWInfo->pLimit->iOffset);
40+ assert( pWInfo->pSelect!=0 );
41+ assert( pWInfo->pSelect->iOffset>0 );
42+ sqlite3VdbeAddOp2(v, OP_Integer, 0, pWInfo->pSelect->iOffset);
43 VdbeComment((v,"Zero OFFSET counter"));
44 }
45 }
46@@ -151830,10 +151828,10 @@ static void whereAddLimitExpr(
47 ** exist only so that they may be passed to the xBestIndex method of the
48 ** single virtual table in the FROM clause of the SELECT.
49 */
50-SQLITE_PRIVATE void sqlite3WhereAddLimit(WhereClause *pWC, Select *p){
51- assert( p==0 || (p->pGroupBy==0 && (p->selFlags & SF_Aggregate)==0) );
52- if( (p && p->pLimit) /* 1 */
53- && (p->selFlags & (SF_Distinct|SF_Aggregate))==0 /* 2 */
54+SQLITE_PRIVATE void SQLITE_NOINLINE sqlite3WhereAddLimit(WhereClause *pWC, Select *p){
55+ assert( p!=0 && p->pLimit!=0 ); /* 1 -- checked by caller */
56+ assert( p->pGroupBy==0 && (p->selFlags & SF_Aggregate)==0 );
57+ if( (p->selFlags & (SF_Distinct|SF_Aggregate))==0 /* 2 */
58 && (p->pSrc->nSrc==1 && IsVirtual(p->pSrc->a[0].pTab)) /* 3 */
59 ){
60 ExprList *pOrderBy = p->pOrderBy;
61@@ -157427,7 +157425,7 @@ SQLITE_PRIVATE WhereInfo *sqlite3WhereBegin(
62 Expr *pWhere, /* The WHERE clause */
63 ExprList *pOrderBy, /* An ORDER BY (or GROUP BY) clause, or NULL */
64 ExprList *pResultSet, /* Query result set. Req'd for DISTINCT */
65- Select *pLimit, /* Use this LIMIT/OFFSET clause, if any */
66+ Select *pSelect, /* The entire SELECT statement */
67 u16 wctrlFlags, /* The WHERE_* flags defined in sqliteInt.h */
68 int iAuxArg /* If WHERE_OR_SUBCLAUSE is set, index cursor number
69 ** If WHERE_USE_LIMIT, then the limit amount */
70@@ -157504,9 +157502,7 @@ SQLITE_PRIVATE WhereInfo *sqlite3WhereBegin(
71 pWInfo->wctrlFlags = wctrlFlags;
72 pWInfo->iLimit = iAuxArg;
73 pWInfo->savedNQueryLoop = pParse->nQueryLoop;
74-#ifndef SQLITE_OMIT_VIRTUALTABLE
75- pWInfo->pLimit = pLimit;
76-#endif
77+ pWInfo->pSelect = pSelect;
78 memset(&pWInfo->nOBSat, 0,
79 offsetof(WhereInfo,sWC) - offsetof(WhereInfo,nOBSat));
80 memset(&pWInfo->a[0], 0, sizeof(WhereLoop)+nTabList*sizeof(WhereLevel));
81@@ -157575,7 +157571,9 @@ SQLITE_PRIVATE WhereInfo *sqlite3WhereBegin(
82
83 /* Analyze all of the subexpressions. */
84 sqlite3WhereExprAnalyze(pTabList, &pWInfo->sWC);
85- sqlite3WhereAddLimit(&pWInfo->sWC, pLimit);
86+ if( pSelect && pSelect->pLimit ){
87+ sqlite3WhereAddLimit(&pWInfo->sWC, pSelect);
88+ }
89 if( db->mallocFailed ) goto whereBeginError;
90
91 /* Special case: WHERE terms that do not refer to any tables in the join