diff options
| -rw-r--r-- | meta/recipes-devtools/qemu/qemu.inc | 2 | ||||
| -rw-r--r-- | meta/recipes-devtools/qemu/qemu/mmap.patch | 29 | ||||
| -rw-r--r-- | meta/recipes-devtools/qemu/qemu/mmap2.patch | 26 |
3 files changed, 57 insertions, 0 deletions
diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc index 286901fb1f..cfa65f99d0 100644 --- a/meta/recipes-devtools/qemu/qemu.inc +++ b/meta/recipes-devtools/qemu/qemu.inc | |||
| @@ -27,6 +27,8 @@ SRC_URI = "https://download.qemu.org/${BPN}-${PV}.tar.xz \ | |||
| 27 | file://0001-Add-enable-disable-udev.patch \ | 27 | file://0001-Add-enable-disable-udev.patch \ |
| 28 | file://0001-qemu-Do-not-include-file-if-not-exists.patch \ | 28 | file://0001-qemu-Do-not-include-file-if-not-exists.patch \ |
| 29 | file://mingwfix.patch \ | 29 | file://mingwfix.patch \ |
| 30 | file://mmap.patch \ | ||
| 31 | file://mmap2.patch \ | ||
| 30 | " | 32 | " |
| 31 | UPSTREAM_CHECK_REGEX = "qemu-(?P<pver>\d+(\.\d+)+)\.tar" | 33 | UPSTREAM_CHECK_REGEX = "qemu-(?P<pver>\d+(\.\d+)+)\.tar" |
| 32 | 34 | ||
diff --git a/meta/recipes-devtools/qemu/qemu/mmap.patch b/meta/recipes-devtools/qemu/qemu/mmap.patch new file mode 100644 index 0000000000..0f7d2ce04c --- /dev/null +++ b/meta/recipes-devtools/qemu/qemu/mmap.patch | |||
| @@ -0,0 +1,29 @@ | |||
| 1 | If mremap() is called without the MREMAP_MAYMOVE flag with a start address | ||
| 2 | just before the end of memory (reserved_va) where new_size would exceed | ||
| 3 | GUEST_ADD_MAX, the assert(end - 1 <= GUEST_ADDR_MAX) in page_set_flags() | ||
| 4 | would trigger. | ||
| 5 | |||
| 6 | Add an extra guard to the guest_range_valid() checks to prevent this and | ||
| 7 | avoid asserting binaries when reserved_va is set. | ||
| 8 | |||
| 9 | This meant a test case now gives the same behaviour regardless of whether | ||
| 10 | reserved_va is set or not. | ||
| 11 | |||
| 12 | Upstream-Status: Pending | ||
| 13 | Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org | ||
| 14 | |||
| 15 | Index: qemu-5.2.0/linux-user/mmap.c | ||
| 16 | =================================================================== | ||
| 17 | --- qemu-5.2.0.orig/linux-user/mmap.c | ||
| 18 | +++ qemu-5.2.0/linux-user/mmap.c | ||
| 19 | @@ -727,7 +727,9 @@ abi_long target_mremap(abi_ulong old_add | ||
| 20 | |||
| 21 | if (!guest_range_valid(old_addr, old_size) || | ||
| 22 | ((flags & MREMAP_FIXED) && | ||
| 23 | - !guest_range_valid(new_addr, new_size))) { | ||
| 24 | + !guest_range_valid(new_addr, new_size)) || | ||
| 25 | + ((flags & MREMAP_MAYMOVE) == 0 && | ||
| 26 | + !guest_range_valid(old_addr, new_size))) { | ||
| 27 | errno = ENOMEM; | ||
| 28 | return -1; | ||
| 29 | } | ||
diff --git a/meta/recipes-devtools/qemu/qemu/mmap2.patch b/meta/recipes-devtools/qemu/qemu/mmap2.patch new file mode 100644 index 0000000000..9d40565938 --- /dev/null +++ b/meta/recipes-devtools/qemu/qemu/mmap2.patch | |||
| @@ -0,0 +1,26 @@ | |||
| 1 | When using qemu-i386 to build qemux86 webkitgtk on musl, it sits in an | ||
| 2 | infinite loop of mremap calls of ever decreasing/increasing addresses. | ||
| 3 | |||
| 4 | I suspect something in the musl memory allocation code loops indefinitely | ||
| 5 | if it only sees ENOMEM and only exits when it hits EFAULT. | ||
| 6 | |||
| 7 | According to the docs, trying to mremap outside the address space | ||
| 8 | can/should return EFAULT and changing this allows the build to succeed. | ||
| 9 | Whether this should be fixed in qemu and/or musl, not sure. | ||
| 10 | |||
| 11 | Upstream-Status: Pending | ||
| 12 | Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org | ||
| 13 | |||
| 14 | Index: qemu-5.2.0/linux-user/mmap.c | ||
| 15 | =================================================================== | ||
| 16 | --- qemu-5.2.0.orig/linux-user/mmap.c | ||
| 17 | +++ qemu-5.2.0/linux-user/mmap.c | ||
| 18 | @@ -727,7 +727,7 @@ abi_long target_mremap(abi_ulong old_add | ||
| 19 | !guest_range_valid(new_addr, new_size)) || | ||
| 20 | ((flags & MREMAP_MAYMOVE) == 0 && | ||
| 21 | !guest_range_valid(old_addr, new_size))) { | ||
| 22 | - errno = ENOMEM; | ||
| 23 | + errno = EFAULT; | ||
| 24 | return -1; | ||
| 25 | } | ||
| 26 | |||
