summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--meta/recipes-support/libksba/libksba/0001-Fix-an-integer-overflow-in-the-CRL-signature-parser.patch72
-rw-r--r--meta/recipes-support/libksba/libksba_1.6.2.bb3
2 files changed, 1 insertions, 74 deletions
diff --git a/meta/recipes-support/libksba/libksba/0001-Fix-an-integer-overflow-in-the-CRL-signature-parser.patch b/meta/recipes-support/libksba/libksba/0001-Fix-an-integer-overflow-in-the-CRL-signature-parser.patch
deleted file mode 100644
index 8c0080d56b..0000000000
--- a/meta/recipes-support/libksba/libksba/0001-Fix-an-integer-overflow-in-the-CRL-signature-parser.patch
+++ /dev/null
@@ -1,72 +0,0 @@
1From f61a5ea4e0f6a80fd4b28ef0174bee77793cf070 Mon Sep 17 00:00:00 2001
2From: Werner Koch <wk@gnupg.org>
3Date: Tue, 22 Nov 2022 16:36:46 +0100
4Subject: [PATCH] Fix an integer overflow in the CRL signature parser.
5
6* src/crl.c (parse_signature): N+N2 now checked for overflow.
7
8* src/ocsp.c (parse_response_extensions): Do not accept too large
9values.
10(parse_single_extensions): Ditto.
11--
12
13The second patch is an extra safegourd not related to the reported
14bug.
15
16CVE: CVE-2022-47629
17
18Upstream-Status: Backport [https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libksba.git;a=commit;h=f61a5ea4e0f6a80fd4b28ef0174bee77793cf070]
19
20GnuPG-bug-id: 6284
21Reported-by: Joseph Surin, elttam
22---
23 src/crl.c | 2 +-
24 src/ocsp.c | 12 ++++++++++++
25 2 files changed, 13 insertions(+), 1 deletion(-)
26
27diff --git a/src/crl.c b/src/crl.c
28index 9f71c85..2e6ca29 100644
29--- a/src/crl.c
30+++ b/src/crl.c
31@@ -1349,7 +1349,7 @@ parse_signature (ksba_crl_t crl)
32 && !ti.is_constructed) )
33 return gpg_error (GPG_ERR_INV_CRL_OBJ);
34 n2 = ti.nhdr + ti.length;
35- if (n + n2 >= DIM(tmpbuf))
36+ if (n + n2 >= DIM(tmpbuf) || (n + n2) < n)
37 return gpg_error (GPG_ERR_TOO_LARGE);
38 memcpy (tmpbuf+n, ti.buf, ti.nhdr);
39 err = read_buffer (crl->reader, tmpbuf+n+ti.nhdr, ti.length);
40diff --git a/src/ocsp.c b/src/ocsp.c
41index d4cba04..657d15f 100644
42--- a/src/ocsp.c
43+++ b/src/ocsp.c
44@@ -721,6 +721,12 @@ parse_response_extensions (ksba_ocsp_t ocsp,
45 || memcmp (ocsp->nonce, data, ti.length))
46 ocsp->bad_nonce = 1;
47 }
48+ if (ti.length > (1<<24))
49+ {
50+ /* Bail out on much too large objects. */
51+ err = gpg_error (GPG_ERR_BAD_BER);
52+ goto leave;
53+ }
54 ex = xtrymalloc (sizeof *ex + strlen (oid) + ti.length);
55 if (!ex)
56 {
57@@ -788,6 +794,12 @@ parse_single_extensions (struct ocsp_reqitem_s *ri,
58 err = parse_octet_string (&data, &datalen, &ti);
59 if (err)
60 goto leave;
61+ if (ti.length > (1<<24))
62+ {
63+ /* Bail out on much too large objects. */
64+ err = gpg_error (GPG_ERR_BAD_BER);
65+ goto leave;
66+ }
67 ex = xtrymalloc (sizeof *ex + strlen (oid) + ti.length);
68 if (!ex)
69 {
70--
712.32.0
72
diff --git a/meta/recipes-support/libksba/libksba_1.6.2.bb b/meta/recipes-support/libksba/libksba_1.6.2.bb
index d0ee8475f8..f6ecb9aec4 100644
--- a/meta/recipes-support/libksba/libksba_1.6.2.bb
+++ b/meta/recipes-support/libksba/libksba_1.6.2.bb
@@ -22,8 +22,7 @@ inherit autotools binconfig-disabled pkgconfig texinfo
22 22
23UPSTREAM_CHECK_URI = "https://gnupg.org/download/index.html" 23UPSTREAM_CHECK_URI = "https://gnupg.org/download/index.html"
24SRC_URI = "${GNUPG_MIRROR}/${BPN}/${BPN}-${PV}.tar.bz2 \ 24SRC_URI = "${GNUPG_MIRROR}/${BPN}/${BPN}-${PV}.tar.bz2 \
25 file://ksba-add-pkgconfig-support.patch \ 25 file://ksba-add-pkgconfig-support.patch"
26 file://0001-Fix-an-integer-overflow-in-the-CRL-signature-parser.patch"
27 26
28SRC_URI[sha256sum] = "fce01ccac59812bddadffacff017dac2e4762bdb6ebc6ffe06f6ed4f6192c971" 27SRC_URI[sha256sum] = "fce01ccac59812bddadffacff017dac2e4762bdb6ebc6ffe06f6ed4f6192c971"
29 28