diff options
| author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2015-11-11 08:50:02 -0800 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2015-11-16 14:59:18 +0000 |
| commit | d9aabf9639510fdb3e2ccc21ba5ae4aa9f6e4a57 (patch) | |
| tree | ecd46c579d347fa45d22cc0fc6aaa2904d41b6a8 /meta/recipes-devtools/gcc/gcc-4.8/0047-repomembug.patch | |
| parent | 2cb1aee04840e9ed7dc4a4952e8d883eda1feb90 (diff) | |
| download | poky-d9aabf9639510fdb3e2ccc21ba5ae4aa9f6e4a57.tar.gz | |
gcc: Drop 4.8
We have 5.2 and 4.9, we don't really need 4.8 now and it can be moved
out to other layers if anyone still wants/needs it.
(From OE-Core rev: 6f98c39418c60b7c0b25b30983d2e5257158a6a4)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-devtools/gcc/gcc-4.8/0047-repomembug.patch')
| -rw-r--r-- | meta/recipes-devtools/gcc/gcc-4.8/0047-repomembug.patch | 53 |
1 files changed, 0 insertions, 53 deletions
diff --git a/meta/recipes-devtools/gcc/gcc-4.8/0047-repomembug.patch b/meta/recipes-devtools/gcc/gcc-4.8/0047-repomembug.patch deleted file mode 100644 index 9afd55cbdc..0000000000 --- a/meta/recipes-devtools/gcc/gcc-4.8/0047-repomembug.patch +++ /dev/null | |||
| @@ -1,53 +0,0 @@ | |||
| 1 | When compiling a project using -frepo, .rpo files are written alongside | ||
| 2 | the .o file, the symbols either have O or C against them. During final linking, | ||
| 3 | the objects can be recompiled with some of the entries tweaked/chosen by the | ||
| 4 | tlink.c code (visible with TLINK_VERBOSE=3), it does this by changing O -> C | ||
| 5 | in the .rpo files. | ||
| 6 | |||
| 7 | My tests showed that init_repo (cp/repo.c) was correctly calling | ||
| 8 | IDENTIFIER_REPO_CHOSEN against the right identifers and setting the | ||
| 9 | chosen bit. | ||
| 10 | |||
| 11 | By the time finish_repo() or emit_repo_p() were called, the pointer returned | ||
| 12 | by get_identifier() for the symbol marked during init_repo had changed and | ||
| 13 | the chosen bit was no longer set. This lead to linking bugs like: | ||
| 14 | |||
| 15 | collect: relinking | ||
| 16 | collect2: error: '_ZNK6sudoku5ClearINS_8SequenceEEclERS1_' was assigned to 'board.rpo', but was not defined during recompilation, or vice versa | ||
| 17 | |||
| 18 | The problem is that the garbage collection is getting called before | ||
| 19 | finish_repo() is called and ggc_protect_identifiers is set to false | ||
| 20 | so the identifiers are not preserved. They are recreated but the | ||
| 21 | chosen bits get wiped out which is why the pointer changes and the | ||
| 22 | chosen bit is not set. | ||
| 23 | |||
| 24 | The fix is to change ggc_protect_identifiers *after* the finish_repo | ||
| 25 | calls are made. | ||
| 26 | |||
| 27 | Reproduction is tricky since you need to trigger the garbage collector at | ||
| 28 | just the right moment. | ||
| 29 | |||
| 30 | RP 2013/10/9 | ||
| 31 | |||
| 32 | [YOCTO #5133] | ||
| 33 | |||
| 34 | Upstream-Status: Pending | ||
| 35 | |||
| 36 | Index: gcc-4.8.1/gcc/toplev.c | ||
| 37 | =================================================================== | ||
| 38 | --- gcc-4.8.1.orig/gcc/toplev.c 2013-03-28 08:29:51.000000000 +0000 | ||
| 39 | +++ gcc-4.8.1/gcc/toplev.c 2013-10-09 20:27:17.089228023 +0000 | ||
| 40 | @@ -551,11 +551,11 @@ | ||
| 41 | if (flag_syntax_only || flag_wpa) | ||
| 42 | return; | ||
| 43 | |||
| 44 | - ggc_protect_identifiers = false; | ||
| 45 | - | ||
| 46 | /* This must also call finalize_compilation_unit. */ | ||
| 47 | lang_hooks.decls.final_write_globals (); | ||
| 48 | |||
| 49 | + ggc_protect_identifiers = false; | ||
| 50 | + | ||
| 51 | if (seen_error ()) | ||
| 52 | return; | ||
| 53 | |||
