diff options
| author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2017-01-23 17:43:40 +0000 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2017-01-23 23:30:57 +0000 |
| commit | 6ab4c5033af72f102e7935de62e600b7ce247f34 (patch) | |
| tree | dfc83f0cff8d54ce632b34be2e0c2257760ff226 /meta/lib/oeqa/utils | |
| parent | 0a30ae5e18cd1c1576da80c3b9d31e8d64cfcc01 (diff) | |
| download | poky-6ab4c5033af72f102e7935de62e600b7ce247f34.tar.gz | |
classes/oeqa: Replace subprocess.check_call() with check_output()
If you use subprocess.check_output() the traceback will contain the output
when the command fails which is very useful for debugging. There is no
good reason not to use this everywhere.
(From OE-Core rev: ad750dd1cc9d789abe723daddd098ce41d8547f5)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/lib/oeqa/utils')
| -rw-r--r-- | meta/lib/oeqa/utils/buildproject.py | 2 | ||||
| -rw-r--r-- | meta/lib/oeqa/utils/targetbuild.py | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/meta/lib/oeqa/utils/buildproject.py b/meta/lib/oeqa/utils/buildproject.py index 386a927881..b3c487b6c6 100644 --- a/meta/lib/oeqa/utils/buildproject.py +++ b/meta/lib/oeqa/utils/buildproject.py | |||
| @@ -29,7 +29,7 @@ class BuildProject(metaclass=ABCMeta): | |||
| 29 | return | 29 | return |
| 30 | 30 | ||
| 31 | cmd = "wget -O %s %s" % (self.localarchive, self.uri) | 31 | cmd = "wget -O %s %s" % (self.localarchive, self.uri) |
| 32 | subprocess.check_call(cmd, shell=True) | 32 | subprocess.check_output(cmd, shell=True) |
| 33 | 33 | ||
| 34 | # This method should provide a way to run a command in the desired environment. | 34 | # This method should provide a way to run a command in the desired environment. |
| 35 | @abstractmethod | 35 | @abstractmethod |
diff --git a/meta/lib/oeqa/utils/targetbuild.py b/meta/lib/oeqa/utils/targetbuild.py index c001602b54..6f237b56f3 100644 --- a/meta/lib/oeqa/utils/targetbuild.py +++ b/meta/lib/oeqa/utils/targetbuild.py | |||
| @@ -45,7 +45,7 @@ class BuildProject(metaclass=ABCMeta): | |||
| 45 | cmd = 'export ' + var + '=\"%s\"; %s' % (val, cmd) | 45 | cmd = 'export ' + var + '=\"%s\"; %s' % (val, cmd) |
| 46 | 46 | ||
| 47 | cmd = cmd + "wget -O %s %s" % (self.localarchive, self.uri) | 47 | cmd = cmd + "wget -O %s %s" % (self.localarchive, self.uri) |
| 48 | subprocess.check_call(cmd, shell=True) | 48 | subprocess.check_output(cmd, shell=True) |
| 49 | 49 | ||
| 50 | # This method should provide a way to run a command in the desired environment. | 50 | # This method should provide a way to run a command in the desired environment. |
| 51 | @abstractmethod | 51 | @abstractmethod |
| @@ -114,7 +114,7 @@ class SDKBuildProject(BuildProject): | |||
| 114 | self._download_archive() | 114 | self._download_archive() |
| 115 | 115 | ||
| 116 | cmd = 'tar xf %s%s -C %s' % (self.targetdir, self.archive, self.targetdir) | 116 | cmd = 'tar xf %s%s -C %s' % (self.targetdir, self.archive, self.targetdir) |
| 117 | subprocess.check_call(cmd, shell=True) | 117 | subprocess.check_output(cmd, shell=True) |
| 118 | 118 | ||
| 119 | #Change targetdir to project folder | 119 | #Change targetdir to project folder |
| 120 | self.targetdir = os.path.join(self.targetdir, self.fname) | 120 | self.targetdir = os.path.join(self.targetdir, self.fname) |
