diff options
| author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2013-05-09 14:55:04 +0000 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2013-05-09 16:05:08 +0100 |
| commit | b54339d63339c99f24845f69f49cd1fe996e6e7c (patch) | |
| tree | 73b3da57a66ab4a0f6fa06a479efc5449126342f /meta/classes | |
| parent | d529c11fa512e7f06044378a7ec7137765ea8eb4 (diff) | |
| download | poky-b54339d63339c99f24845f69f49cd1fe996e6e7c.tar.gz | |
classes/lib: Fix getcmdstatus breakage
I mistakenly thought subprocess had getcmdstatus in python 2. It doesn't so lets
add a wrapper and have this work in both worlds.
(From OE-Core rev: 2253e9f12734c6e6aa489942b5e4628eca1fa29d)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes')
| -rw-r--r-- | meta/classes/kernel-yocto.bbclass | 4 | ||||
| -rw-r--r-- | meta/classes/package.bbclass | 4 | ||||
| -rw-r--r-- | meta/classes/sanity.bbclass | 5 |
3 files changed, 6 insertions, 7 deletions
diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass index c81e70e678..d513ad2b63 100644 --- a/meta/classes/kernel-yocto.bbclass +++ b/meta/classes/kernel-yocto.bbclass | |||
| @@ -254,7 +254,7 @@ do_kernel_configme() { | |||
| 254 | } | 254 | } |
| 255 | 255 | ||
| 256 | python do_kernel_configcheck() { | 256 | python do_kernel_configcheck() { |
| 257 | import re, string, sys, subprocess | 257 | import re, string, sys |
| 258 | 258 | ||
| 259 | bb.plain("NOTE: validating kernel config, see log.do_kernel_configcheck for details") | 259 | bb.plain("NOTE: validating kernel config, see log.do_kernel_configcheck for details") |
| 260 | 260 | ||
| @@ -265,7 +265,7 @@ python do_kernel_configcheck() { | |||
| 265 | 265 | ||
| 266 | pathprefix = "export PATH=%s:%s; " % (d.getVar('PATH', True), "${S}/scripts/util/") | 266 | pathprefix = "export PATH=%s:%s; " % (d.getVar('PATH', True), "${S}/scripts/util/") |
| 267 | cmd = d.expand("cd ${S}; kconf_check -config- %s/meta-series ${S} ${B}" % kmeta) | 267 | cmd = d.expand("cd ${S}; kconf_check -config- %s/meta-series ${S} ${B}" % kmeta) |
| 268 | ret, result = subprocess.getstatusoutput("%s%s" % (pathprefix, cmd)) | 268 | ret, result = oe.utils.getstatusoutput("%s%s" % (pathprefix, cmd)) |
| 269 | 269 | ||
| 270 | config_check_visibility = d.getVar( "KCONF_AUDIT_LEVEL", True ) or 1 | 270 | config_check_visibility = d.getVar( "KCONF_AUDIT_LEVEL", True ) or 1 |
| 271 | if config_check_visibility == 1: | 271 | if config_check_visibility == 1: |
diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass index 1dba185b3e..7d0684c95c 100644 --- a/meta/classes/package.bbclass +++ b/meta/classes/package.bbclass | |||
| @@ -696,7 +696,7 @@ python fixup_perms () { | |||
| 696 | } | 696 | } |
| 697 | 697 | ||
| 698 | python split_and_strip_files () { | 698 | python split_and_strip_files () { |
| 699 | import stat, errno, subprocess | 699 | import stat, errno |
| 700 | 700 | ||
| 701 | dvar = d.getVar('PKGD', True) | 701 | dvar = d.getVar('PKGD', True) |
| 702 | pn = d.getVar('PN', True) | 702 | pn = d.getVar('PN', True) |
| @@ -732,7 +732,7 @@ python split_and_strip_files () { | |||
| 732 | # 16 - kernel module | 732 | # 16 - kernel module |
| 733 | def isELF(path): | 733 | def isELF(path): |
| 734 | type = 0 | 734 | type = 0 |
| 735 | ret, result = subprocess.getstatusoutput("file '%s'" % path) | 735 | ret, result = oe.utils.getstatusoutput("file '%s'" % path) |
| 736 | 736 | ||
| 737 | if ret: | 737 | if ret: |
| 738 | bb.error("split_and_strip_files: 'file %s' failed" % path) | 738 | bb.error("split_and_strip_files: 'file %s' failed" % path) |
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass index 3836c0404d..1fb4a6c629 100644 --- a/meta/classes/sanity.bbclass +++ b/meta/classes/sanity.bbclass | |||
| @@ -342,13 +342,12 @@ def check_gcc_march(sanity_data): | |||
| 342 | f = open("gcc_test.c", "w") | 342 | f = open("gcc_test.c", "w") |
| 343 | f.write("int main (){ __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4; return 0;}\n") | 343 | f.write("int main (){ __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4; return 0;}\n") |
| 344 | f.close() | 344 | f.close() |
| 345 | import subprocess | ||
| 346 | 345 | ||
| 347 | # Check if GCC could work without march | 346 | # Check if GCC could work without march |
| 348 | status,result = subprocess.getstatusoutput("${BUILD_PREFIX}gcc gcc_test.c -o gcc_test") | 347 | status,result = oe.utils.getstatusoutput("${BUILD_PREFIX}gcc gcc_test.c -o gcc_test") |
| 349 | if status != 0: | 348 | if status != 0: |
| 350 | # Check if GCC could work with march | 349 | # Check if GCC could work with march |
| 351 | status,result = subprocess.getstatusoutput("${BUILD_PREFIX}gcc -march=native gcc_test.c -o gcc_test") | 350 | status,result = oe.utils.getstatusoutput("${BUILD_PREFIX}gcc -march=native gcc_test.c -o gcc_test") |
| 352 | if status == 0: | 351 | if status == 0: |
| 353 | result = True | 352 | result = True |
| 354 | else: | 353 | else: |
