diff options
author | Quentin Schulz <quentin.schulz@cherry.de> | 2025-09-18 12:24:45 +0200 |
---|---|---|
committer | Steve Sakoman <steve@sakoman.com> | 2025-09-30 08:01:59 -0700 |
commit | e9069b04046087856e80a98800cd7fda3ae4f4dc (patch) | |
tree | 22a198caae5de9db4bc9d787bd3c648efcb245c6 /documentation/contributor-guide/submit-changes.rst | |
parent | 9baa7dfdfdb14a1d5d7b46e27cbd38599fc08643 (diff) | |
download | poky-e9069b04046087856e80a98800cd7fda3ae4f4dc.tar.gz |
contributor-guide: submit-changes: make "Crediting contributors" part of "Commit your changes"
There's no need to differentiate crediting contributors from committing
your changes, so let's simply make it the last step of "Commit your
changes" section.
This simply indents the text so it's now part of "Commit your changes"
list instead of the main list in the "Implement and commit changes"
section. Because of this reorganisation, the instruction to use "git
commit --amend" to add the contributors is moved to a note, and the
first few sentences are reworded to better match the wording of other
items in the "Commit your changes" list of instructions.
(From yocto-docs rev: 6ba61d7bc3e641b3d4194f2d99a276f3b29f82b8)
Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Signed-off-by: Antonin Godard <antonin.godard@bootlin.com>
(cherry picked from commit eff4d14e28d323ebfdaeb0c5c805b5f1e2ad153d)
Signed-off-by: Antonin Godard <antonin.godard@bootlin.com>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
Diffstat (limited to 'documentation/contributor-guide/submit-changes.rst')
-rw-r--r-- | documentation/contributor-guide/submit-changes.rst | 54 |
1 files changed, 29 insertions, 25 deletions
diff --git a/documentation/contributor-guide/submit-changes.rst b/documentation/contributor-guide/submit-changes.rst index 5bb3345cd0..01c273d148 100644 --- a/documentation/contributor-guide/submit-changes.rst +++ b/documentation/contributor-guide/submit-changes.rst | |||
@@ -204,31 +204,35 @@ to add the upgraded version. | |||
204 | 204 | ||
205 | detailed description of change | 205 | detailed description of change |
206 | 206 | ||
207 | #. *Crediting contributors:* By using the ``git commit --amend`` command, | 207 | #. If other people participated in this patch, add some tags to the commit |
208 | you can add some tags to the commit description to credit other contributors | 208 | description to credit other contributors to the change: |
209 | to the change: | 209 | |
210 | 210 | - ``Reported-by``: name and email of a person reporting a bug | |
211 | - ``Reported-by``: name and email of a person reporting a bug | 211 | that your commit is trying to fix. This is a good practice |
212 | that your commit is trying to fix. This is a good practice | 212 | to encourage people to go on reporting bugs and let them |
213 | to encourage people to go on reporting bugs and let them | 213 | know that their reports are taken into account. |
214 | know that their reports are taken into account. | 214 | |
215 | 215 | - ``Suggested-by``: name and email of a person to credit for the | |
216 | - ``Suggested-by``: name and email of a person to credit for the | 216 | idea of making the change. |
217 | idea of making the change. | 217 | |
218 | 218 | - ``Tested-by``, ``Reviewed-by``: name and email for people having | |
219 | - ``Tested-by``, ``Reviewed-by``: name and email for people having | 219 | tested your changes or reviewed their code. These fields are |
220 | tested your changes or reviewed their code. These fields are | 220 | usually added by the maintainer accepting a patch, or by |
221 | usually added by the maintainer accepting a patch, or by | 221 | yourself if you submitted your patches to early reviewers, |
222 | yourself if you submitted your patches to early reviewers, | 222 | or are submitting an unmodified patch again as part of a |
223 | or are submitting an unmodified patch again as part of a | 223 | new iteration of your patch series. |
224 | new iteration of your patch series. | 224 | |
225 | 225 | - ``Cc``: name and email of people you want to send a copy | |
226 | - ``Cc``: name and email of people you want to send a copy | 226 | of your changes to. This field will be used by ``git send-email``. |
227 | of your changes to. This field will be used by ``git send-email``. | 227 | |
228 | 228 | See `more guidance about using such tags | |
229 | See `more guidance about using such tags | 229 | <https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes>`__ |
230 | <https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes>`__ | 230 | in the Linux kernel documentation. |
231 | in the Linux kernel documentation. | 231 | |
232 | .. note:: | ||
233 | |||
234 | One can amend an existing git commit message to add missing tags for | ||
235 | contributors with the ``git commit --amend`` command. | ||
232 | 236 | ||
233 | Test your changes | 237 | Test your changes |
234 | ----------------- | 238 | ----------------- |