diff options
| author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2022-03-10 13:36:14 +0000 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2022-03-11 06:56:01 +0000 |
| commit | 2c545a19ce971c359ba7bbe28b675f4c9797a623 (patch) | |
| tree | fd9a37cd6bd491deb128eed340806fa62be8f82e /bitbake/lib/toaster/toastergui | |
| parent | 9a179022016de3bb02a176bf502fa26b0b08a900 (diff) | |
| download | poky-2c545a19ce971c359ba7bbe28b675f4c9797a623.tar.gz | |
bitbake: toaster: Fix IMAGE_INSTALL issues with _append vs :append
After the override syntax change, toaster isn't working correctly. This
is because it uses IMAGE_INSTALL_append instead of IMAGE_INSTALL:append.
This tweaks the code accordingly to fix this.
I have a suspicion that exiting toaster databases may struggle with
the change and there are some migration steps missing for the whole
overrides syntax change step.
(Bitbake rev: befc93c3e03a9b1a2b630cd5badcda756fe6cd28)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/toaster/toastergui')
| -rw-r--r-- | bitbake/lib/toaster/toastergui/templates/projectconf.html | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/bitbake/lib/toaster/toastergui/templates/projectconf.html b/bitbake/lib/toaster/toastergui/templates/projectconf.html index d62691df1d..3b91b6679b 100644 --- a/bitbake/lib/toaster/toastergui/templates/projectconf.html +++ b/bitbake/lib/toaster/toastergui/templates/projectconf.html | |||
| @@ -73,7 +73,7 @@ | |||
| 73 | 73 | ||
| 74 | {% if image_install_append_defined %} | 74 | {% if image_install_append_defined %} |
| 75 | <dt> | 75 | <dt> |
| 76 | <span class="js-config-var-name js-config-var-managed-name">IMAGE_INSTALL_append</span> | 76 | <span class="js-config-var-name js-config-var-managed-name">IMAGE_INSTALL:append</span> |
| 77 | <span class="glyphicon glyphicon-question-sign get-help" title="Specifies additional packages to install into an image. If your build creates more than one image, the packages will be installed in all of them"></span> | 77 | <span class="glyphicon glyphicon-question-sign get-help" title="Specifies additional packages to install into an image. If your build creates more than one image, the packages will be installed in all of them"></span> |
| 78 | </dt> | 78 | </dt> |
| 79 | <dd class="variable-list"> | 79 | <dd class="variable-list"> |
| @@ -83,7 +83,7 @@ | |||
| 83 | <form id="change-image_install-form" class="form-inline" style="display:none;"> | 83 | <form id="change-image_install-form" class="form-inline" style="display:none;"> |
| 84 | <div class="row"> | 84 | <div class="row"> |
| 85 | <div class="col-md-4"> | 85 | <div class="col-md-4"> |
| 86 | <span class="help-block">To set IMAGE_INSTALL_append to more than one package, type the package names separated by a space.</span> | 86 | <span class="help-block">To set IMAGE_INSTALL:append to more than one package, type the package names separated by a space.</span> |
| 87 | </div> | 87 | </div> |
| 88 | </div> | 88 | </div> |
| 89 | <div class="form-group"> | 89 | <div class="form-group"> |
| @@ -771,10 +771,10 @@ $(document).ready(function() { | |||
| 771 | 771 | ||
| 772 | {% if image_install_append_defined %} | 772 | {% if image_install_append_defined %} |
| 773 | 773 | ||
| 774 | // init IMAGE_INSTALL_append trash icon | 774 | // init IMAGE_INSTALL:append trash icon |
| 775 | setDeleteTooltip($('#delete-image_install-icon')); | 775 | setDeleteTooltip($('#delete-image_install-icon')); |
| 776 | 776 | ||
| 777 | // change IMAGE_INSTALL_append variable | 777 | // change IMAGE_INSTALL:append variable |
| 778 | $('#change-image_install-icon').click(function() { | 778 | $('#change-image_install-icon').click(function() { |
| 779 | // preset the edit value | 779 | // preset the edit value |
| 780 | var current_val = $("span#image_install").text().trim(); | 780 | var current_val = $("span#image_install").text().trim(); |
| @@ -814,7 +814,7 @@ $(document).ready(function() { | |||
| 814 | $('#apply-change-image_install').click(function(){ | 814 | $('#apply-change-image_install').click(function(){ |
| 815 | // insure these non-empty values have single space prefix | 815 | // insure these non-empty values have single space prefix |
| 816 | var value = " " + $('#new-image_install').val().trim(); | 816 | var value = " " + $('#new-image_install').val().trim(); |
| 817 | postEditAjaxRequest({"configvarChange" : 'IMAGE_INSTALL_append:'+value}); | 817 | postEditAjaxRequest({"configvarChange" : 'IMAGE_INSTALL:append:'+value}); |
| 818 | $('#image_install').text(value); | 818 | $('#image_install').text(value); |
| 819 | $('#image_install').removeClass('text-muted'); | 819 | $('#image_install').removeClass('text-muted'); |
| 820 | $("#change-image_install-form").slideUp(function () { | 820 | $("#change-image_install-form").slideUp(function () { |
| @@ -826,10 +826,10 @@ $(document).ready(function() { | |||
| 826 | }); | 826 | }); |
| 827 | }); | 827 | }); |
| 828 | 828 | ||
| 829 | // delete IMAGE_INSTALL_append variable value | 829 | // delete IMAGE_INSTALL:append variable value |
| 830 | $('#delete-image_install-icon').click(function(){ | 830 | $('#delete-image_install-icon').click(function(){ |
| 831 | $(this).tooltip('hide'); | 831 | $(this).tooltip('hide'); |
| 832 | postEditAjaxRequest({"configvarChange" : 'IMAGE_INSTALL_append:'+''}); | 832 | postEditAjaxRequest({"configvarChange" : 'IMAGE_INSTALL:append:'+''}); |
| 833 | $('#image_install').parent().fadeOut(1000, function(){ | 833 | $('#image_install').parent().fadeOut(1000, function(){ |
| 834 | $('#image_install').addClass('text-muted'); | 834 | $('#image_install').addClass('text-muted'); |
| 835 | $('#image_install').text('Not set'); | 835 | $('#image_install').text('Not set'); |
| @@ -1011,7 +1011,7 @@ $(document).ready(function() { | |||
| 1011 | $(".save").attr("disabled","disabled"); | 1011 | $(".save").attr("disabled","disabled"); |
| 1012 | 1012 | ||
| 1013 | // Reload page if admin-removed core managed value is manually added back in | 1013 | // Reload page if admin-removed core managed value is manually added back in |
| 1014 | if (0 <= " DISTRO DL_DIR IMAGE_FSTYPES IMAGE_INSTALL_append PACKAGE_CLASSES SSTATE_DIR ".indexOf( " "+variable+" " )) { | 1014 | if (0 <= " DISTRO DL_DIR IMAGE_FSTYPES IMAGE_INSTALL:append PACKAGE_CLASSES SSTATE_DIR ".indexOf( " "+variable+" " )) { |
| 1015 | // delayed reload to avoid race condition with postEditAjaxRequest | 1015 | // delayed reload to avoid race condition with postEditAjaxRequest |
| 1016 | do_reload=true; | 1016 | do_reload=true; |
| 1017 | } | 1017 | } |
