diff options
| author | Robert Yang <liezhi.yang@windriver.com> | 2012-05-20 20:36:05 +0800 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2012-05-23 11:35:11 +0100 |
| commit | 10a0f9ed929449543e5caab7e5f8855e0e68605b (patch) | |
| tree | 906283ad2b35380b2240854f120eb646f51c8fab /bitbake/lib/bb/ui/crumbs | |
| parent | 358016f463958640c694d031a481264a0e770802 (diff) | |
| download | poky-10a0f9ed929449543e5caab7e5f8855e0e68605b.tar.gz | |
replace os.system with subprocess.call
Replace os.system with subprocess.call since the older function would
fail (more or less) silently if the executed program cannot be found
More info:
http://docs.python.org/library/subprocess.html#subprocess-replacements
[YOCTO #2075]
(Bitbake rev: f5b3bf115dc1ffbfb241a49cec0fc3654cb71021)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/bb/ui/crumbs')
| -rwxr-xr-x | bitbake/lib/bb/ui/crumbs/imagedetailspage.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py index 153837611f..5d8549170c 100755 --- a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py +++ b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py | |||
| @@ -25,6 +25,7 @@ import gtk | |||
| 25 | from bb.ui.crumbs.hobcolor import HobColors | 25 | from bb.ui.crumbs.hobcolor import HobColors |
| 26 | from bb.ui.crumbs.hobwidget import hic, HobViewTable, HobAltButton, HobButton | 26 | from bb.ui.crumbs.hobwidget import hic, HobViewTable, HobAltButton, HobButton |
| 27 | from bb.ui.crumbs.hobpages import HobPage | 27 | from bb.ui.crumbs.hobpages import HobPage |
| 28 | import subprocess | ||
| 28 | 29 | ||
| 29 | # | 30 | # |
| 30 | # ImageDetailsPage | 31 | # ImageDetailsPage |
| @@ -297,7 +298,7 @@ class ImageDetailsPage (HobPage): | |||
| 297 | self.show_all() | 298 | self.show_all() |
| 298 | 299 | ||
| 299 | def view_files_clicked_cb(self, button, image_addr): | 300 | def view_files_clicked_cb(self, button, image_addr): |
| 300 | os.system("xdg-open /%s" % image_addr) | 301 | subprocess.call("xdg-open /%s" % image_addr, shell=True) |
| 301 | 302 | ||
| 302 | def refresh_package_detail_box(self, image_size): | 303 | def refresh_package_detail_box(self, image_size): |
| 303 | self.package_detail.update_line_widgets("Total image size: ", image_size) | 304 | self.package_detail.update_line_widgets("Total image size: ", image_size) |
