summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSiddharth <sdoshi@mvista.com>2024-06-04 23:39:48 +0530
committerSteve Sakoman <steve@sakoman.com>2024-06-26 05:04:39 -0700
commit940a24ab8b7ac626209a7efb2d476aa0b201a84f (patch)
tree8e2e1f14bfbcefee0afc8ca56a57635ef10245ea
parent14fe1f131959ddda0d7d4f5d255ae5f3d681fd24 (diff)
downloadpoky-940a24ab8b7ac626209a7efb2d476aa0b201a84f.tar.gz
openssl: Upgrade 3.0.13 -> 3.0.14
CVE's Fixed by upgrade: CVE-2024-4741: Fixed potential use after free after SSL_free_buffers() is called CVE-2024-4603: Fixed an issue where checking excessively long DSA keys or parameters may be very slow CVE-2024-2511: Fixed unbounded memory growth with session handling in TLSv1.3 Removed backports of CVE-2024-2511 and CVE-2024-4603 as they are already fixed. Detailed Information: https://github.com/openssl/openssl/blob/openssl-3.0/CHANGES.md#changes-between-3013-and-3014-4-jun-2024 (From OE-Core rev: 8f51bac2a05747ea186e928eda2358f2e6295883) Signed-off-by: Siddharth Doshi <sdoshi@mvista.com> Signed-off-by: Steve Sakoman <steve@sakoman.com>
-rw-r--r--meta/recipes-connectivity/openssl/openssl/CVE-2024-2511.patch122
-rw-r--r--meta/recipes-connectivity/openssl/openssl/CVE-2024-4603.patch180
-rw-r--r--meta/recipes-connectivity/openssl/openssl_3.0.14.bb (renamed from meta/recipes-connectivity/openssl/openssl_3.0.13.bb)4
3 files changed, 1 insertions, 305 deletions
diff --git a/meta/recipes-connectivity/openssl/openssl/CVE-2024-2511.patch b/meta/recipes-connectivity/openssl/openssl/CVE-2024-2511.patch
deleted file mode 100644
index 8aea686205..0000000000
--- a/meta/recipes-connectivity/openssl/openssl/CVE-2024-2511.patch
+++ /dev/null
@@ -1,122 +0,0 @@
1From b52867a9f618bb955bed2a3ce3db4d4f97ed8e5d Mon Sep 17 00:00:00 2001
2From: Matt Caswell <matt@openssl.org>
3Date: Tue, 5 Mar 2024 15:43:53 +0000
4Subject: [PATCH] Fix unconstrained session cache growth in TLSv1.3
5
6In TLSv1.3 we create a new session object for each ticket that we send.
7We do this by duplicating the original session. If SSL_OP_NO_TICKET is in
8use then the new session will be added to the session cache. However, if
9early data is not in use (and therefore anti-replay protection is being
10used), then multiple threads could be resuming from the same session
11simultaneously. If this happens and a problem occurs on one of the threads,
12then the original session object could be marked as not_resumable. When we
13duplicate the session object this not_resumable status gets copied into the
14new session object. The new session object is then added to the session
15cache even though it is not_resumable.
16
17Subsequently, another bug means that the session_id_length is set to 0 for
18sessions that are marked as not_resumable - even though that session is
19still in the cache. Once this happens the session can never be removed from
20the cache. When that object gets to be the session cache tail object the
21cache never shrinks again and grows indefinitely.
22
23CVE-2024-2511
24
25Reviewed-by: Neil Horman <nhorman@openssl.org>
26Reviewed-by: Tomas Mraz <tomas@openssl.org>
27(Merged from https://github.com/openssl/openssl/pull/24044)
28
29(cherry picked from commit 7e4d731b1c07201ad9374c1cd9ac5263bdf35bce)
30
31CVE: CVE-2024-2511
32Upstream-Status: Backport [https://github.com/openssl/openssl/commit/b52867a9f618bb955bed2a3ce3db4d4f97ed8e5d]
33Signed-off-by: Peter Marko <peter.marko@siemens.com>
34---
35 ssl/ssl_lib.c | 5 +++--
36 ssl/ssl_sess.c | 28 ++++++++++++++++++++++------
37 ssl/statem/statem_srvr.c | 5 ++---
38 3 files changed, 27 insertions(+), 11 deletions(-)
39
40diff --git a/ssl/ssl_lib.c b/ssl/ssl_lib.c
41index 2c8479eb5fc69..eed649c6fdee9 100644
42--- a/ssl/ssl_lib.c
43+++ b/ssl/ssl_lib.c
44@@ -3736,9 +3736,10 @@ void ssl_update_cache(SSL *s, int mode)
45
46 /*
47 * If the session_id_length is 0, we are not supposed to cache it, and it
48- * would be rather hard to do anyway :-)
49+ * would be rather hard to do anyway :-). Also if the session has already
50+ * been marked as not_resumable we should not cache it for later reuse.
51 */
52- if (s->session->session_id_length == 0)
53+ if (s->session->session_id_length == 0 || s->session->not_resumable)
54 return;
55
56 /*
57diff --git a/ssl/ssl_sess.c b/ssl/ssl_sess.c
58index d836b33ed0e81..75adbd9e52b40 100644
59--- a/ssl/ssl_sess.c
60+++ b/ssl/ssl_sess.c
61@@ -152,16 +152,11 @@ SSL_SESSION *SSL_SESSION_new(void)
62 return ss;
63 }
64
65-SSL_SESSION *SSL_SESSION_dup(const SSL_SESSION *src)
66-{
67- return ssl_session_dup(src, 1);
68-}
69-
70 /*
71 * Create a new SSL_SESSION and duplicate the contents of |src| into it. If
72 * ticket == 0 then no ticket information is duplicated, otherwise it is.
73 */
74-SSL_SESSION *ssl_session_dup(const SSL_SESSION *src, int ticket)
75+static SSL_SESSION *ssl_session_dup_intern(const SSL_SESSION *src, int ticket)
76 {
77 SSL_SESSION *dest;
78
79@@ -285,6 +280,27 @@ SSL_SESSION *ssl_session_dup(const SSL_SESSION *src, int ticket)
80 return NULL;
81 }
82
83+SSL_SESSION *SSL_SESSION_dup(const SSL_SESSION *src)
84+{
85+ return ssl_session_dup_intern(src, 1);
86+}
87+
88+/*
89+ * Used internally when duplicating a session which might be already shared.
90+ * We will have resumed the original session. Subsequently we might have marked
91+ * it as non-resumable (e.g. in another thread) - but this copy should be ok to
92+ * resume from.
93+ */
94+SSL_SESSION *ssl_session_dup(const SSL_SESSION *src, int ticket)
95+{
96+ SSL_SESSION *sess = ssl_session_dup_intern(src, ticket);
97+
98+ if (sess != NULL)
99+ sess->not_resumable = 0;
100+
101+ return sess;
102+}
103+
104 const unsigned char *SSL_SESSION_get_id(const SSL_SESSION *s, unsigned int *len)
105 {
106 if (len)
107diff --git a/ssl/statem/statem_srvr.c b/ssl/statem/statem_srvr.c
108index a9e67f9d32a77..6c942e6bcec29 100644
109--- a/ssl/statem/statem_srvr.c
110+++ b/ssl/statem/statem_srvr.c
111@@ -2338,9 +2338,8 @@ int tls_construct_server_hello(SSL *s, WPACKET *pkt)
112 * so the following won't overwrite an ID that we're supposed
113 * to send back.
114 */
115- if (s->session->not_resumable ||
116- (!(s->ctx->session_cache_mode & SSL_SESS_CACHE_SERVER)
117- && !s->hit))
118+ if (!(s->ctx->session_cache_mode & SSL_SESS_CACHE_SERVER)
119+ && !s->hit)
120 s->session->session_id_length = 0;
121
122 if (usetls13) {
diff --git a/meta/recipes-connectivity/openssl/openssl/CVE-2024-4603.patch b/meta/recipes-connectivity/openssl/openssl/CVE-2024-4603.patch
deleted file mode 100644
index b8e0b9fb7d..0000000000
--- a/meta/recipes-connectivity/openssl/openssl/CVE-2024-4603.patch
+++ /dev/null
@@ -1,180 +0,0 @@
1From 3559e868e58005d15c6013a0c1fd832e51c73397 Mon Sep 17 00:00:00 2001
2From: Tomas Mraz <tomas@openssl.org>
3Date: Wed, 8 May 2024 15:23:45 +0200
4Subject: [PATCH] Check DSA parameters for excessive sizes before validating
5
6This avoids overly long computation of various validation
7checks.
8
9Fixes CVE-2024-4603
10
11Reviewed-by: Paul Dale <ppzgs1@gmail.com>
12Reviewed-by: Matt Caswell <matt@openssl.org>
13Reviewed-by: Neil Horman <nhorman@openssl.org>
14Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
15(Merged from https://github.com/openssl/openssl/pull/24346)
16
17(cherry picked from commit 85ccbab216da245cf9a6503dd327072f21950d9b)
18
19<dropped CHANGES.md modifications as it would need backport of all previous changes>
20
21CVE: CVE-2024-4603
22Upstream-Status: Backport [https://github.com/openssl/openssl/commit/3559e868e58005d15c6013a0c1fd832e51c73397]
23Signed-off-by: Peter Marko <peter.marko@siemens.com>
24---
25 crypto/dsa/dsa_check.c | 44 ++++++++++++--
26 .../invalid/p10240_q256_too_big.pem | 57 +++++++++++++++++++
27 2 files changed, 97 insertions(+), 4 deletions(-)
28 create mode 100644 test/recipes/15-test_dsaparam_data/invalid/p10240_q256_too_big.pem
29
30diff --git a/crypto/dsa/dsa_check.c b/crypto/dsa/dsa_check.c
31index fb0e9129a2..122449a7bf 100644
32--- a/crypto/dsa/dsa_check.c
33+++ b/crypto/dsa/dsa_check.c
34@@ -19,8 +19,34 @@
35 #include "dsa_local.h"
36 #include "crypto/dsa.h"
37
38+static int dsa_precheck_params(const DSA *dsa, int *ret)
39+{
40+ if (dsa->params.p == NULL || dsa->params.q == NULL) {
41+ ERR_raise(ERR_LIB_DSA, DSA_R_BAD_FFC_PARAMETERS);
42+ *ret = FFC_CHECK_INVALID_PQ;
43+ return 0;
44+ }
45+
46+ if (BN_num_bits(dsa->params.p) > OPENSSL_DSA_MAX_MODULUS_BITS) {
47+ ERR_raise(ERR_LIB_DSA, DSA_R_MODULUS_TOO_LARGE);
48+ *ret = FFC_CHECK_INVALID_PQ;
49+ return 0;
50+ }
51+
52+ if (BN_num_bits(dsa->params.q) >= BN_num_bits(dsa->params.p)) {
53+ ERR_raise(ERR_LIB_DSA, DSA_R_BAD_Q_VALUE);
54+ *ret = FFC_CHECK_INVALID_PQ;
55+ return 0;
56+ }
57+
58+ return 1;
59+}
60+
61 int ossl_dsa_check_params(const DSA *dsa, int checktype, int *ret)
62 {
63+ if (!dsa_precheck_params(dsa, ret))
64+ return 0;
65+
66 if (checktype == OSSL_KEYMGMT_VALIDATE_QUICK_CHECK)
67 return ossl_ffc_params_simple_validate(dsa->libctx, &dsa->params,
68 FFC_PARAM_TYPE_DSA, ret);
69@@ -39,6 +65,9 @@ int ossl_dsa_check_params(const DSA *dsa, int checktype, int *ret)
70 */
71 int ossl_dsa_check_pub_key(const DSA *dsa, const BIGNUM *pub_key, int *ret)
72 {
73+ if (!dsa_precheck_params(dsa, ret))
74+ return 0;
75+
76 return ossl_ffc_validate_public_key(&dsa->params, pub_key, ret)
77 && *ret == 0;
78 }
79@@ -50,6 +79,9 @@ int ossl_dsa_check_pub_key(const DSA *dsa, const BIGNUM *pub_key, int *ret)
80 */
81 int ossl_dsa_check_pub_key_partial(const DSA *dsa, const BIGNUM *pub_key, int *ret)
82 {
83+ if (!dsa_precheck_params(dsa, ret))
84+ return 0;
85+
86 return ossl_ffc_validate_public_key_partial(&dsa->params, pub_key, ret)
87 && *ret == 0;
88 }
89@@ -58,8 +90,10 @@ int ossl_dsa_check_priv_key(const DSA *dsa, const BIGNUM *priv_key, int *ret)
90 {
91 *ret = 0;
92
93- return (dsa->params.q != NULL
94- && ossl_ffc_validate_private_key(dsa->params.q, priv_key, ret));
95+ if (!dsa_precheck_params(dsa, ret))
96+ return 0;
97+
98+ return ossl_ffc_validate_private_key(dsa->params.q, priv_key, ret);
99 }
100
101 /*
102@@ -72,8 +106,10 @@ int ossl_dsa_check_pairwise(const DSA *dsa)
103 BN_CTX *ctx = NULL;
104 BIGNUM *pub_key = NULL;
105
106- if (dsa->params.p == NULL
107- || dsa->params.g == NULL
108+ if (!dsa_precheck_params(dsa, &ret))
109+ return 0;
110+
111+ if (dsa->params.g == NULL
112 || dsa->priv_key == NULL
113 || dsa->pub_key == NULL)
114 return 0;
115diff --git a/test/recipes/15-test_dsaparam_data/invalid/p10240_q256_too_big.pem b/test/recipes/15-test_dsaparam_data/invalid/p10240_q256_too_big.pem
116new file mode 100644
117index 0000000000..e85e2953b7
118--- /dev/null
119+++ b/test/recipes/15-test_dsaparam_data/invalid/p10240_q256_too_big.pem
120@@ -0,0 +1,57 @@
121+-----BEGIN DSA PARAMETERS-----
122+MIIKLAKCBQEAym47LzPFZdbz16WvjczLKuzLtsP8yRk/exxL4bBthJhP1qOwctja
123+p1586SF7gDxCMn7yWVEYdfRbFefGoq0gj1XOE917XqlbnkmZhMgxut2KbNJo/xil
124+XNFUjGvKs3F413U9rAodC8f07cWHP1iTcWL+vPe6u2yilKWYYfnLWHQH+Z6aPrrF
125+x/R08LI6DZ6nEsIo+hxaQnEtx+iqNTJC6Q1RIjWDqxQkFVTkJ0Y7miRDXmRdneWk
126+oLrMZRpaXr5l5tSjEghh1pBgJcdyOv0lh4dlDy/alAiqE2Qlb667yHl6A9dDPlpW
127+dAntpffy4LwOxfbuEhISvKjjQoBwIvYE4TBPqL0Q6bC6HgQ4+tqd9b44pQjdIQjb
128+Xcjc6azheITSnPEex3OdKtKoQeRq01qCeLBpMXu1c+CTf4ApKArZvT3vZSg0hM1O
129+pR71bRZrEEegDj0LH2HCgI5W6H3blOS9A0kUTddCoQXr2lsVdiPtRbPKH1gcd9FQ
130+P8cGrvbakpTiC0dCczOMDaCteM1QNILlkM7ZoV6VghsKvDnFPxFsiIr5GgjasXP5
131+hhbn3g7sDoq1LiTEo+IKQY28pBWx7etSOSRuXW/spnvCkivZla7lSEGljoy9QlQ2
132+UZmsEQI9G3YyzgpxHvKZBK1CiZVTywdYKTZ4TYCxvqzhYhjv2bqbpjI12HRFLojB
133+koyEmMSp53lldCzp158PrIanqSp2rksMR8SmmCL3FwfAp2OjqFMEglG9DT8x0WaN
134+TLSkjGC6t2csMte7WyU1ekNoFDKfMjDSAz0+xIx21DEmZtYqFOg1DNPK1xYLS0pl
135+RSMRRkJVN2mk/G7/1oxlB8Wb9wgi3GKUqqCYT11SnBjzq0NdoJ3E4GMedp5Lx3AZ
136+4mFuRPUd4iV86tE0XDSHSFE7Y3ZkrOjD7Q/26/L53L/UH5z4HW6CHP5os7QERJjg
137+c1S3x87wXWo9QXbB9b2xmf+c+aWwAAr1cviw38tru58jF3/IGyduj9H8claKQqBG
138+cIOUF4aNe1hK2K3ArAOApUxr4KE+tCvrltRfiTmVFip0g9Jt1CPY3Zu7Bd4Z2ZkE
139+DtSztpwa49HrWF5E9xpquvBL2U8jQ68E7Xd8Wp4orI/TIChriamBmdkgRz3H2LvN
140+Ozb6+hsnEGrz3sp2RVAToSqA9ysa6nHZdfufPNtMEbQdO/k1ehmGRb0ljBRsO6b2
141+rsG2eYuC8tg8eCrIkua0TGRI7g6a4K32AJdzaX6NsISaaIW+OYJuoDSscvD3oOg8
142+PPEhU+zM7xJskTA+jxvPlikKx8V7MNHOCQECldJlUBwzJvqp40JvwfnDsF+8VYwd
143+UaiieR3pzMzyTjpReXRmZbnRPusRcsVzxb2OhB79wmuy4UPjjQBX+7eD0rs8xxvW
144+5a5q1Cjq4AvbwmmcA/wDrHDOjcbD/zodad2O1QtBWa/R4xyWea4zKsflgACE1zY9
145+wW2br7+YQFekcrXkkkEzgxd6zxv8KVEDpXRZjmAM1cI5LvkoN64To4GedN8Qe/G7
146+R9SZh9gnS17PTP64hK+aYqhFafMdu87q/+qLfxaSux727qE5hiW01u4nnWhACf9s
147+xuOozowKqxZxkolMIyZv6Lddwy1Zv5qjCyd0DvM/1skpXWkb9kfabYC+OhjsjVhs
148+0Ktfs6a5B3eixiw5x94hhIcTEcS4hmvhGUL72FiTca6ZeSERTKmNBy8CIQC9/ZUN
149+uU/V5JTcnYyUGHzm7+XcZBjyGBagBj9rCmW3SQKCBQAJ/k9rb39f1cO+/3XDEMjy
150+9bIEXSuS48g5RAc1UGd5nrrBQwuDxGWFyz0yvAY7LgyidZuJS21+MAp9EY7AOMmx
151+TDttifNaBJYt4GZ8of166PcqTKkHQwq5uBpxeSDv/ZE8YbYfaCtLTcUC8KlO+l36
152+gjJHSkdkflSsGy1yObSNDQDfVAAwQs//TjDMnuEtvlNXZllsTvFFBceXVETn10K2
153+ZMmdSIJNfLnjReUKEN6PfeGqv7F4xoyGwUybEfRE4u5RmXrqCODaIjY3SNMrOq8B
154+R3Ata/cCozsM1jIdIW2z+OybDJH+BYsYm2nkSZQjZS6javTYClLrntEKG/hAQwL8
155+F16YLOQXpHhgiAaWnTZzANtLppB2+5qCVy5ElzKongOwT8JTjTFXOaRnqe/ngm9W
156+SSbrxfDaoWUOyK9XD8Cydzpv3n4Y8nWNGayi7/yAFCU36Ri040ufgv/TZLuKacnl
157++3ga3ZUpRlSigzx0kb1+KjTSWeQ8vE/psdWjvBukVEbzdUauMLyRLo/6znSVvvPX
158+UGhviThE5uhrsUg+wEPFINriSHfF7JDKVhDcJnLBdaXvfN52pkF/naLBF5Rt3Gvq
159+fjCxjx0Sy9Lag1hDN4dor7dzuO7wmwOS01DJW1PtNLuuH0Bbqh1kYSaQkmyXBZWX
160+qo8K3nkoDM0niOtJJubOhTNrGmSaZpNXkK3Mcy9rBbdvEs5O0Jmqaax/eOdU0Yot
161+B3lX+3ddOseT2ZEFjzObqTtkWuFBeBxuYNcRTsu3qMdIBsEb8URQdsTtjoIja2fK
162+hreVgjK36GW70KXEl8V/vq5qjQulmqkBEjmilcDuiREKqQuyeagUOnhQaBplqVco
163+4xznh5DMBMRbpGb5lHxKv4cPNi+uNAJ5i98zWUM1JRt6aXnRCuWcll1z8fRZ+5kD
164+vK9FaZU3VRMK/eknEG49cGr8OuJ6ZRSaC+tKwV1y+amkSZpKPWnk2bUnQI3ApJv3
165+k1e1EToeECpMUkLMDgNbpKBoz4nqMEvAAlYgw9xKNbLlQlahqTVEAmaJHh4yDMDy
166+i7IZ9Wrn47IGoR7s3cvhDHUpRPeW4nsmgzj+tf5EAxemI61STZJTTWo0iaPGJxct
167+9nhOOhw1I38Mvm4vkAbFH7YJ0B6QrjjYL2MbOTp5JiIh4vdOeWwNo9/y4ffyaN5+
168+ADpxuuIAmcbdr6GPOhkOFFixRJa0B2eP1i032HESlLs8RB9oYtdTXdXQotnIgJGd
169+Y8tSKOa1zjzeLHn3AVpRZTUW++/BxmApV3GKIeG8fsUjg/df0QRrBcdC/1uccdaG
170+KKlAOwlywVn5jUlwHkTmDiTM9w5AqVVGHZ2b+4ZgQW8jnPKN0SrKf6U555D+zp7E
171+x4uXoE8ojN9y8m8UKf0cTLnujH2XgZorjPfuMOt5VZEhQFMS2QaljSeni5CJJ8gk
172+XtztNqfBlAtWR4V5iAHeQOfIB2YaOy8GESda89tyKraKeaez41VblpTVHTeq9IIF
173+YB4cQA2PfuNaGVRGLMAgT3Dvl+mxxxeJyxnGAiUcETU/jJJt9QombiuszBlYGQ5d
174+ELOSm/eQSRARV9zNSt5jaQlMSjMBqenIEM09BzYqa7jDwqoztFxNdO8bcuQPuKwa
175+4z3bBZ1yYm63WFdNbQqqGEwc0OYmqg1raJ0zltgHyjFyw8IGu4g/wETs+nVQcH7D
176+vKuje86bePD6kD/LH3wmkA==
177+-----END DSA PARAMETERS-----
178--
1792.30.2
180
diff --git a/meta/recipes-connectivity/openssl/openssl_3.0.13.bb b/meta/recipes-connectivity/openssl/openssl_3.0.14.bb
index 87ab4047d9..021787adcb 100644
--- a/meta/recipes-connectivity/openssl/openssl_3.0.13.bb
+++ b/meta/recipes-connectivity/openssl/openssl_3.0.14.bb
@@ -12,15 +12,13 @@ SRC_URI = "http://www.openssl.org/source/openssl-${PV}.tar.gz \
12 file://0001-buildinfo-strip-sysroot-and-debug-prefix-map-from-co.patch \ 12 file://0001-buildinfo-strip-sysroot-and-debug-prefix-map-from-co.patch \
13 file://afalg.patch \ 13 file://afalg.patch \
14 file://0001-Configure-do-not-tweak-mips-cflags.patch \ 14 file://0001-Configure-do-not-tweak-mips-cflags.patch \
15 file://CVE-2024-2511.patch \
16 file://CVE-2024-4603.patch \
17 " 15 "
18 16
19SRC_URI:append:class-nativesdk = " \ 17SRC_URI:append:class-nativesdk = " \
20 file://environment.d-openssl.sh \ 18 file://environment.d-openssl.sh \
21 " 19 "
22 20
23SRC_URI[sha256sum] = "88525753f79d3bec27d2fa7c66aa0b92b3aa9498dafd93d7cfa4b3780cdae313" 21SRC_URI[sha256sum] = "eeca035d4dd4e84fc25846d952da6297484afa0650a6f84c682e39df3a4123ca"
24 22
25inherit lib_package multilib_header multilib_script ptest perlnative 23inherit lib_package multilib_header multilib_script ptest perlnative
26MULTILIB_SCRIPTS = "${PN}-bin:${bindir}/c_rehash" 24MULTILIB_SCRIPTS = "${PN}-bin:${bindir}/c_rehash"