summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Wiehler <stefan.wiehler@nokia.com>2022-06-02 11:45:14 +0200
committerRichard Purdie <richard.purdie@linuxfoundation.org>2022-06-11 10:06:13 +0100
commitbced754b565ce2294e9431f6e656bf02ddc7ca29 (patch)
tree87d5246012c2f448d4a34d2c33c94a4540ff69f2
parenta4ee07275cc307603763a00fc6c73a900e4e3f47 (diff)
downloadpoky-bced754b565ce2294e9431f6e656bf02ddc7ca29.tar.gz
kernel-yocto.bbclass: Reset to exiting on non-zero return code at end of task
Several tasks deactivate exiting on non-zero return codes via set +e because they run subcommands that have legitimate non-zero return codes. However when appending to those tasks, this behavior is not expected and can lead to builds silently proceeding in case of an error. Therefore reset the default behavior at the end of the respective tasks via set -e. (From OE-Core rev: 45b4597db37e3ad50ff84cda39fd14a25d6d2680) Signed-off-by: Stefan Wiehler <stefan.wiehler@nokia.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 83a6f28d2e464f00202090e998a63045adba9e4e) Signed-off-by: Steve Sakoman <steve@sakoman.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/classes/kernel-yocto.bbclass8
1 files changed, 8 insertions, 0 deletions
diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
index 4cb638864c..afccffcf17 100644
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -310,6 +310,8 @@ do_kernel_metadata() {
310 bbnote "KERNEL_FEATURES: $KERNEL_FEATURES_FINAL" 310 bbnote "KERNEL_FEATURES: $KERNEL_FEATURES_FINAL"
311 bbnote "Final scc/cfg list: $sccs_defconfig $bsp_definition $sccs $KERNEL_FEATURES_FINAL" 311 bbnote "Final scc/cfg list: $sccs_defconfig $bsp_definition $sccs $KERNEL_FEATURES_FINAL"
312 fi 312 fi
313
314 set -e
313} 315}
314 316
315do_patch() { 317do_patch() {
@@ -339,6 +341,8 @@ do_patch() {
339 fi 341 fi
340 done 342 done
341 fi 343 fi
344
345 set -e
342} 346}
343 347
344do_kernel_checkout() { 348do_kernel_checkout() {
@@ -397,6 +401,8 @@ do_kernel_checkout() {
397 git commit -q -m "baseline commit: creating repo for ${PN}-${PV}" 401 git commit -q -m "baseline commit: creating repo for ${PN}-${PV}"
398 git clean -d -f 402 git clean -d -f
399 fi 403 fi
404
405 set -e
400} 406}
401do_kernel_checkout[dirs] = "${S} ${WORKDIR}" 407do_kernel_checkout[dirs] = "${S} ${WORKDIR}"
402 408
@@ -691,6 +697,8 @@ do_validate_branches() {
691 kgit-s2q --clean 697 kgit-s2q --clean
692 fi 698 fi
693 fi 699 fi
700
701 set -e
694} 702}
695 703
696OE_TERMINAL_EXPORTS += "KBUILD_OUTPUT" 704OE_TERMINAL_EXPORTS += "KBUILD_OUTPUT"