diff options
| author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2023-02-17 12:34:39 +0000 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2023-02-19 07:48:28 +0000 |
| commit | 65de367cfe0db5226c1334827810280afc727e73 (patch) | |
| tree | 9597a849bbdb1d4cfe7b90447b0666283de4fc23 | |
| parent | 42f4f740b1d6305b0636e232cc5e2c808285059c (diff) | |
| download | poky-65de367cfe0db5226c1334827810280afc727e73.tar.gz | |
bitbake: cookerdata: Drop dubious exception handling code
This code appears to be dangerous, it swallows exceptions, turning them into
"handled" versions which then show no errors to the user. This is a pretty
poor user experience and I can't see why this code should be swallowing
such things. Drop the worst bits of code.
(Bitbake rev: 13279044f16f2cf2502ebf39d277415f99bb6c18)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | bitbake/lib/bb/cookerdata.py | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/bitbake/lib/bb/cookerdata.py b/bitbake/lib/bb/cookerdata.py index 38d0b4666e..adde0e7444 100644 --- a/bitbake/lib/bb/cookerdata.py +++ b/bitbake/lib/bb/cookerdata.py | |||
| @@ -294,14 +294,9 @@ class CookerDataBuilder(object): | |||
| 294 | bb.event.fire(bb.event.MultiConfigParsed(mcdata), self.data) | 294 | bb.event.fire(bb.event.MultiConfigParsed(mcdata), self.data) |
| 295 | 295 | ||
| 296 | self.data_hash = data_hash.hexdigest() | 296 | self.data_hash = data_hash.hexdigest() |
| 297 | except (SyntaxError, bb.BBHandledException): | ||
| 298 | raise bb.BBHandledException() | ||
| 299 | except bb.data_smart.ExpansionError as e: | 297 | except bb.data_smart.ExpansionError as e: |
| 300 | logger.error(str(e)) | 298 | logger.error(str(e)) |
| 301 | raise bb.BBHandledException() | 299 | raise bb.BBHandledException() |
| 302 | except Exception: | ||
| 303 | logger.exception("Error parsing configuration files") | ||
| 304 | raise bb.BBHandledException() | ||
| 305 | 300 | ||
| 306 | bb.codeparser.update_module_dependencies(self.data) | 301 | bb.codeparser.update_module_dependencies(self.data) |
| 307 | 302 | ||
