summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Marko <peter.marko@siemens.com>2025-11-22 23:16:54 +0100
committerSteve Sakoman <steve@sakoman.com>2025-12-01 07:34:55 -0800
commite6bfeed8f3e72c577820e3d01f7d697c4d3fc5d4 (patch)
tree5e336288c687cc56a41b69d5d9e8f5147de14673
parent842fd60ebb87c607b9a7a4db77d4e9fb8a123bea (diff)
downloadpoky-e6bfeed8f3e72c577820e3d01f7d697c4d3fc5d4.tar.gz
libarchive: patch CVE-2025-60753
Pick patch from [3] marked in [2] mentioned in [1]. [1] https://nvd.nist.gov/vuln/detail/CVE-2025-60753 [2] https://github.com/libarchive/libarchive/issues/2725 [3] https://github.com/libarchive/libarchive/pull/2787 (From OE-Core rev: 1fbd9eddbdf0da062df0510cabff6f6ee33d5752) Signed-off-by: Peter Marko <peter.marko@siemens.com> Signed-off-by: Steve Sakoman <steve@sakoman.com>
-rw-r--r--meta/recipes-extended/libarchive/libarchive/CVE-2025-60753.patch76
-rw-r--r--meta/recipes-extended/libarchive/libarchive_3.7.9.bb1
2 files changed, 77 insertions, 0 deletions
diff --git a/meta/recipes-extended/libarchive/libarchive/CVE-2025-60753.patch b/meta/recipes-extended/libarchive/libarchive/CVE-2025-60753.patch
new file mode 100644
index 0000000000..730a6128c3
--- /dev/null
+++ b/meta/recipes-extended/libarchive/libarchive/CVE-2025-60753.patch
@@ -0,0 +1,76 @@
1From 3150539edb18690c2c5f81c37fd2d3a35c69ace5 Mon Sep 17 00:00:00 2001
2From: =?UTF-8?q?ARJANEN=20Lo=C3=AFc=20Jean=20David?= <ljd@luigiscorner.mu>
3Date: Fri, 14 Nov 2025 20:34:48 +0100
4Subject: [PATCH] Fix bsdtar zero-length pattern issue.
5MIME-Version: 1.0
6Content-Type: text/plain; charset=UTF-8
7Content-Transfer-Encoding: 8bit
8
9Uses the sed-like way (and Java-like, and .Net-like, and Javascript-like…) to fix this issue of advancing the string to be processed by one if the match is zero-length.
10
11Fixes libarchive/libarchive#2725 and solves libarchive/libarchive#2438.
12
13CVE: CVE-2025-60753
14Upstream-Status: Backport [https://github.com/libarchive/libarchive/commit/3150539edb18690c2c5f81c37fd2d3a35c69ace5]
15Signed-off-by: Peter Marko <peter.marko@siemens.com>
16---
17 tar/subst.c | 19 ++++++++++++-------
18 tar/test/test_option_s.c | 8 +++++++-
19 2 files changed, 19 insertions(+), 8 deletions(-)
20
21diff --git a/tar/subst.c b/tar/subst.c
22index 9747abb9..902a4d64 100644
23--- a/tar/subst.c
24+++ b/tar/subst.c
25@@ -235,7 +235,9 @@ apply_substitution(struct bsdtar *bsdtar, const char *name, char **result,
26 (*result)[0] = 0;
27 }
28
29- while (1) {
30+ char isEnd = 0;
31+ do {
32+ isEnd = *name == '\0';
33 if (regexec(&rule->re, name, 10, matches, 0))
34 break;
35
36@@ -290,12 +292,15 @@ apply_substitution(struct bsdtar *bsdtar, const char *name, char **result,
37 }
38
39 realloc_strcat(result, rule->result + j);
40-
41- name += matches[0].rm_eo;
42-
43- if (!rule->global)
44- break;
45- }
46+ if (matches[0].rm_eo > 0) {
47+ name += matches[0].rm_eo;
48+ } else {
49+ // We skip a character because the match is 0-length
50+ // so we need to add it to the output
51+ realloc_strncat(result, name, 1);
52+ name += 1;
53+ }
54+ } while (rule->global && !isEnd); // Testing one step after because sed et al. run 0-length patterns a last time on the empty string at the end
55 }
56
57 if (got_match)
58diff --git a/tar/test/test_option_s.c b/tar/test/test_option_s.c
59index 564793b9..90b4c471 100644
60--- a/tar/test/test_option_s.c
61+++ b/tar/test/test_option_s.c
62@@ -42,7 +42,13 @@ DEFINE_TEST(test_option_s)
63 systemf("%s -cf test1_2.tar -s /d1/d2/ in/d1/foo", testprog);
64 systemf("%s -xf test1_2.tar -C test1", testprog);
65 assertFileContents("foo", 3, "test1/in/d2/foo");
66-
67+ systemf("%s -cf test1_3.tar -s /o/#/g in/d1/foo", testprog);
68+ systemf("%s -xf test1_3.tar -C test1", testprog);
69+ assertFileContents("foo", 3, "test1/in/d1/f##");
70+ // For the 0-length pattern check, remember that "test1/" isn't part of the string affected by the regexp
71+ systemf("%s -cf test1_4.tar -s /f*/\\<~\\>/g in/d1/foo", testprog);
72+ systemf("%s -xf test1_4.tar -C test1", testprog);
73+ assertFileContents("foo", 3, "test1/<>i<>n<>/<>d<>1<>/<f><>o<>o<>");
74 /*
75 * Test 2: Basic substitution when extracting archive.
76 */
diff --git a/meta/recipes-extended/libarchive/libarchive_3.7.9.bb b/meta/recipes-extended/libarchive/libarchive_3.7.9.bb
index da11e052a7..86ba53aaf2 100644
--- a/meta/recipes-extended/libarchive/libarchive_3.7.9.bb
+++ b/meta/recipes-extended/libarchive/libarchive_3.7.9.bb
@@ -42,6 +42,7 @@ SRC_URI = "http://libarchive.org/downloads/libarchive-${PV}.tar.gz \
42 file://0001-Merge-pull-request-2749-from-KlaraSystems-des-tempdi.patch \ 42 file://0001-Merge-pull-request-2749-from-KlaraSystems-des-tempdi.patch \
43 file://0001-Merge-pull-request-2753-from-KlaraSystems-des-temp-f.patch \ 43 file://0001-Merge-pull-request-2753-from-KlaraSystems-des-temp-f.patch \
44 file://0001-Merge-pull-request-2768-from-Commandoss-master.patch \ 44 file://0001-Merge-pull-request-2768-from-Commandoss-master.patch \
45 file://CVE-2025-60753.patch \
45 " 46 "
46UPSTREAM_CHECK_URI = "http://libarchive.org/" 47UPSTREAM_CHECK_URI = "http://libarchive.org/"
47 48