summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTrevor Woerner <twoerner@gmail.com>2025-05-02 13:21:43 -0400
committerSteve Sakoman <steve@sakoman.com>2025-05-19 08:32:49 -0700
commit941f3a952771043f7ab1b9a9193fcad27613a486 (patch)
treede4fd884523bfa55cdae16e736ccd654b78082a2
parent8f02cfd6275a03be8a11830789bbb54da4eea9bf (diff)
downloadpoky-941f3a952771043f7ab1b9a9193fcad27613a486.tar.gz
contributor-guide/submit-changes: encourage patch version changelogs
Add a section after the 'git format-patch' information encouraging developers to add patch version changelogs to their patch updates. (From yocto-docs rev: 78fd3b3f1ec797dfe3648509a1945241b50640d5) Signed-off-by: Trevor Woerner <twoerner@gmail.com> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> Signed-off-by: Antonin Godard <antonin.godard@bootlin.com> (cherry picked from commit 2e3a37c4607b296956993e557d1786c4876e5722) Signed-off-by: Antonin Godard <antonin.godard@bootlin.com> Signed-off-by: Steve Sakoman <steve@sakoman.com>
-rw-r--r--documentation/contributor-guide/submit-changes.rst32
1 files changed, 32 insertions, 0 deletions
diff --git a/documentation/contributor-guide/submit-changes.rst b/documentation/contributor-guide/submit-changes.rst
index 0675aac984..6d5d69d7cf 100644
--- a/documentation/contributor-guide/submit-changes.rst
+++ b/documentation/contributor-guide/submit-changes.rst
@@ -776,6 +776,38 @@ argument to ``git format-patch`` with a version number::
776 776
777 git format-patch -v2 <ref-branch> 777 git format-patch -v2 <ref-branch>
778 778
779
780After generating updated patches (v2, v3, and so on) via ``git
781format-patch``, ideally developers will add a patch version changelog
782to each patch that describes what has changed between each revision of
783the patch. Add patch version changelogs after the ``---`` marker in the
784patch, indicating that this information is part of this patch, but is not
785suitable for inclusion in the commit message (i.e. the git history) itself.
786Providing a patch version changelog makes it easier for maintainers and
787reviewers to succinctly understand what changed in all versions of the
788patch, without having to consult alternate sources of information, such as
789searching through messages on a mailing list. For example::
790
791 <patch title>
792
793 <commit message>
794
795 <Signed-off-by/other trailers>
796 ---
797 changes in v4:
798 - provide a clearer commit message
799 - fix spelling mistakes
800
801 changes in v3:
802 - replace func() to use other_func() instead
803
804 changes in v2:
805 - this patch was added in v2
806 ---
807 <diffstat output>
808
809 <unified diff>
810
779Lastly please ensure that you also test your revised changes. In particular 811Lastly please ensure that you also test your revised changes. In particular
780please don't just edit the patch file written out by ``git format-patch`` and 812please don't just edit the patch file written out by ``git format-patch`` and
781resend it. 813resend it.