diff options
| author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2013-01-29 13:39:08 +0000 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2013-01-30 14:09:09 +0000 |
| commit | 643bac1e97239508d5dd3fe3092410bc72ce4c81 (patch) | |
| tree | ca8de86e247bf3427a9e4cf6e54fc53fb2785da6 | |
| parent | b01b1a704bf4d8cf5a7cf9ca7fd0cea08d06969e (diff) | |
| download | poky-643bac1e97239508d5dd3fe3092410bc72ce4c81.tar.gz | |
insane.bbclass: Fix incorrect getVar call
On a trace I was a bit puzzled why getVar was making 180 calls to len(d).
This is an expensive operation that should be very rarely called and
certainly not by getVar. In perl's do_package it was resulting in
~1.5 million function calls from those 180 cases.
Ultimately this typo was why. Lets fix it and save the CPU cyles.
(From OE-Core rev: a8ba821d0002e4395fc5c80649fe14f93a7971fe)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | meta/classes/insane.bbclass | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index c5c84b80c7..015abd54ca 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass | |||
| @@ -404,7 +404,7 @@ def package_qa_check_arch(path,name,d, elf, messages): | |||
| 404 | 404 | ||
| 405 | target_os = d.getVar('TARGET_OS', True) | 405 | target_os = d.getVar('TARGET_OS', True) |
| 406 | target_arch = d.getVar('TARGET_ARCH', True) | 406 | target_arch = d.getVar('TARGET_ARCH', True) |
| 407 | provides = d.getVar('PROVIDES', d, True) | 407 | provides = d.getVar('PROVIDES', True) |
| 408 | bpn = d.getVar('BPN', True) | 408 | bpn = d.getVar('BPN', True) |
| 409 | 409 | ||
| 410 | # FIXME: Cross package confuse this check, so just skip them | 410 | # FIXME: Cross package confuse this check, so just skip them |