diff options
| author | Robert Yang <liezhi.yang@windriver.com> | 2016-01-06 23:45:22 -0800 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-01-11 23:26:30 +0000 |
| commit | 11f5a4293615123daaf5d960166617192409095e (patch) | |
| tree | 8daa1cdb5bc239801d5e81e8bab06bbfae2d5b51 | |
| parent | 235606f31b720094fdeb3bb3eb0c09347c23ee5d (diff) | |
| download | poky-11f5a4293615123daaf5d960166617192409095e.tar.gz | |
cogl-1.0: fix may be used uninitialized error
Fixed when DEBUG_BUILD = "1":
test-backface-culling.c:206:7: error: 'cull_front' may be used uninitialized in this function [-Werror=maybe-uninitialized]
| validate_part (framebuffer,
| ^
| cc1: some warnings being treated as errors
(From OE-Core rev: 48b0bc85502e394f13898bbec61e21f9282b0edf)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | meta/recipes-graphics/cogl/cogl-1.0/test-backface-culling.c-fix-may-be-used-uninitialize.patch | 35 | ||||
| -rw-r--r-- | meta/recipes-graphics/cogl/cogl-1.0_1.22.0.bb | 2 |
2 files changed, 37 insertions, 0 deletions
diff --git a/meta/recipes-graphics/cogl/cogl-1.0/test-backface-culling.c-fix-may-be-used-uninitialize.patch b/meta/recipes-graphics/cogl/cogl-1.0/test-backface-culling.c-fix-may-be-used-uninitialize.patch new file mode 100644 index 0000000000..479a0ff4b5 --- /dev/null +++ b/meta/recipes-graphics/cogl/cogl-1.0/test-backface-culling.c-fix-may-be-used-uninitialize.patch | |||
| @@ -0,0 +1,35 @@ | |||
| 1 | From a51f61d675a0e7d6649182c6a1325ceab8342df2 Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Robert Yang <liezhi.yang@windriver.com> | ||
| 3 | Date: Mon, 4 Jan 2016 22:47:29 -0800 | ||
| 4 | Subject: [PATCH] test-backface-culling.c: fix may be used uninitialized error | ||
| 5 | |||
| 6 | Fixed when gcc -O: | ||
| 7 | test-backface-culling.c:206:7: error: 'cull_front' may be used uninitialized in this function [-Werror=maybe-uninitialized] | ||
| 8 | | validate_part (framebuffer, | ||
| 9 | | ^ | ||
| 10 | | cc1: some warnings being treated as errors | ||
| 11 | |||
| 12 | Upstream-Status: Pending | ||
| 13 | |||
| 14 | Signed-off-by: Robert Yang <liezhi.yang@windriver.com> | ||
| 15 | --- | ||
| 16 | tests/conform/test-backface-culling.c | 3 ++- | ||
| 17 | 1 file changed, 2 insertions(+), 1 deletion(-) | ||
| 18 | |||
| 19 | diff --git a/tests/conform/test-backface-culling.c b/tests/conform/test-backface-culling.c | ||
| 20 | index e90c2f5..7c45592 100644 | ||
| 21 | --- a/tests/conform/test-backface-culling.c | ||
| 22 | +++ b/tests/conform/test-backface-culling.c | ||
| 23 | @@ -164,7 +164,8 @@ validate_result (CoglFramebuffer *framebuffer, int y_offset) | ||
| 24 | |||
| 25 | for (draw_num = 0; draw_num < 16; draw_num++) | ||
| 26 | { | ||
| 27 | - CoglBool cull_front, cull_back; | ||
| 28 | + CoglBool cull_front = FALSE; | ||
| 29 | + CoglBool cull_back = FALSE; | ||
| 30 | CoglPipelineCullFaceMode cull_mode; | ||
| 31 | |||
| 32 | if (USE_LEGACY_STATE (draw_num)) | ||
| 33 | -- | ||
| 34 | 1.7.9.5 | ||
| 35 | |||
diff --git a/meta/recipes-graphics/cogl/cogl-1.0_1.22.0.bb b/meta/recipes-graphics/cogl/cogl-1.0_1.22.0.bb index 3b1e1994e0..ed10c7a39f 100644 --- a/meta/recipes-graphics/cogl/cogl-1.0_1.22.0.bb +++ b/meta/recipes-graphics/cogl/cogl-1.0_1.22.0.bb | |||
| @@ -1,5 +1,7 @@ | |||
| 1 | require cogl-1.0.inc | 1 | require cogl-1.0.inc |
| 2 | 2 | ||
| 3 | SRC_URI += "file://test-backface-culling.c-fix-may-be-used-uninitialize.patch" | ||
| 4 | |||
| 3 | LIC_FILES_CHKSUM = "file://COPYING;md5=1b1a508d91d25ca607c83f92f3e31c84" | 5 | LIC_FILES_CHKSUM = "file://COPYING;md5=1b1a508d91d25ca607c83f92f3e31c84" |
| 4 | SRC_URI[archive.md5sum] = "ab684ec96848d79d22757fb3064820c8" | 6 | SRC_URI[archive.md5sum] = "ab684ec96848d79d22757fb3064820c8" |
| 5 | SRC_URI[archive.sha256sum] = "689dfb5d14fc1106e9d2ded0f7930dcf7265d0bc84fa846b4f03941633eeaa91" | 7 | SRC_URI[archive.sha256sum] = "689dfb5d14fc1106e9d2ded0f7930dcf7265d0bc84fa846b4f03941633eeaa91" |
