summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMauro Queiros <maurofrqueiros@gmail.com>2023-02-07 22:37:04 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2023-02-24 16:41:51 +0000
commit03759a65ce02988f48b8c3e70c83a6170810a78c (patch)
treec55f4205837ef161ec6b0e48f399f6bbd3059861
parentc4d3f42c7cac91eca77141b04895ee41e6b50694 (diff)
downloadpoky-03759a65ce02988f48b8c3e70c83a6170810a78c.tar.gz
image.bbclass: print all QA functions exceptions
For the QA checks in `image.bbclass`, all exceptions other than `oe.utils.ImageQAFailed` always print the following generic message: "Image QA function func_name failed" This can be very misleading, as it may hide python syntax errors and other kind of issues that are hard to detect without more explicit error messages. This change makes sure that the error message of all exceptions are displayed. Before this change: "Image QA function func_name failed" After this change: "Image QA function func_name failed: f-string: empty expression not allowed (<string>, line 13)" (From OE-Core rev: c2cdbf0a0b2d27778f55db8fc685e62c2515e805) Signed-off-by: Mauro Queiros <maurofrqueiros@gmail.com> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 3d85b30d8704d38b86f5b006748cebc74bd2a4fa) Signed-off-by: Steve Sakoman <steve@sakoman.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/classes-recipe/image.bbclass2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes-recipe/image.bbclass b/meta/classes-recipe/image.bbclass
index e5e5274924..14528e664c 100644
--- a/meta/classes-recipe/image.bbclass
+++ b/meta/classes-recipe/image.bbclass
@@ -318,7 +318,7 @@ fakeroot python do_image_qa () {
318 except oe.utils.ImageQAFailed as e: 318 except oe.utils.ImageQAFailed as e:
319 qamsg = qamsg + '\tImage QA function %s failed: %s\n' % (e.name, e.description) 319 qamsg = qamsg + '\tImage QA function %s failed: %s\n' % (e.name, e.description)
320 except Exception as e: 320 except Exception as e:
321 qamsg = qamsg + '\tImage QA function %s failed\n' % cmd 321 qamsg = qamsg + '\tImage QA function %s failed: %s\n' % (cmd, e)
322 322
323 if qamsg: 323 if qamsg:
324 imgname = d.getVar('IMAGE_NAME') 324 imgname = d.getVar('IMAGE_NAME')