linux/poky.git/scripts/contrib/patchreview.py, branch yocto-5.2.4

scripts: patchreview: fix failure when running from a different folder

2024-11-21T12:16:28+00:00

When running patchreview with --blame, the scripts runs a git log command on the analyzed patch. When trying to analyse a layer which is not in poky tree, we might be running the git log command from outside the git workspace where the file is located, which results in such failures: Missing Signed-off-by tag ([truncated]/meta-qcom-hwe/recipes-devtools/partition-utils/qcom-ptool/0001-ptool.py-Generate-zero-files-in-output-folder-when-s.patch) fatal: not a git repository (or any parent up to mount point /local/mnt) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). Fix this situation by setting the current work dir inside the git workspace of the patch when running git log. (From OE-Core rev: 8cc1c900b91d60e633f62bfe16a2ffc2d61c3f55) Signed-off-by: Nicolas Dechesne Signed-off-by: Richard Purdie

patchreview: use check_upstream_status() from oe.qa

2024-11-12T11:19:44+00:00

* the idea was to reuse the same function as I've noticed that the QA check which was added to insane.bbclass in: https://git.openembedded.org/openembedded-core/commit/?id=76a685bfcf927593eac67157762a53259089ea8a is in some cases more strcit than scripts/contrib/patchreview.py To be honest I wasn't aware of scripts/contrib/patchreview.py existence when I've asked about moving check_upstream_status() to oe.qa in order to write standalone script just like patchreview.py * I've sent this long time ago: https://lists.openembedded.org/g/openembedded-core/message/177207 but didn't like the sys.path.append to find oe.qa much or the duplicated path to .patch file in the output, then I've forgot about it until today in https://github.com/OE4T/meta-tegra/pull/1749 where checklayer found one more issue, which I haven't noticed with patchreview.py before (because I've accidentally used a version without this change). It's not perfect, but at least it will be consistent with checklayer and patch-status QA check. (From OE-Core rev: f291c08ea6a95638c3ad1f70434678bd5e374195) Signed-off-by: Martin Jansa Signed-off-by: Richard Purdie

scripts/contrib/patchreview: fix commit identification

2023-10-30T11:53:20+00:00

git show-ref looks at the _remote_ ref called HEAD, which is fine when it matches the local HEAD but problematic when you're iterating a series of commits. Use rev-parse to resolve the local name to a proper hash. (From OE-Core rev: 3c04747b681cf6090ba9c77752f6c2f304dbbe17) Signed-off-by: Ross Burton Signed-off-by: Richard Purdie

scripts/contrib/patchreview: consolidate imports

2023-10-27T16:48:11+00:00

Move most imports to the top of the file. (From OE-Core rev: d2c287db0739b249604cd1beaa03ec38512ba718) Signed-off-by: Ross Burton Signed-off-by: Richard Purdie

scripts/contrib/patchreview: add commit and recipe count fields to JSON

2023-10-27T16:48:11+00:00

The autobuilder scripts post-process the generated JSON to inject recipe and commit counts into the data. We can do this easily in patchreview instead. (From OE-Core rev: 77c96e43090cbf485aec612cc2315b85e5635dda) Signed-off-by: Ross Burton Signed-off-by: Richard Purdie

scripts/patchreview: rework patch detection

2023-10-27T16:48:11+00:00

A previous patch[1] added the ability to allow the search pattern for patches to be changed, so that patchreview can be used across the entire meta-oe repository by changing the patterns. However, this means the caller needs to write long patterns when calling patchreview. Instead, we can see if the specified directory contains a layer by checking if conf/layer.conf exists. If it does, then search for patches inside this directory. If it doesn't, assume that the specified directory is a repository that contains sublayers (such as meta-openembedded) and look through each of the directories that match the pattern meta-*. This means patchreview can both scan either a single layer (eg .../poky/meta) or a repository of sublayers (eg .../meta-openembedded). [1] oe-core 599046ea9302af0cf856d3fcd827f6a2be75b7e1 (From OE-Core rev: a3a868519beab1b9cac94fefd7dbeffb09d047e9) Signed-off-by: Ross Burton Signed-off-by: Richard Purdie

scripts/patchreview: Add a custom pattern for finding recipe patches

2023-10-15T08:11:47+00:00

This introduces support for specifying a search pattern with the -p/--pattern option in the patchreview.py script. This is designed to accommodate the directory structure of meta-openembedded. (From OE-Core rev: 599046ea9302af0cf856d3fcd827f6a2be75b7e1) Signed-off-by: Mickael RAMILISON Reviewed-by: Yoann Congal Signed-off-by: Luca Ceresoli Signed-off-by: Richard Purdie

scripts: Add copyright statements to files without one

2022-08-12T10:58:01+00:00

Where there isn't a copyright statement, add one to make it explicit. Also drop editor config lines where they were present and add license identifiers as MIT if there isn't one. (From OE-Core rev: deb3ccec53e0bd63bc4235cf2b0d3fc781687361) Signed-off-by: Richard Purdie

scripts/patchreview: Make json output human parsable

2022-05-23T13:00:38+00:00

Sort dict keys in the json output and use tab spacing. This means when commited into git, the diffs are human readable but it is more compact filesize than space indentation. (From OE-Core rev: bde2ecb203d8a1a29715c70ca3ded382982390cf) Signed-off-by: Richard Purdie

scripts/patchreview: Add commit to stored json data

2022-05-23T13:00:38+00:00

Save commit data when writing to the json file so the results can be copared/extended later. (From OE-Core rev: da761ac1984ee2a06ded905fc4ad878ef7d613e4) Signed-off-by: Richard Purdie