linux/poky.git/meta/recipes-extended/bash, branch uninative-2.6

bash: use setpriv, sed.sed to run ptests

2019-06-18T10:23:48+00:00

The execscript test in bash fails when run with ptest-runner calling 'su', with the error: bash: cannot set terminal process group (16036): Inappropriate ioctl for device Even with ptest-runner fixed to make a child process use the right process group, 'su' still results in the warning above. Use 'setpriv' instead. 'runuser' was considered and works but depends on pam so it's ruled out. Now that all bash tests are run as a user, the patch: fix-run-coproc-run-heredoc-run-execscript-run-test-f.patch can be removed. Also to create the account 'bashtest' in the 'run-ptest' script the bash-ptest must depend on 'shadow'. Also, in 'run-ptest', ensure that the bash ptests are owned by the 'bashtest' user. Add 'sed' as a dependency for ptests since tests/exp8.sub runs: var=$'x\001y\177z' declare -p var | sed -n l and that results in: sed.busybox: "" sed.sed: declare -- var="x\001y\177z"$ This appears to be a feature that busybox sed has not implemented. With this series of changes, bash-ptest for qemux86-64 passes 79 of 81 tests. The remaining failures are: 1. run-read: # cat tests/read6.sub # test read with a timeout of 0 -- input polling # sleep with fractional seconds argument is not universal echo abcde | { sleep 0.25 2>/dev/null ; read -t 0; } echo $? read -t 0 < $0 echo $? read -t 0 echo $? <-- returns 1, when 0 is expected. I can reproduce this on my workstation but only when using ptest-runner and initially logging into the console as root. That's a little odd and seems like I need to continue to improve ptest-runner. 2. run-trap: # cat tests/trap3.sub PS4='+[$LINENO] ' trap 'echo trap: $LINENO' ERR set -x echo 1 echo 2 echo 3 | cat | false <--- error echo 4 This is a scheduler behaviour difference between the common case on a workstation and the common case in qemu. The test case does warn about the completion order not being deterministic so I plan to ignore it. >From tests/run-trap: UNIX versions number signals and schedule processes differently. If output differing only in line numbers is produced, please do not consider this a test failure. Still, it's notable and slightly odd that the common case output is different. (From OE-Core rev: 81e3f01867cf114b728ab5a417c29426c9bf8122) Signed-off-by: Sakib Sajal Signed-off-by: Randy MacLeod Signed-off-by: Richard Purdie

bash: Replace uninative loader path in ptest

2019-06-07T08:11:49+00:00

The Makefile used for bash-ptest can pick up the path to the uninative loader through BUILD_LDFLAGS. This includes the full path to the uninative loader, which is not reproducible. Replace it with /bin/false. It doesn't appear as if these native programs are used in the test suites and if there are likely to be other problems related to building them using the BUILD_* flags. (From OE-Core rev: 1208ff934a2bb6378aa8b219345110a0d56bf767) Signed-off-by: Joshua Watt Signed-off-by: Richard Purdie

bash: run bash ptest as non-root user

2019-06-01T10:27:07+00:00

new-exp ptest fails as it expects non-root user. >From the failed ptest log: < new-exp.tests: the test suite should not be run as root 628c627 < argv[1] = --- > argv[1] = FAIL: run-new-exp Many of the ptests declare that they should not be run as root and a few fail since the expected result strings are for a user shell. When ptests are run as bash_user (non-root) the glob test fails with error: run-glob-test 59,60d58 < touch: cannot touch 'a?': Permission denied < touch: cannot touch 'aa': Permission denied So ensure that the bash/ptest/tests directory is owned by the bash_user while the tests are being run and return it to root owner afterwards. (From OE-Core rev: c125609886b36048cfde6e694eee7fb47f197241) Signed-off-by: Sakib Sajal Signed-off-by: Randy Macleod Signed-off-by: Richard Purdie

bash: add big5hkscs gconv RDEPENDS needed by bash-ptest.

2019-06-01T10:27:07+00:00

glob-test failed beacuse it could not convert big5hkscs encoding to perform comparison. (From OE-Core rev: 8e147863c4c0fdc22da92e2e5e35502906eac916) Signed-off-by: Sakib Sajal Signed-off-by: Randy Macleod Signed-off-by: Richard Purdie

bash: add iso8859-1 gconv RDEPENDS needed by bash-ptest.

2019-05-29T11:54:12+00:00

One of the ptests failed for internationalization. >From the failed ptest log: run-intl fr_FR.ISO8859-1: Error Encoding U+00000080 to [ "$'\200'" != "\\u0080" ] (125 similar errors related to same encoding) The test was unable to convert iso8859-1 encoding to perform comparison. (From OE-Core rev: ec1849d7a5964bef53462b9d4763e22433f9d246) Signed-off-by: Sakib Sajal Signed-off-by: Randy Macleod Signed-off-by: Richard Purdie

bash: Fix bash-ptest dependencies

2019-05-22T06:24:52+00:00

Bash's ptest needs glibc-utils (for locale), some extra locales for various tests it uses options busybox doesn't support for some tools, hence coreutils and also runs perl for some tests. (From OE-Core rev: 7ce6f69e56ef7ccc0187722cd78728a6505073b7) Signed-off-by: Richard Purdie

bash: upgrade 4.4.18 -> 5.0

2019-05-12T16:55:11+00:00

- Rebase build-tests.patch and execute_cmd.patch to 5.0 - Drop 0001-help-fix-printf-format-security-warning.patch and pathexp-dep.patch, upstream has fixed them in commit [d233b48 bash-5.0 distribution sources and documentation] (From OE-Core rev: db044235e72a1519a081c4f6541f7d7cfe70d49f) Signed-off-by: Hongxu Jia Signed-off-by: Richard Purdie

bash: 4.4.18 -> 4.4.23

2018-09-27T22:41:41+00:00

Apply point release patches from upstream which includes a fix for indefinitely spinning process and a zombie by a simple $() statement in a long running script. (From OE-Core rev: eb39670fb2fe9735a1a0434c63b64ec66599f850) Signed-off-by: Jeroen Hofstee Signed-off-by: Richard Purdie

bash: add -fomit-frame-pointer to DEBUG_OPTIMIZATION for armv[45] with thumb enabled

2018-08-08T09:52:00+00:00

with thumb and debug enabled bash gets stuck forever when building for qemuarm. bash/4.4.18-r0/build/builtins$ arm-webos-linux-gnueabi-gcc -march=armv5te -mthumb -fstack-protector-strong --sysroot=bash/4.4.18-r0/recipe-sysroot -c -DHAVE_CONFIG_H -DSHELL -I. -I.. -I../../bash-4.4.18 -I../../bash-4.4.18/include -I../../bash-4.4.18/lib -I../../bash-4.4.18/builtins -O -fno-omit-frame-pointer -g -DNON_INTERACTIVE_LOGIN_SHELLS read.c when -mthumb, -fstack-protector-strong, -fno-omit-frame-pointer appear together, removing one of them is enough for successful build. similar to: http://lists.openembedded.org/pipermail/openembedded-core/2018-May/150654.html but in this case the build gets stuck instead of failure (From OE-Core rev: ae41e1f263d20d5d83b2a7ca95dc955840d793e1) Signed-off-by: Martin Jansa Signed-off-by: Ross Burton Signed-off-by: Richard Purdie

bash: fix wrong exit status offset

2018-07-18T09:18:42+00:00

In Linux，8 bits of the return code and 8 bits of the number of the killing signal are mixed into a single value on the exit code, so the exit status offset should be 8. But the autoconf checker can not determine it while cross compiling, and then it is set to the default value 0, which will cause generating the wrong exit code if program exit with an error code. (From OE-Core rev: e2dea46607a24620d6d2c250efc9b2e95bfd5ad8) Signed-off-by: Rui Wang Signed-off-by: Ross Burton Signed-off-by: Richard Purdie